From patchwork Fri Jul 21 14:35:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 13322094 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7F061ED2D for ; Fri, 21 Jul 2023 14:35:46 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1B9610C3 for ; Fri, 21 Jul 2023 07:35:37 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 599201F88E; Fri, 21 Jul 2023 14:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689950136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qKgen87lnA9actSHJ1Y5WsBzgRVxm/VtELwSTcMaw7o=; b=1LSJ2itWu+ovjrk1zPbRjd3i/ATYkJ5OU1btpYVA14RzpF/l5m5tiQUPQf6709S5Egzwnd +ZH+O/0bGDclgrL0E2jtj4N5GffRGOECO+VwmmkMPRuKRAU55kXEDZN9VXr3vO/klX0r0K tfK+DbLs/IgLBb5JFBrZa5NhwLXbGQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689950136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qKgen87lnA9actSHJ1Y5WsBzgRVxm/VtELwSTcMaw7o=; b=dFVu/+wEthKDw0+G4K2D6oYuV/ob5m8q6iPppqiyN0FeLgV4LhIXwiqc2krX3/mJxQf/IV 8Ciqo934AL1awZBg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 3345E2C142; Fri, 21 Jul 2023 14:35:36 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 2177551CA01A; Fri, 21 Jul 2023 16:35:36 +0200 (CEST) From: Hannes Reinecke To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, Jakub Kicinski , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Hannes Reinecke Subject: [PATCHv8 0/6] net/tls: fixes for NVMe-over-TLS Date: Fri, 21 Jul 2023 16:35:17 +0200 Message-Id: <20230721143523.56906-1-hare@suse.de> X-Mailer: git-send-email 2.35.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi all, here are some small fixes to get NVMe-over-TLS up and running. The first set are just minor modifications to have MSG_EOR handled for TLS, but the second set implements the ->read_sock() callback for tls_sw which I guess could do with some reviews. As usual, comments and reviews are welcome. Changes to the original submission: - Add a testcase for MSG_EOR handling Changes to v2: - Bail out on conflicting message flags - Rework flag handling Changes to v3: - Return -EINVAL on conflicting flags - Rebase on top of net-next Changes to v4: - Add tlx_rx_reader_lock() to read_sock - Add MSG_EOR handling to tls_sw_readpages() Changes to v5: - Rebase to latest upstream - Split tls_rx_reader_lock() as suggested by Sagi Changes to v6: - Fixup tls_strp_read_copyin() to avoid infinite recursion in tls_read_sock() - Rework tls_read_sock() to read all available data Changes to v7: - Include reviews from Jakub Hannes Reinecke (6): net/tls: handle MSG_EOR for tls_sw TX flow net/tls: handle MSG_EOR for tls_device TX flow selftests/net/tls: add test for MSG_EOR net/tls: Use tcp_read_sock() instead of ops->read_sock() net/tls: split tls_rx_reader_lock net/tls: implement ->read_sock() net/tls/tls.h | 2 + net/tls/tls_device.c | 6 +- net/tls/tls_main.c | 2 + net/tls/tls_strp.c | 3 +- net/tls/tls_sw.c | 132 ++++++++++++++++++++++++++---- tools/testing/selftests/net/tls.c | 11 +++ 6 files changed, 136 insertions(+), 20 deletions(-) Reviewed-by: Jakub Kicinski