From patchwork Mon Aug 7 16:45:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Moreno X-Patchwork-Id: 13344568 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAC3125A3 for ; Mon, 7 Aug 2023 16:46:03 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1935B172A for ; Mon, 7 Aug 2023 09:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691426761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7mbm28A/tpkSfWHoOvr5fgub+C6PIy7Wl+9VWpIOX2o=; b=IJeY6uOl9il9ry1SRrFkHHyuN5VVy1Jz+uXyKZtEa6m6Xzl1TxzidvSxG4hfDRTBHeTWrs r/7B13iqqvxcCZ9ygT3tsUeR0bpvBLgeQ0miHbVl+vqmyeivzKkJhJbca/5DihmFEMbQkg IuoICATYodfD1AkH/i1Uznpn+O6BEms= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-msGUVgfPO7S_ftFmF1wxiA-1; Mon, 07 Aug 2023 12:45:57 -0400 X-MC-Unique: msGUVgfPO7S_ftFmF1wxiA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 211831C05151; Mon, 7 Aug 2023 16:45:54 +0000 (UTC) Received: from antares.redhat.com (unknown [10.39.194.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1C682166B25; Mon, 7 Aug 2023 16:45:52 +0000 (UTC) From: Adrian Moreno To: netdev@vger.kernel.org Cc: Adrian Moreno , aconole@redhat.com, i.maximets@ovn.org, eric@garver.life, dev@openvswitch.org Subject: [net-next v3 0/7] openvswitch: add drop reasons Date: Mon, 7 Aug 2023 18:45:41 +0200 Message-ID: <20230807164551.553365-1-amorenoz@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org There is currently a gap in drop visibility in the openvswitch module. This series tries to improve this by adding a new drop reason subsystem for OVS. Apart from adding a new drop reasson subsystem and some common drop reasons, this series takes Eric's preliminary work [1] on adding an explicit drop action and integrates it into the same subsystem. A limitation of this series is that it does not report upcall errors. The reason is that there could be many sources of upcall drops and the most common one, which is the netlink buffer overflow, cannot be reported via kfree_skb() because the skb is freed in the netlink layer (see [2]). Therefore, using a reason for the rare events and not the common one would be even more misleading. I'd propose we add (in a follow up patch) a tracepoint to better report upcall errors. [1] https://lore.kernel.org/netdev/202306300609.tdRdZscy-lkp@intel.com/T/ [2] commit 1100248a5c5c ("openvswitch: Fix double reporting of drops in dropwatch") --- rfc2 -> v3: - Rebased on top of latest net-next rfc1 -> rfc2: - Fail when an explicit drop is not the last - Added a drop reason for action errors - Added braces around macros - Dropped patch that added support for masks in ovs-dpctl.py as it's now included in Aaron's series [2]. Adrian Moreno (6): net: openvswitch: add datapath flow drop reason net: openvswitch: add action error drop reason net: openvswitch: add meter drop reason net: openvswitch: add misc error drop reasons selftests: openvswitch: add drop reason testcase selftests: openvswitch: add explicit drop testcase Eric Garver (1): net: openvswitch: add explicit drop action include/net/dropreason.h | 6 ++ include/uapi/linux/openvswitch.h | 2 + net/openvswitch/actions.c | 42 ++++++--- net/openvswitch/conntrack.c | 3 +- net/openvswitch/datapath.c | 16 ++++ net/openvswitch/drop.h | 34 +++++++ net/openvswitch/flow_netlink.c | 10 +- .../selftests/net/openvswitch/openvswitch.sh | 92 ++++++++++++++++++- .../selftests/net/openvswitch/ovs-dpctl.py | 22 ++++- 9 files changed, 209 insertions(+), 18 deletions(-) create mode 100644 net/openvswitch/drop.h