mbox series

[net,v2,00/17] selftests: forwarding: Various fixes

Message ID 20230808141503.4060661-1-idosch@nvidia.com (mailing list archive)
Headers show
Series selftests: forwarding: Various fixes | expand

Message

Ido Schimmel Aug. 8, 2023, 2:14 p.m. UTC
Fix various problems with forwarding selftests. See individual patches
for problem description and solution.

v2:
* Patch #10: Probe for MAC Merge support.

Ido Schimmel (17):
  selftests: forwarding: Skip test when no interfaces are specified
  selftests: forwarding: Switch off timeout
  selftests: forwarding: bridge_mdb: Check iproute2 version
  selftests: forwarding: bridge_mdb_max: Check iproute2 version
  selftests: forwarding: Set default IPv6 traceroute utility
  selftests: forwarding: Add a helper to skip test when using veth pairs
  selftests: forwarding: ethtool: Skip when using veth pairs
  selftests: forwarding: ethtool_extended_state: Skip when using veth
    pairs
  selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs
  selftests: forwarding: ethtool_mm: Skip when MAC Merge is not
    supported
  selftests: forwarding: tc_actions: Use ncat instead of nc
  selftests: forwarding: tc_flower: Relax success criterion
  selftests: forwarding: tc_tunnel_key: Make filters more specific
  selftests: forwarding: tc_flower_l2_miss: Fix failing test with old
    libnet
  selftests: forwarding: bridge_mdb: Fix failing test with old libnet
  selftests: forwarding: bridge_mdb_max: Fix failing test with old
    libnet
  selftests: forwarding: bridge_mdb: Make test more robust

 .../selftests/net/forwarding/bridge_mdb.sh    | 59 +++++++++++--------
 .../net/forwarding/bridge_mdb_max.sh          | 19 ++++--
 .../selftests/net/forwarding/ethtool.sh       |  2 +
 .../net/forwarding/ethtool_extended_state.sh  |  2 +
 .../selftests/net/forwarding/ethtool_mm.sh    | 18 ++++--
 .../net/forwarding/hw_stats_l3_gre.sh         |  2 +
 .../net/forwarding/ip6_forward_instats_vrf.sh |  2 +
 tools/testing/selftests/net/forwarding/lib.sh | 17 ++++++
 .../testing/selftests/net/forwarding/settings |  1 +
 .../selftests/net/forwarding/tc_actions.sh    |  6 +-
 .../selftests/net/forwarding/tc_flower.sh     |  8 +--
 .../net/forwarding/tc_flower_l2_miss.sh       | 13 ++--
 .../selftests/net/forwarding/tc_tunnel_key.sh |  9 ++-
 13 files changed, 109 insertions(+), 49 deletions(-)
 create mode 100644 tools/testing/selftests/net/forwarding/settings

Comments

Hangbin Liu Aug. 9, 2023, 6:47 a.m. UTC | #1
On Tue, Aug 08, 2023 at 05:14:46PM +0300, Ido Schimmel wrote:
> Fix various problems with forwarding selftests. See individual patches
> for problem description and solution.

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

> 
> v2:
> * Patch #10: Probe for MAC Merge support.
> 
> Ido Schimmel (17):
>   selftests: forwarding: Skip test when no interfaces are specified
>   selftests: forwarding: Switch off timeout
>   selftests: forwarding: bridge_mdb: Check iproute2 version
>   selftests: forwarding: bridge_mdb_max: Check iproute2 version
>   selftests: forwarding: Set default IPv6 traceroute utility
>   selftests: forwarding: Add a helper to skip test when using veth pairs
>   selftests: forwarding: ethtool: Skip when using veth pairs
>   selftests: forwarding: ethtool_extended_state: Skip when using veth
>     pairs
>   selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs
>   selftests: forwarding: ethtool_mm: Skip when MAC Merge is not
>     supported
>   selftests: forwarding: tc_actions: Use ncat instead of nc
>   selftests: forwarding: tc_flower: Relax success criterion
>   selftests: forwarding: tc_tunnel_key: Make filters more specific
>   selftests: forwarding: tc_flower_l2_miss: Fix failing test with old
>     libnet
>   selftests: forwarding: bridge_mdb: Fix failing test with old libnet
>   selftests: forwarding: bridge_mdb_max: Fix failing test with old
>     libnet
>   selftests: forwarding: bridge_mdb: Make test more robust
> 
>  .../selftests/net/forwarding/bridge_mdb.sh    | 59 +++++++++++--------
>  .../net/forwarding/bridge_mdb_max.sh          | 19 ++++--
>  .../selftests/net/forwarding/ethtool.sh       |  2 +
>  .../net/forwarding/ethtool_extended_state.sh  |  2 +
>  .../selftests/net/forwarding/ethtool_mm.sh    | 18 ++++--
>  .../net/forwarding/hw_stats_l3_gre.sh         |  2 +
>  .../net/forwarding/ip6_forward_instats_vrf.sh |  2 +
>  tools/testing/selftests/net/forwarding/lib.sh | 17 ++++++
>  .../testing/selftests/net/forwarding/settings |  1 +
>  .../selftests/net/forwarding/tc_actions.sh    |  6 +-
>  .../selftests/net/forwarding/tc_flower.sh     |  8 +--
>  .../net/forwarding/tc_flower_l2_miss.sh       | 13 ++--
>  .../selftests/net/forwarding/tc_tunnel_key.sh |  9 ++-
>  13 files changed, 109 insertions(+), 49 deletions(-)
>  create mode 100644 tools/testing/selftests/net/forwarding/settings
> 
> -- 
> 2.40.1
>
Nikolay Aleksandrov Aug. 9, 2023, 12:10 p.m. UTC | #2
On 8/8/23 17:14, Ido Schimmel wrote:
> Fix various problems with forwarding selftests. See individual patches
> for problem description and solution.
> 
> v2:
> * Patch #10: Probe for MAC Merge support.
> 

Nice! Thanks for taking the time to fix all these.
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

> Ido Schimmel (17):
>    selftests: forwarding: Skip test when no interfaces are specified
>    selftests: forwarding: Switch off timeout
>    selftests: forwarding: bridge_mdb: Check iproute2 version
>    selftests: forwarding: bridge_mdb_max: Check iproute2 version
>    selftests: forwarding: Set default IPv6 traceroute utility
>    selftests: forwarding: Add a helper to skip test when using veth pairs
>    selftests: forwarding: ethtool: Skip when using veth pairs
>    selftests: forwarding: ethtool_extended_state: Skip when using veth
>      pairs
>    selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs
>    selftests: forwarding: ethtool_mm: Skip when MAC Merge is not
>      supported
>    selftests: forwarding: tc_actions: Use ncat instead of nc
>    selftests: forwarding: tc_flower: Relax success criterion
>    selftests: forwarding: tc_tunnel_key: Make filters more specific
>    selftests: forwarding: tc_flower_l2_miss: Fix failing test with old
>      libnet
>    selftests: forwarding: bridge_mdb: Fix failing test with old libnet
>    selftests: forwarding: bridge_mdb_max: Fix failing test with old
>      libnet
>    selftests: forwarding: bridge_mdb: Make test more robust
> 
>   .../selftests/net/forwarding/bridge_mdb.sh    | 59 +++++++++++--------
>   .../net/forwarding/bridge_mdb_max.sh          | 19 ++++--
>   .../selftests/net/forwarding/ethtool.sh       |  2 +
>   .../net/forwarding/ethtool_extended_state.sh  |  2 +
>   .../selftests/net/forwarding/ethtool_mm.sh    | 18 ++++--
>   .../net/forwarding/hw_stats_l3_gre.sh         |  2 +
>   .../net/forwarding/ip6_forward_instats_vrf.sh |  2 +
>   tools/testing/selftests/net/forwarding/lib.sh | 17 ++++++
>   .../testing/selftests/net/forwarding/settings |  1 +
>   .../selftests/net/forwarding/tc_actions.sh    |  6 +-
>   .../selftests/net/forwarding/tc_flower.sh     |  8 +--
>   .../net/forwarding/tc_flower_l2_miss.sh       | 13 ++--
>   .../selftests/net/forwarding/tc_tunnel_key.sh |  9 ++-
>   13 files changed, 109 insertions(+), 49 deletions(-)
>   create mode 100644 tools/testing/selftests/net/forwarding/settings
>
patchwork-bot+netdevbpf@kernel.org Aug. 9, 2023, 10 p.m. UTC | #3
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 8 Aug 2023 17:14:46 +0300 you wrote:
> Fix various problems with forwarding selftests. See individual patches
> for problem description and solution.
> 
> v2:
> * Patch #10: Probe for MAC Merge support.
> 
> Ido Schimmel (17):
>   selftests: forwarding: Skip test when no interfaces are specified
>   selftests: forwarding: Switch off timeout
>   selftests: forwarding: bridge_mdb: Check iproute2 version
>   selftests: forwarding: bridge_mdb_max: Check iproute2 version
>   selftests: forwarding: Set default IPv6 traceroute utility
>   selftests: forwarding: Add a helper to skip test when using veth pairs
>   selftests: forwarding: ethtool: Skip when using veth pairs
>   selftests: forwarding: ethtool_extended_state: Skip when using veth
>     pairs
>   selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs
>   selftests: forwarding: ethtool_mm: Skip when MAC Merge is not
>     supported
>   selftests: forwarding: tc_actions: Use ncat instead of nc
>   selftests: forwarding: tc_flower: Relax success criterion
>   selftests: forwarding: tc_tunnel_key: Make filters more specific
>   selftests: forwarding: tc_flower_l2_miss: Fix failing test with old
>     libnet
>   selftests: forwarding: bridge_mdb: Fix failing test with old libnet
>   selftests: forwarding: bridge_mdb_max: Fix failing test with old
>     libnet
>   selftests: forwarding: bridge_mdb: Make test more robust
> 
> [...]

Here is the summary with links:
  - [net,v2,01/17] selftests: forwarding: Skip test when no interfaces are specified
    https://git.kernel.org/netdev/net/c/d72c83b1e4b4
  - [net,v2,02/17] selftests: forwarding: Switch off timeout
    https://git.kernel.org/netdev/net/c/0529883ad102
  - [net,v2,03/17] selftests: forwarding: bridge_mdb: Check iproute2 version
    https://git.kernel.org/netdev/net/c/ab2eda04e2c2
  - [net,v2,04/17] selftests: forwarding: bridge_mdb_max: Check iproute2 version
    https://git.kernel.org/netdev/net/c/6bdf3d9765f4
  - [net,v2,05/17] selftests: forwarding: Set default IPv6 traceroute utility
    https://git.kernel.org/netdev/net/c/38f7c44d6e76
  - [net,v2,06/17] selftests: forwarding: Add a helper to skip test when using veth pairs
    https://git.kernel.org/netdev/net/c/66e131861ab7
  - [net,v2,07/17] selftests: forwarding: ethtool: Skip when using veth pairs
    https://git.kernel.org/netdev/net/c/60a36e21915c
  - [net,v2,08/17] selftests: forwarding: ethtool_extended_state: Skip when using veth pairs
    https://git.kernel.org/netdev/net/c/b3d9305e60d1
  - [net,v2,09/17] selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs
    https://git.kernel.org/netdev/net/c/9a711cde07c2
  - [net,v2,10/17] selftests: forwarding: ethtool_mm: Skip when MAC Merge is not supported
    https://git.kernel.org/netdev/net/c/23fb886a1ced
  - [net,v2,11/17] selftests: forwarding: tc_actions: Use ncat instead of nc
    https://git.kernel.org/netdev/net/c/5e8670610b93
  - [net,v2,12/17] selftests: forwarding: tc_flower: Relax success criterion
    https://git.kernel.org/netdev/net/c/9ee37e53e768
  - [net,v2,13/17] selftests: forwarding: tc_tunnel_key: Make filters more specific
    https://git.kernel.org/netdev/net/c/11604178fdc3
  - [net,v2,14/17] selftests: forwarding: tc_flower_l2_miss: Fix failing test with old libnet
    https://git.kernel.org/netdev/net/c/21a72166abb9
  - [net,v2,15/17] selftests: forwarding: bridge_mdb: Fix failing test with old libnet
    https://git.kernel.org/netdev/net/c/e98e195d90cc
  - [net,v2,16/17] selftests: forwarding: bridge_mdb_max: Fix failing test with old libnet
    https://git.kernel.org/netdev/net/c/cb034948ac29
  - [net,v2,17/17] selftests: forwarding: bridge_mdb: Make test more robust
    https://git.kernel.org/netdev/net/c/8b5ff3709777

You are awesome, thank you!