mbox series

[net-next,0/8] virtio-net: support dynamic notification coalescing moderation

Message ID 20230811065512.22190-1-hengqi@linux.alibaba.com (mailing list archive)
Headers show
Series virtio-net: support dynamic notification coalescing moderation | expand

Message

Heng Qi Aug. 11, 2023, 6:55 a.m. UTC
Now, virtio-net already supports per-queue notification coalescing parameter
setting. Based on this, we use the netdim library[1] of linux to support
dynamic notification coalescing moderation for virtio-net.

[1] https://docs.kernel.org/networking/net_dim.html

This series also introduces some extractions and fixes. Please review.

Heng Qi (8):
  virtio-net: initially change the value of tx-frames
  virtio-net: fix mismatch of getting txq tx-frames param
  virtio-net: returns whether napi is complete
  virtio-net: separate rx/tx coalescing moderation cmds
  virtio-net: extract virtqueue coalescig cmd for reuse
  virtio-net: support rx netdim
  virtio-net: support tx netdim
  virtio-net: a tiny comment update

 drivers/net/virtio_net.c | 370 +++++++++++++++++++++++++++++++++------
 1 file changed, 316 insertions(+), 54 deletions(-)

Comments

Jason Wang Aug. 14, 2023, 4:38 a.m. UTC | #1
On Fri, Aug 11, 2023 at 2:55 PM Heng Qi <hengqi@linux.alibaba.com> wrote:
>
> Now, virtio-net already supports per-queue notification coalescing parameter
> setting. Based on this, we use the netdim library[1] of linux to support
> dynamic notification coalescing moderation for virtio-net.
>
> [1] https://docs.kernel.org/networking/net_dim.html

Do you have perf numbers?

Thanks

>
> This series also introduces some extractions and fixes. Please review.
>
> Heng Qi (8):
>   virtio-net: initially change the value of tx-frames
>   virtio-net: fix mismatch of getting txq tx-frames param
>   virtio-net: returns whether napi is complete
>   virtio-net: separate rx/tx coalescing moderation cmds
>   virtio-net: extract virtqueue coalescig cmd for reuse
>   virtio-net: support rx netdim
>   virtio-net: support tx netdim
>   virtio-net: a tiny comment update
>
>  drivers/net/virtio_net.c | 370 +++++++++++++++++++++++++++++++++------
>  1 file changed, 316 insertions(+), 54 deletions(-)
>
> --
> 2.19.1.6.gb485710b
>
Heng Qi Aug. 14, 2023, 6:06 a.m. UTC | #2
在 2023/8/14 下午12:38, Jason Wang 写道:
> On Fri, Aug 11, 2023 at 2:55 PM Heng Qi <hengqi@linux.alibaba.com> wrote:
>> Now, virtio-net already supports per-queue notification coalescing parameter
>> setting. Based on this, we use the netdim library[1] of linux to support
>> dynamic notification coalescing moderation for virtio-net.
>>
>> [1] https://docs.kernel.org/networking/net_dim.html
> Do you have perf numbers?

We have only tested the control path now. The acquisition of perf 
numbers depends on the
modification of our backend, and it will take a few days. I will bring 
it in the next version!

Thanks!

>
> Thanks
>
>> This series also introduces some extractions and fixes. Please review.
>>
>> Heng Qi (8):
>>    virtio-net: initially change the value of tx-frames
>>    virtio-net: fix mismatch of getting txq tx-frames param
>>    virtio-net: returns whether napi is complete
>>    virtio-net: separate rx/tx coalescing moderation cmds
>>    virtio-net: extract virtqueue coalescig cmd for reuse
>>    virtio-net: support rx netdim
>>    virtio-net: support tx netdim
>>    virtio-net: a tiny comment update
>>
>>   drivers/net/virtio_net.c | 370 +++++++++++++++++++++++++++++++++------
>>   1 file changed, 316 insertions(+), 54 deletions(-)
>>
>> --
>> 2.19.1.6.gb485710b
>>