| Message ID | 20230913071243.930265-1-jiri@resnulli.us (mailing list archive) |
|---|---|
| Headers | show |
| Series | expose devlink instances relationships | expand |
On Wed, Sep 13, 2023 at 09:12:31AM +0200, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > Currently, the user can instantiate new SF using "devlink port add" > command. That creates an E-switch representor devlink port. > > When user activates this SF, there is an auxiliary device created and > probed for it which leads to SF devlink instance creation. > > There is 1:1 relationship between E-switch representor devlink port and > the SF auxiliary device devlink instance. > > Also, for example in mlx5, one devlink instance is created for > PCI device and one is created for an auxiliary device that represents > the uplink port. The relation between these is invisible to the user. > > Patches #1-#3 and #5 are small preparations. > > Patch #4 adds netnsid attribute for nested devlink if that in a > different namespace. > > Patch #5 is the main one in this set, introduces the relationship > tracking infrastructure later on used to track SFs, linecards and > devlink instance relationships with nested devlink instances. > > Expose the relation to the user by introducing new netlink attribute > DEVLINK_PORT_FN_ATTR_DEVLINK which contains the devlink instance related > to devlink port function. This is done by patch #8. > Patch #9 implements this in mlx5 driver. > > Patch #10 converts the linecard nested devlink handling to the newly > introduced rel infrastructure. > > Patch #11 benefits from the rel infra and introduces possiblitily to > have relation between devlink instances. > Patch #12 implements this in mlx5 driver. > > Examples: > $ devlink dev > pci/0000:08:00.0: nested_devlink auxiliary/mlx5_core.eth.0 > pci/0000:08:00.1: nested_devlink auxiliary/mlx5_core.eth.1 > auxiliary/mlx5_core.eth.1 > auxiliary/mlx5_core.eth.0 > > $ devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 106 > pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false > function: > hw_addr 00:00:00:00:00:00 state inactive opstate detached roce enable > $ devlink port function set pci/0000:08:00.0/32768 state active > $ devlink port show pci/0000:08:00.0/32768 > pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false > function: > hw_addr 00:00:00:00:00:00 state active opstate attached roce enable nested_devlink auxiliary/mlx5_core.sf.2 > > # devlink dev reload auxiliary/mlx5_core.sf.2 netns ns1 > $ devlink port show pci/0000:08:00.0/32768 > pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false > function: > hw_addr 00:00:00:00:00:00 state active opstate attached roce enable nested_devlink auxiliary/mlx5_core.sf.2 nested_devlink_netns ns1 > > Jiri Pirko (12): > devlink: move linecard struct into linecard.c > net/mlx5: Disable eswitch as the first thing in mlx5_unload() > net/mlx5: Lift reload limitation when SFs are present > devlink: put netnsid to nested handle > devlink: move devlink_nl_put_nested_handle() into netlink.c > devlink: extend devlink_nl_put_nested_handle() with attrtype arg > devlink: introduce object and nested devlink relationship infra > devlink: expose peer SF devlink instance > net/mlx5: SF, Implement peer devlink set for SF representor devlink > port > devlink: convert linecard nested devlink to new rel infrastructure > devlink: introduce possibility to expose info about nested devlinks > net/mlx5e: Set en auxiliary devlink instance as nested Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 13 Sep 2023 09:12:31 +0200 you wrote: > From: Jiri Pirko <jiri@nvidia.com> > > Currently, the user can instantiate new SF using "devlink port add" > command. That creates an E-switch representor devlink port. > > When user activates this SF, there is an auxiliary device created and > probed for it which leads to SF devlink instance creation. > > [...] Here is the summary with links: - [net-next,v2,01/12] devlink: move linecard struct into linecard.c https://git.kernel.org/netdev/net-next/c/d0b7e990f760 - [net-next,v2,02/12] net/mlx5: Disable eswitch as the first thing in mlx5_unload() https://git.kernel.org/netdev/net-next/c/85b47dc40bbc - [net-next,v2,03/12] net/mlx5: Lift reload limitation when SFs are present https://git.kernel.org/netdev/net-next/c/602d61e307ac - [net-next,v2,04/12] devlink: put netnsid to nested handle https://git.kernel.org/netdev/net-next/c/ad99637ac92d - [net-next,v2,05/12] devlink: move devlink_nl_put_nested_handle() into netlink.c https://git.kernel.org/netdev/net-next/c/af1f1400af02 - [net-next,v2,06/12] devlink: extend devlink_nl_put_nested_handle() with attrtype arg https://git.kernel.org/netdev/net-next/c/1c2197c47a93 - [net-next,v2,07/12] devlink: introduce object and nested devlink relationship infra https://git.kernel.org/netdev/net-next/c/c137743bce02 - [net-next,v2,08/12] devlink: expose peer SF devlink instance https://git.kernel.org/netdev/net-next/c/0b7a2721e36c - [net-next,v2,09/12] net/mlx5: SF, Implement peer devlink set for SF representor devlink port https://git.kernel.org/netdev/net-next/c/ac5f395685bd - [net-next,v2,10/12] devlink: convert linecard nested devlink to new rel infrastructure https://git.kernel.org/netdev/net-next/c/9473bc0119e7 - [net-next,v2,11/12] devlink: introduce possibility to expose info about nested devlinks https://git.kernel.org/netdev/net-next/c/c5e1bf8a51cf - [net-next,v2,12/12] net/mlx5e: Set en auxiliary devlink instance as nested https://git.kernel.org/netdev/net-next/c/6c75258cc220 You are awesome, thank you!
From: Jiri Pirko <jiri@nvidia.com> Currently, the user can instantiate new SF using "devlink port add" command. That creates an E-switch representor devlink port. When user activates this SF, there is an auxiliary device created and probed for it which leads to SF devlink instance creation. There is 1:1 relationship between E-switch representor devlink port and the SF auxiliary device devlink instance. Also, for example in mlx5, one devlink instance is created for PCI device and one is created for an auxiliary device that represents the uplink port. The relation between these is invisible to the user. Patches #1-#3 and #5 are small preparations. Patch #4 adds netnsid attribute for nested devlink if that in a different namespace. Patch #5 is the main one in this set, introduces the relationship tracking infrastructure later on used to track SFs, linecards and devlink instance relationships with nested devlink instances. Expose the relation to the user by introducing new netlink attribute DEVLINK_PORT_FN_ATTR_DEVLINK which contains the devlink instance related to devlink port function. This is done by patch #8. Patch #9 implements this in mlx5 driver. Patch #10 converts the linecard nested devlink handling to the newly introduced rel infrastructure. Patch #11 benefits from the rel infra and introduces possiblitily to have relation between devlink instances. Patch #12 implements this in mlx5 driver. Examples: $ devlink dev pci/0000:08:00.0: nested_devlink auxiliary/mlx5_core.eth.0 pci/0000:08:00.1: nested_devlink auxiliary/mlx5_core.eth.1 auxiliary/mlx5_core.eth.1 auxiliary/mlx5_core.eth.0 $ devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 106 pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false function: hw_addr 00:00:00:00:00:00 state inactive opstate detached roce enable $ devlink port function set pci/0000:08:00.0/32768 state active $ devlink port show pci/0000:08:00.0/32768 pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false function: hw_addr 00:00:00:00:00:00 state active opstate attached roce enable nested_devlink auxiliary/mlx5_core.sf.2 # devlink dev reload auxiliary/mlx5_core.sf.2 netns ns1 $ devlink port show pci/0000:08:00.0/32768 pci/0000:08:00.0/32768: type eth netdev eth4 flavour pcisf controller 0 pfnum 0 sfnum 106 splittable false function: hw_addr 00:00:00:00:00:00 state active opstate attached roce enable nested_devlink auxiliary/mlx5_core.sf.2 nested_devlink_netns ns1 Jiri Pirko (12): devlink: move linecard struct into linecard.c net/mlx5: Disable eswitch as the first thing in mlx5_unload() net/mlx5: Lift reload limitation when SFs are present devlink: put netnsid to nested handle devlink: move devlink_nl_put_nested_handle() into netlink.c devlink: extend devlink_nl_put_nested_handle() with attrtype arg devlink: introduce object and nested devlink relationship infra devlink: expose peer SF devlink instance net/mlx5: SF, Implement peer devlink set for SF representor devlink port devlink: convert linecard nested devlink to new rel infrastructure devlink: introduce possibility to expose info about nested devlinks net/mlx5e: Set en auxiliary devlink instance as nested .../net/ethernet/mellanox/mlx5/core/devlink.c | 11 - .../ethernet/mellanox/mlx5/core/en/devlink.c | 8 + .../net/ethernet/mellanox/mlx5/core/main.c | 2 +- .../ethernet/mellanox/mlx5/core/sf/dev/dev.h | 6 + .../mellanox/mlx5/core/sf/dev/driver.c | 26 +++ .../ethernet/mellanox/mlx5/core/sf/devlink.c | 34 +++ .../mellanox/mlxsw/core_linecard_dev.c | 9 +- include/linux/mlx5/device.h | 1 + include/net/devlink.h | 9 +- include/uapi/linux/devlink.h | 1 + net/devlink/core.c | 217 ++++++++++++++++++ net/devlink/dev.c | 50 ++++ net/devlink/devl_internal.h | 34 +-- net/devlink/linecard.c | 80 ++++--- net/devlink/netlink.c | 26 +++ net/devlink/port.c | 55 ++++- 16 files changed, 509 insertions(+), 60 deletions(-)