mbox series

[net-next,v2,0/3] Wangxun ethtool stats

Message ID 20230921033020.853040-1-jiawenwu@trustnetic.com (mailing list archive)
Headers show
Series Wangxun ethtool stats | expand

Message

Jiawen Wu Sept. 21, 2023, 3:30 a.m. UTC 
Support to show ethtool stats for txgbe/ngbe.

v1 -> v2:
- change struct wx_stats member types
- use ethtool_sprintf()

Jiawen Wu (3):
  net: libwx: support hardware statistics
  net: txgbe: add ethtool stats support
  net: ngbe: add ethtool stats support

 .../net/ethernet/wangxun/libwx/wx_ethtool.c   | 191 ++++++++++++++++++
 .../net/ethernet/wangxun/libwx/wx_ethtool.h   |   4 +
 drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++
 drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   2 +
 drivers/net/ethernet/wangxun/libwx/wx_lib.c   |  11 +-
 drivers/net/ethernet/wangxun/libwx/wx_type.h  |  80 ++++++++
 .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c  |   3 +
 drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |   2 +
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |   2 +
 .../ethernet/wangxun/txgbe/txgbe_ethtool.c    |   3 +
 drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |   2 +
 .../net/ethernet/wangxun/txgbe/txgbe_main.c   |   2 +
 12 files changed, 416 insertions(+), 2 deletions(-)

Comments

Jacob Keller Sept. 21, 2023, 8:33 p.m. UTC | #1 
On 9/20/2023 8:30 PM, Jiawen Wu wrote:
> Support to show ethtool stats for txgbe/ngbe.
> 
> v1 -> v2:
> - change struct wx_stats member types
> - use ethtool_sprintf()
> 
> Jiawen Wu (3):
>   net: libwx: support hardware statistics
>   net: txgbe: add ethtool stats support
>   net: ngbe: add ethtool stats support
> 

I probably wouldn't have done this as 3 separate patches, but the code
looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  .../net/ethernet/wangxun/libwx/wx_ethtool.c   | 191 ++++++++++++++++++
>  .../net/ethernet/wangxun/libwx/wx_ethtool.h   |   4 +
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++
>  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   2 +
>  drivers/net/ethernet/wangxun/libwx/wx_lib.c   |  11 +-
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  80 ++++++++
>  .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c  |   3 +
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |   2 +
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |   2 +
>  .../ethernet/wangxun/txgbe/txgbe_ethtool.c    |   3 +
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |   2 +
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   |   2 +
>  12 files changed, 416 insertions(+), 2 deletions(-)
>
Jiawen Wu Sept. 26, 2023, 1:36 a.m. UTC | #2 
On Friday, September 22, 2023 4:34 AM, Jacob Keller wrote:
> On 9/20/2023 8:30 PM, Jiawen Wu wrote:
> > Support to show ethtool stats for txgbe/ngbe.
> >
> > v1 -> v2:
> > - change struct wx_stats member types
> > - use ethtool_sprintf()
> >
> > Jiawen Wu (3):
> >   net: libwx: support hardware statistics
> >   net: txgbe: add ethtool stats support
> >   net: ngbe: add ethtool stats support
> >
> 
> I probably wouldn't have done this as 3 separate patches, but the code
> looks good to me.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks for the review. May I get more comments from other reviewers? :)

> 
> >  .../net/ethernet/wangxun/libwx/wx_ethtool.c   | 191 ++++++++++++++++++
> >  .../net/ethernet/wangxun/libwx/wx_ethtool.h   |   4 +
> >  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++
> >  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   2 +
> >  drivers/net/ethernet/wangxun/libwx/wx_lib.c   |  11 +-
> >  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  80 ++++++++
> >  .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c  |   3 +
> >  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |   2 +
> >  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |   2 +
> >  .../ethernet/wangxun/txgbe/txgbe_ethtool.c    |   3 +
> >  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |   2 +
> >  .../net/ethernet/wangxun/txgbe/txgbe_main.c   |   2 +
> >  12 files changed, 416 insertions(+), 2 deletions(-)
> >
>