mbox series

[net-next,v5,0/5] dpll: add phase-offset and phase-adjust

Message ID 20231011101236.23160-1-arkadiusz.kubalewski@intel.com (mailing list archive)
Headers show
Series dpll: add phase-offset and phase-adjust | expand

Message

Kubalewski, Arkadiusz Oct. 11, 2023, 10:12 a.m. UTC
Improve monitoring and control over dpll devices.
Allow user to receive measurement of phase difference between signals
on pin and dpll (phase-offset).
Allow user to receive and control adjustable value of pin's signal
phase (phase-adjust).

v4->v5:
- rebase series on top of net-next/main, fix conflict - remove redundant
  attribute type definition in subset definition

v3->v4:
- do not increase do version of uAPI header as it is not needed (v3 did
  not have this change)
- fix spelling around commit messages, argument descriptions and docs
- add missing extack errors on failure set callbacks for pin phase
  adjust and frequency
- remove ice check if value is already set, now redundant as checked in
  the dpll subsystem

v2->v3:
- do not increase do version of uAPI header as it is not needed

v1->v2:
- improve handling for error case of requesting the phase adjust set
- align handling for error case of frequency set request with the
approach introduced for phase adjust


Arkadiusz Kubalewski (5):
  dpll: docs: add support for pin signal phase offset/adjust
  dpll: spec: add support for pin-dpll signal phase offset/adjust
  dpll: netlink/core: add support for pin-dpll signal phase
    offset/adjust
  ice: dpll: implement phase related callbacks
  dpll: netlink/core: change pin frequency set behavior

 Documentation/driver-api/dpll.rst         |  53 +++++-
 Documentation/netlink/specs/dpll.yaml     |  30 +++
 drivers/dpll/dpll_netlink.c               | 188 +++++++++++++++++-
 drivers/dpll/dpll_nl.c                    |   8 +-
 drivers/dpll/dpll_nl.h                    |   2 +-
 drivers/net/ethernet/intel/ice/ice_dpll.c | 220 +++++++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_dpll.h |  10 +-
 include/linux/dpll.h                      |  18 ++
 include/uapi/linux/dpll.h                 |   6 +
 9 files changed, 517 insertions(+), 18 deletions(-)

Comments

Jiri Pirko Oct. 11, 2023, 11:11 a.m. UTC | #1
Wed, Oct 11, 2023 at 12:12:31PM CEST, arkadiusz.kubalewski@intel.com wrote:
>Improve monitoring and control over dpll devices.
>Allow user to receive measurement of phase difference between signals
>on pin and dpll (phase-offset).
>Allow user to receive and control adjustable value of pin's signal
>phase (phase-adjust).
>
>v4->v5:
>- rebase series on top of net-next/main, fix conflict - remove redundant
>  attribute type definition in subset definition
>
>v3->v4:
>- do not increase do version of uAPI header as it is not needed (v3 did
>  not have this change)
>- fix spelling around commit messages, argument descriptions and docs
>- add missing extack errors on failure set callbacks for pin phase
>  adjust and frequency
>- remove ice check if value is already set, now redundant as checked in
>  the dpll subsystem
>
>v2->v3:
>- do not increase do version of uAPI header as it is not needed
>
>v1->v2:
>- improve handling for error case of requesting the phase adjust set
>- align handling for error case of frequency set request with the
>approach introduced for phase adjust

Again,
set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Vadim Fedorenko Oct. 13, 2023, 11:13 a.m. UTC | #2
On 11/10/2023 11:12, Arkadiusz Kubalewski wrote:
> Improve monitoring and control over dpll devices.
> Allow user to receive measurement of phase difference between signals
> on pin and dpll (phase-offset).
> Allow user to receive and control adjustable value of pin's signal
> phase (phase-adjust).
> 
> v4->v5:
> - rebase series on top of net-next/main, fix conflict - remove redundant
>    attribute type definition in subset definition
> 
> v3->v4:
> - do not increase do version of uAPI header as it is not needed (v3 did
>    not have this change)
> - fix spelling around commit messages, argument descriptions and docs
> - add missing extack errors on failure set callbacks for pin phase
>    adjust and frequency
> - remove ice check if value is already set, now redundant as checked in
>    the dpll subsystem
> 
> v2->v3:
> - do not increase do version of uAPI header as it is not needed
> 
> v1->v2:
> - improve handling for error case of requesting the phase adjust set
> - align handling for error case of frequency set request with the
> approach introduced for phase adjust
> 
> 
> Arkadiusz Kubalewski (5):
>    dpll: docs: add support for pin signal phase offset/adjust
>    dpll: spec: add support for pin-dpll signal phase offset/adjust
>    dpll: netlink/core: add support for pin-dpll signal phase
>      offset/adjust
>    ice: dpll: implement phase related callbacks
>    dpll: netlink/core: change pin frequency set behavior
> 
>   Documentation/driver-api/dpll.rst         |  53 +++++-
>   Documentation/netlink/specs/dpll.yaml     |  30 +++
>   drivers/dpll/dpll_netlink.c               | 188 +++++++++++++++++-
>   drivers/dpll/dpll_nl.c                    |   8 +-
>   drivers/dpll/dpll_nl.h                    |   2 +-
>   drivers/net/ethernet/intel/ice/ice_dpll.c | 220 +++++++++++++++++++++-
>   drivers/net/ethernet/intel/ice/ice_dpll.h |  10 +-
>   include/linux/dpll.h                      |  18 ++
>   include/uapi/linux/dpll.h                 |   6 +
>   9 files changed, 517 insertions(+), 18 deletions(-)
> 
For the series:
Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

Thanks!
patchwork-bot+netdevbpf@kernel.org Oct. 15, 2023, 3:10 p.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 11 Oct 2023 12:12:31 +0200 you wrote:
> Improve monitoring and control over dpll devices.
> Allow user to receive measurement of phase difference between signals
> on pin and dpll (phase-offset).
> Allow user to receive and control adjustable value of pin's signal
> phase (phase-adjust).
> 
> v4->v5:
> - rebase series on top of net-next/main, fix conflict - remove redundant
>   attribute type definition in subset definition
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/5] dpll: docs: add support for pin signal phase offset/adjust
    https://git.kernel.org/netdev/net-next/c/27ed30d1f861
  - [net-next,v5,2/5] dpll: spec: add support for pin-dpll signal phase offset/adjust
    https://git.kernel.org/netdev/net-next/c/c3c6ab95c397
  - [net-next,v5,3/5] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust
    https://git.kernel.org/netdev/net-next/c/d7fbc0b7e846
  - [net-next,v5,4/5] ice: dpll: implement phase related callbacks
    https://git.kernel.org/netdev/net-next/c/90e1c90750d7
  - [net-next,v5,5/5] dpll: netlink/core: change pin frequency set behavior
    https://git.kernel.org/netdev/net-next/c/20f6677234d8

You are awesome, thank you!