From patchwork Mon Oct 16 15:49:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahmed Zaki X-Patchwork-Id: 13423624 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B33F12AB58; Mon, 16 Oct 2023 15:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="j59jXpvp" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E57383; Mon, 16 Oct 2023 08:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697471395; x=1729007395; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mFIWgW4AZ8A5pXQQuNhVAhKcL5eIVVFCa+hlYjdX2SE=; b=j59jXpvplIaCsRjTwAvm4hiWt8yxniFGhWaIbHvdoTpNM688eLGFKKo3 9mpOm7TlYDvZKvUqpITQ2RTpFYxBifhqd0GuLhPCPdyXlIyzUsidoIR+z lrkWU1CyVWLi1kkR85ziUMryY1fmyDye803aTHRVbmFHxKd7zuOEa4QOk 6PpMVtrxZxP2Y6ctjPNxnusq23pi40THRlhU4YAPWLfZtGZTmdU/YxvSs EfnPJ+dcVGUkOJ0L5QkcyLcITS4XeEGEGsOrW6LROsa2FFQ8R3nZGJG3/ 84jPTRLcRa7fILVMNrGlGCjWCtLGjtSKLbB++gZhlmHFzIeiVVQctF4Bi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="385400215" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="385400215" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 08:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="749323888" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="749323888" Received: from rolfrich-mobl1.ger.corp.intel.com (HELO azaki-desk1.intel.com) ([10.249.38.44]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 08:49:49 -0700 From: Ahmed Zaki To: netdev@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org, corbet@lwn.net, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, andrew@lunn.ch, horms@kernel.org, mkubecek@suse.cz, willemdebruijn.kernel@gmail.com, linux-doc@vger.kernel.org, Ahmed Zaki Subject: [PATCH net-next v4 0/6] Support symmetric RSS (Toeplitz) hash Date: Mon, 16 Oct 2023 09:49:31 -0600 Message-Id: <20231016154937.41224-1-ahmed.zaki@intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Patch 1 adds the support at the Kernel level, allowing the user to set a symmetric RSS hash for any flow type via: # ethtool -N|-U eth0 rx-flow-hash s|d|f|n symmetric-xor Support for the new "symmetric-xor" flag will be later sent to the "ethtool" user-space tool. Patch 2 fixes a long standing bug with the register values. The bug has been benign for now since only (asymmetric) Toeplitz hash (Zero) has been used. Patches 3 and 4 lay some groundwork refactoring. While the first is mainly cosmetic, the second is needed since there is no more room in the previous 64-bit RSS profile ID for the symmetric attribute introduced in the next patch. Finally, patches 5 and 6 add the symmetric Toeplitz support for the ice (E800 PFs) and the iAVF drivers. --- v4: add a comment to "#define RXH_SYMMETRIC_XOR" (in uapi/linux/ethtool.h) v3: rename "symmetric" to "symmetric-xor" and drop "Fixes" tag in patch 2. v2: fixed a "Reviewed by" to "Reviewed-by", also need to cc maintainers. Ahmed Zaki (4): net: ethtool: allow symmetric-xor RSS hash for any flow type ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values ice: refactor the FD and RSS flow ID generation iavf: enable symmetric RSS Toeplitz hash Jeff Guo (1): ice: enable symmetric RSS Toeplitz hash for any flow type Qi Zhang (1): ice: refactor RSS configuration Documentation/networking/scaling.rst | 6 + .../net/ethernet/intel/iavf/iavf_adv_rss.c | 8 +- .../net/ethernet/intel/iavf/iavf_adv_rss.h | 3 +- .../net/ethernet/intel/iavf/iavf_ethtool.c | 22 +- drivers/net/ethernet/intel/ice/ice.h | 2 + .../net/ethernet/intel/ice/ice_adminq_cmd.h | 8 +- drivers/net/ethernet/intel/ice/ice_common.h | 1 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 14 +- .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 35 +- .../net/ethernet/intel/ice/ice_flex_pipe.c | 43 +- .../net/ethernet/intel/ice/ice_flex_pipe.h | 4 +- .../net/ethernet/intel/ice/ice_flex_type.h | 7 + drivers/net/ethernet/intel/ice/ice_flow.c | 439 +++++++++++++----- drivers/net/ethernet/intel/ice/ice_flow.h | 46 +- .../net/ethernet/intel/ice/ice_hw_autogen.h | 4 + drivers/net/ethernet/intel/ice/ice_lib.c | 117 ++--- drivers/net/ethernet/intel/ice/ice_main.c | 49 +- drivers/net/ethernet/intel/ice/ice_type.h | 1 + drivers/net/ethernet/intel/ice/ice_virtchnl.c | 55 ++- .../ethernet/intel/ice/ice_virtchnl_fdir.c | 35 +- include/linux/avf/virtchnl.h | 16 +- include/uapi/linux/ethtool.h | 21 +- net/ethtool/ioctl.c | 11 + 23 files changed, 641 insertions(+), 306 deletions(-)