| Message ID | 20231114001621.101284-1-michael.chan@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bnxt_en: TX path improvements | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 13 Nov 2023 16:16:08 -0800 you wrote: > All patches in this patchset are related to improving the TX path. > There are 2 areas of improvements: > > 1. The TX interrupt logic currently counts the number of TX completions > to determine the number of TX SKBs to free. We now change it so that > the TX completion will now contain the hardware consumer index > information. The driver will keep track of the latest hardware > consumer index from the last TX completion and clean up all TX SKBs > up to that index. This scheme aligns better with future chips and > allows xmit_more code path to be more optimized. > > [...] Here is the summary with links: - [net-next,v2,01/13] bnxt_en: Put the TX producer information in the TX BD opaque field https://git.kernel.org/netdev/net-next/c/34eec1f29a59 - [net-next,v2,02/13] bnxt_en: Add completion ring pointer in TX and RX ring structures https://git.kernel.org/netdev/net-next/c/7f0a168b0441 - [net-next,v2,03/13] bnxt_en: Restructure cp_ring_arr in struct bnxt_cp_ring_info https://git.kernel.org/netdev/net-next/c/d1eec614100c - [net-next,v2,04/13] bnxt_en: Add completion ring pointer in TX and RX ring structures https://git.kernel.org/netdev/net-next/c/7845b8dfc713 - [net-next,v2,05/13] bnxt_en: Remove BNXT_RX_HDL and BNXT_TX_HDL https://git.kernel.org/netdev/net-next/c/9c0b06de6fb6 - [net-next,v2,06/13] bnxt_en: Refactor bnxt_tx_int() https://git.kernel.org/netdev/net-next/c/ebf72319cef6 - [net-next,v2,07/13] bnxt_en: New encoding for the TX opaque field https://git.kernel.org/netdev/net-next/c/5a3c585fa83f - [net-next,v2,08/13] bnxt_en: Refactor bnxt_hwrm_set_coal() https://git.kernel.org/netdev/net-next/c/877edb347323 - [net-next,v2,09/13] bnxt_en: Support up to 8 TX rings per MSIX https://git.kernel.org/netdev/net-next/c/0589a1ed4d33 - [net-next,v2,10/13] bnxt_en: Add helper to get the number of CP rings required for TX rings https://git.kernel.org/netdev/net-next/c/f5b29c6afe36 - [net-next,v2,11/13] bnxt_en: Add macros related to TC and TX rings https://git.kernel.org/netdev/net-next/c/f07b58801bef - [net-next,v2,12/13] bnxt_en: Use existing MSIX vectors for all mqprio TX rings https://git.kernel.org/netdev/net-next/c/ba098017791e - [net-next,v2,13/13] bnxt_en: Optimize xmit_more TX path https://git.kernel.org/netdev/net-next/c/c1056a59aee1 You are awesome, thank you!
All patches in this patchset are related to improving the TX path. There are 2 areas of improvements: 1. The TX interrupt logic currently counts the number of TX completions to determine the number of TX SKBs to free. We now change it so that the TX completion will now contain the hardware consumer index information. The driver will keep track of the latest hardware consumer index from the last TX completion and clean up all TX SKBs up to that index. This scheme aligns better with future chips and allows xmit_more code path to be more optimized. 2. The current driver logic requires an additional MSIX for each additional MQPRIO TX ring. This scheme uses too many MSIX vectors if the user enables a large number of MQPRIO TCs. We now use a new scheme that will use the same MSIX for all the MQPRIO TX rings for each ethtool channel. Each ethtool TX channel can have up to 8 MQPRIO TX rings and now they all will share the same MSIX. v2: Rebased v1 posted on Oct 27 2023 right before the close of net-next: https://lore.kernel.org/netdev/20231027232252.36111-1-michael.chan@broadcom.com/ Michael Chan (13): bnxt_en: Put the TX producer information in the TX BD opaque field bnxt_en: Add completion ring pointer in TX and RX ring structures bnxt_en: Restructure cp_ring_arr in struct bnxt_cp_ring_info bnxt_en: Add completion ring pointer in TX and RX ring structures bnxt_en: Remove BNXT_RX_HDL and BNXT_TX_HDL bnxt_en: Refactor bnxt_tx_int() bnxt_en: New encoding for the TX opaque field bnxt_en: Refactor bnxt_hwrm_set_coal() bnxt_en: Support up to 8 TX rings per MSIX bnxt_en: Add helper to get the number of CP rings required for TX rings bnxt_en: Add macros related to TC and TX rings bnxt_en: Use existing MSIX vectors for all mqprio TX rings bnxt_en: Optimize xmit_more TX path drivers/net/ethernet/broadcom/bnxt/bnxt.c | 513 +++++++++++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 59 +- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 11 +- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 23 +- 4 files changed, 385 insertions(+), 221 deletions(-)