From patchwork Wed Nov 15 21:05:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13457373 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LJzD51DF" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE341FC3 for ; Wed, 15 Nov 2023 13:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700082323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TILtTIeu3gXnUdrdAENWa1V+qtf2djaxseto/GpIGiU=; b=LJzD51DFRJEUxMRRx0Ed/letfIyQuyDy/MFmupEIRIAlvbN7xX2K2SX+usOlq52yFa7LWw Hox4D0GFwc4uOT4if01DCuSbV5zv7hUMOLUSPT27IV/wYWMk17iahmNosWH2ysP9cVtIwR P9qdiF/1CPS2Rr/lUPAl+qJDAgCBpLQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-F0EMJrXzPk-lvIhyom_TEw-1; Wed, 15 Nov 2023 16:05:19 -0500 X-MC-Unique: F0EMJrXzPk-lvIhyom_TEw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0074382A62C; Wed, 15 Nov 2023 21:05:19 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.22.34.128]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 232ED3D6; Wed, 15 Nov 2023 21:05:18 +0000 (UTC) From: Valentin Schneider To: dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Juri Lelli , Tomas Glozar , Sebastian Andrzej Siewior , Thomas Gleixner Subject: [PATCH v2 0/2] tcp/dcpp: tw_timer tweaks for nohz_full and PREEMPT_RT Date: Wed, 15 Nov 2023 16:05:07 -0500 Message-ID: <20231115210509.481514-1-vschneid@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Hi, This is v2 of [1] where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups. Patch 1 is pretty much the same as v1, just got an extra comment in inet_twsk_deschedule_put() to highlight the race. Patch 2 was added as AFAICT the bh_disable is no longer needed after patch 1, and Sebastian mentioned during LPC the he had been looking at getting rid of it for removing softirq_ctrl.lock in PREEMPT_RT. Eric mentionned rsk_timer needs looking into, but I haven't had the time to do that. It doesn't show up in our testing, which might be due to its relatively low timeout (IIUC 3s). [1]: https://lore.kernel.org/all/20231016125934.1970789-1-vschneid@redhat.com/ Valentin Schneider (2): tcp/dcpp: Un-pin tw_timer tcp/dcpp: Don't disable bh around timewait_sock initialization net/dccp/minisocks.c | 14 ++++---------- net/ipv4/inet_timewait_sock.c | 20 +++++++++++++++----- net/ipv4/tcp_minisocks.c | 14 ++++---------- 3 files changed, 23 insertions(+), 25 deletions(-) --- 2.41.0