mbox series

[net-next,v5,0/4] skbuff: Optimize SKB coalescing for page pool

Message ID 20231129112304.67836-1-liangchen.linux@gmail.com (mailing list archive)
Headers show
Series skbuff: Optimize SKB coalescing for page pool | expand

Message

Liang Chen Nov. 29, 2023, 11:23 a.m. UTC
The combination of the following condition was excluded from skb coalescing:

from->pp_recycle = 1
from->cloned = 1
to->pp_recycle = 1

With page pool in use, this combination can be quite common(ex.
NetworkMananger may lead to the additional packet_type being registered,
thus the cloning). In scenarios with a higher number of small packets, it
can significantly affect the success rate of coalescing.

This patchset aims to optimize this scenario and enable coalescing of this
particular combination. That also involves supporting multiple users
referencing the same fragment of a pp page to accomondate the need to
increment the "from" SKB page's pp page reference count.

Changes from v4:
- remove 'inline'
- rename skb_pp_get_frag_ref to skb_pp_frag_ref
- use page_ref_inc instead of get_page
- add helper to increase pp_ref_count in page_pool/helpers.h


Liang Chen (4):
  page_pool: Rename pp_frag_count to pp_ref_count
  page_pool: halve BIAS_MAX for multiple user references of a fragment
  skbuff: Add a function to check if a page belongs to page_pool
  skbuff: Optimization of SKB coalescing for page pool

 .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  4 +-
 include/linux/mm_types.h                      |  2 +-
 include/net/page_pool/helpers.h               | 50 +++++++++++--------
 include/net/page_pool/types.h                 |  2 +-
 net/core/page_pool.c                          | 14 +++---
 net/core/skbuff.c                             | 48 +++++++++++++-----
 6 files changed, 76 insertions(+), 44 deletions(-)