| Message ID | 20231201000519.13363-1-shannon.nelson@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ionic: small driver fixes | expand |
On 11/30/2023 4:05 PM, Shannon Nelson wrote: > This is a collection of small fixes for the ionic driver, > mostly code cleanup items. > > Brett Creeley (5): > ionic: Use cached VF attributes > ionic: Don't check null when calling vfree() > ionic: Make the check for Tx HW timestamping more obvious > ionic: Fix dim work handling in split interrupt mode > ionic: Re-arrange ionic_intr_info struct for cache perf > > Shannon Nelson (2): > ionic: fix snprintf format length warning > ionic: set ionic ptr before setting up ethtool ops FWIW, for the whole series: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Clear and concise commit messages, nice!
On 11/30/2023 8:19 PM, Florian Fainelli wrote: > > On 11/30/2023 4:05 PM, Shannon Nelson wrote: >> This is a collection of small fixes for the ionic driver, >> mostly code cleanup items. >> >> Brett Creeley (5): >> ionic: Use cached VF attributes >> ionic: Don't check null when calling vfree() >> ionic: Make the check for Tx HW timestamping more obvious >> ionic: Fix dim work handling in split interrupt mode >> ionic: Re-arrange ionic_intr_info struct for cache perf >> >> Shannon Nelson (2): >> ionic: fix snprintf format length warning >> ionic: set ionic ptr before setting up ethtool ops > > FWIW, for the whole series: > > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> > > Clear and concise commit messages, nice! Thanks, Florian sln > -- > Florian
On Thu, 30 Nov 2023 16:05:12 -0800 Shannon Nelson wrote: > This is a collection of small fixes for the ionic driver, > mostly code cleanup items. Hm, looks cleanup-y indeed. Majority of this looks like net-next material, really. 1 - fine for net 2 - perf optimization, we generally follow stable rules, which say: Serious issues as reported by a user of a distribution kernel may also be considered if they fix a notable performance or interactivity issue. As these fixes are not as obvious and have a higher risk of a subtle regression they should only be submitted by a distribution kernel maintainer and include an addendum linking to a bugzilla entry if it exists and additional information on the user-visible impact. I doubt serious "user-visible impact" will be the case here, however. 3 - I don't see how this matters, netdev is not registered, locks are not initialized, who's going to access that pointer? 4 - cleanup / nop 5 - cleanup / nop 6 - fine for net 7 - optimization and a minor one at that I appreciate the diligent Fixes tags but I'm afraid we need to be a bit more judicious in what we consider a fix.
On 12/1/2023 5:42 PM, Jakub Kicinski wrote: > > On Thu, 30 Nov 2023 16:05:12 -0800 Shannon Nelson wrote: >> This is a collection of small fixes for the ionic driver, >> mostly code cleanup items. > > Hm, looks cleanup-y indeed. Majority of this looks like net-next > material, really. > > 1 - fine for net > 2 - perf optimization, we generally follow stable rules, which say: > > Serious issues as reported by a user of a distribution kernel may > also be considered if they fix a notable performance or > interactivity issue. As these fixes are not as obvious and have a > higher risk of a subtle regression they should only be submitted by > a distribution kernel maintainer and include an addendum linking to > a bugzilla entry if it exists and additional information on the > user-visible impact. > > I doubt serious "user-visible impact" will be the case here, however. > > 3 - I don't see how this matters, netdev is not registered, locks are > not initialized, who's going to access that pointer? > 4 - cleanup / nop > 5 - cleanup / nop > 6 - fine for net > 7 - optimization and a minor one at that > > I appreciate the diligent Fixes tags but I'm afraid we need to be a bit > more judicious in what we consider a fix. Okay, you would prefer most of these as net-next, and you like the Fixes tags, but normally if there are Fixes tags they should be in net. So, do you want the Fixes tags removed when these patches are sent to net-next? sln > -- > pw-bot: cr
On Mon, 4 Dec 2023 10:23:40 -0800 Nelson, Shannon wrote: > Okay, you would prefer most of these as net-next, and you like the Fixes > tags, but normally if there are Fixes tags they should be in net. So, > do you want the Fixes tags removed when these patches are sent to net-next? Yes, that's right. What goes to net-next should have Fixes tag stripped. If you want to preserve the reference for your own needs, you can say something like: This code was introduced in commit ... Just not a bona fide Fixes tag, please.