[net-next,0/4] net: dsa: mv88e6xxx: Add "eth-mac" and "rmon" counter group support

Message

Tobias Waldekranz Dec. 1, 2023, 12:58 p.m. UTC

The majority of the changes (1/4) are about refactoring the existing
ethtool statistics support to make it possible to read individual
counters, rather than the whole set.

2/4 tries to collect all information about a stat in a single place
using a mapper macro, which is then used to generate the original list
of stats, along with a matching enum. checkpatch is less than amused
with this construct, but prior art exists (__BPF_FUNC_MAPPER in
include/uapi/linux/bpf.h, for example). Is there a better way forward?

With that in place, adding the actual counter groups is pretty
straight forward (3-4/4).

Tobias Waldekranz (4):
  net: dsa: mv88e6xxx: Create API to read a single stat counter
  net: dsa: mv88e6xxx: Give each hw stat an ID
  net: dsa: mv88e6xxx: Add "eth-mac" counter group support
  net: dsa: mv88e6xxx: Add "rmon" counter group support

 drivers/net/dsa/mv88e6xxx/chip.c | 405 +++++++++++++++++++++----------
 drivers/net/dsa/mv88e6xxx/chip.h |  27 ++-
 2 files changed, 288 insertions(+), 144 deletions(-)

Comments

Vladimir Oltean Dec. 4, 2023, 4:48 p.m. UTC | #1

On Fri, Dec 01, 2023 at 01:58:08PM +0100, Tobias Waldekranz wrote:
> 2/4 tries to collect all information about a stat in a single place
> using a mapper macro, which is then used to generate the original list
> of stats, along with a matching enum. checkpatch is less than amused
> with this construct, but prior art exists (__BPF_FUNC_MAPPER in
> include/uapi/linux/bpf.h, for example). Is there a better way forward?

Take checkpatch with salt?