mbox series

[bpf-next,v8,00/18] XDP metadata via kfuncs for ice + VLAN hint

Message ID 20231205210847.28460-1-larysa.zaremba@intel.com (mailing list archive)
Headers show
Series XDP metadata via kfuncs for ice + VLAN hint | expand

Message

Larysa Zaremba Dec. 5, 2023, 9:08 p.m. UTC 
This series introduces XDP hints via kfuncs [0] to the ice driver.

Series brings the following existing hints to the ice driver:
 - HW timestamp
 - RX hash with type

Series also introduces VLAN tag with protocol XDP hint, it now be accessed by
XDP and userspace (AF_XDP) programs. They can also be checked with xdp_metadata
test and xdp_hw_metadata program.

Impact of these patches on ice performance:
ZC:
* Full hints implementation decreases pps in ZC mode by less than 3%
  (64B, rxdrop)

skb (packets with invalid IP, dropped by stack):
* Overall, patchset improves peak performance in skb mode by about 0.5%

[0] https://patchwork.kernel.org/project/netdevbpf/cover/20230119221536.3349901-1-sdf@google.com/

v7:
https://lore.kernel.org/bpf/20231115175301.534113-1-larysa.zaremba@intel.com/
v6:
https://lore.kernel.org/bpf/20231012170524.21085-1-larysa.zaremba@intel.com/
Intermediate RFC v2:
https://lore.kernel.org/bpf/20230927075124.23941-1-larysa.zaremba@intel.com/
Intermediate RFC v1:
https://lore.kernel.org/bpf/20230824192703.712881-1-larysa.zaremba@intel.com/
v5:
https://lore.kernel.org/bpf/20230811161509.19722-1-larysa.zaremba@intel.com/
v4:
https://lore.kernel.org/bpf/20230728173923.1318596-1-larysa.zaremba@intel.com/
v3:
https://lore.kernel.org/bpf/20230719183734.21681-1-larysa.zaremba@intel.com/
v2:
https://lore.kernel.org/bpf/20230703181226.19380-1-larysa.zaremba@intel.com/
v1:
https://lore.kernel.org/all/20230512152607.992209-1-larysa.zaremba@intel.com/

Changes since v7:
* shorten timestamp assignment in ice
* change first argument of ice_fill_rx_descs back to xsk_buff_pool
* fix kernel-doc for ice_run_xdp_zc
* add missing XSK_CHECK_PRIV_TYPE() in ice
* resolved selftests merge conflicts with TX hints
* AF_INET patch adds new packet generation, not replaces AF_XDP one
* fix destination port in xdp_metadata

Changes since v6:
* add ability to fill cb of all xdp_buffs in xsk_buff_pool
* place just pointer to packet context in ice_xdp_buff
* add const qualifiers in veth implementation
* generate uapi for VLAN hint

Changes since v5:
* drop checksum hint from the patchset entirely
* Alex's patch that lifts the data_meta size limitation is no longer
  required in this patchset, so will be sent separately
* new patch: hide some ice hints code behind a static key
* fix several bugs in ZC mode (ice)
* change argument order in VLAN hint kfunc (tci, proto -> proto, tci)
* cosmetic changes
* analyze performance impact

Changes since v4:
* Drop the concept of partial checksum from the hint design
* Drop the concept of checksum level from the hint design

Changes since v3:
* use XDP_CHECKSUM_VALID_LVL0 + csum_level instead of csum_level + 1
* fix spelling mistakes
* read XDP timestamp unconditionally
* add TO_STR() macro

Changes since v2:
* redesign checksum hint, so now it gives full status
* rename vlan_tag -> vlan_tci, where applicable
* use open_netns() and close_netns() in xdp_metadata
* improve VLAN hint documentation
* replace CFI with DEI
* use VLAN_VID_MASK in xdp_metadata
* make vlan_get_tag() return -ENODATA
* remove unused rx_ptype in ice_xsk.c
* fix ice timestamp code division between patches

Changes since v1:
* directly return RX hash, RX timestamp and RX checksum status
  in skb-common functions
* use intermediate enum value for checksum status in ice
* get rid of ring structure dependency in ice kfunc implementation
* make variables const, when possible, in ice implementation
* use -ENODATA instead of -EOPNOTSUPP for driver implementation
* instead of having 2 separate functions for c-tag and s-tag,
  use 1 function that outputs both VLAN tag and protocol ID
* improve documentation for introduced hints
* update xdp_metadata selftest to test new hints
* implement new hints in veth, so they can be tested in xdp_metadata
* parse VLAN tag in xdp_hw_metadata

Larysa Zaremba (17):
  ice: make RX hash reading code more reusable
  ice: make RX HW timestamp reading code more reusable
  ice: Make ptype internal to descriptor info processing
  ice: Introduce ice_xdp_buff
  ice: Support HW timestamp hint
  ice: Support RX hash XDP hint
  ice: Support XDP hints in AF_XDP ZC mode
  xdp: Add VLAN tag hint
  ice: Implement VLAN tag hint
  ice: use VLAN proto from ring packet context in skb path
  veth: Implement VLAN tag XDP hint
  net: make vlan_get_tag() return -ENODATA instead of -EINVAL
  mlx5: implement VLAN tag XDP hint
  selftests/bpf: Allow VLAN packets in xdp_hw_metadata
  selftests/bpf: Add flags and VLAN hint to xdp_hw_metadata
  selftests/bpf: Add AF_INET packet generation to xdp_metadata
  selftests/bpf: Check VLAN tag and proto in xdp_metadata

Maciej Fijalkowski (1):
  xsk: add functions to fill control buffer

 Documentation/netlink/specs/netdev.yaml       |   4 +
 Documentation/networking/xdp-rx-metadata.rst  |   8 +-
 drivers/net/ethernet/intel/ice/ice.h          |   2 +
 drivers/net/ethernet/intel/ice/ice_base.c     |  15 +
 .../net/ethernet/intel/ice/ice_lan_tx_rx.h    | 412 +++++++++---------
 drivers/net/ethernet/intel/ice/ice_main.c     |  21 +
 drivers/net/ethernet/intel/ice/ice_ptp.c      |  22 +-
 drivers/net/ethernet/intel/ice/ice_ptp.h      |  16 +-
 drivers/net/ethernet/intel/ice/ice_txrx.c     |  19 +-
 drivers/net/ethernet/intel/ice/ice_txrx.h     |  32 +-
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 207 ++++++++-
 drivers/net/ethernet/intel/ice/ice_txrx_lib.h |  18 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c      |  17 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  15 +
 drivers/net/veth.c                            |  19 +
 include/linux/if_vlan.h                       |   4 +-
 include/linux/mlx5/device.h                   |   2 +-
 include/net/xdp.h                             |   9 +
 include/net/xdp_sock_drv.h                    |  17 +
 include/net/xsk_buff_pool.h                   |   2 +
 include/uapi/linux/netdev.h                   |   3 +
 net/core/xdp.c                                |  33 ++
 net/xdp/xsk_buff_pool.c                       |  12 +
 tools/include/uapi/linux/netdev.h             |   3 +
 tools/net/ynl/generated/netdev-user.c         |   1 +
 .../selftests/bpf/prog_tests/xdp_metadata.c   | 134 +++++-
 .../selftests/bpf/progs/xdp_hw_metadata.c     |  38 +-
 .../selftests/bpf/progs/xdp_metadata.c        |   5 +
 tools/testing/selftests/bpf/testing_helpers.h |   3 +
 tools/testing/selftests/bpf/xdp_hw_metadata.c |  34 +-
 tools/testing/selftests/bpf/xdp_metadata.h    |  34 +-
 31 files changed, 851 insertions(+), 310 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 14, 2023, 12:30 a.m. UTC | #1 
Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Tue,  5 Dec 2023 22:08:29 +0100 you wrote:
> This series introduces XDP hints via kfuncs [0] to the ice driver.
> 
> Series brings the following existing hints to the ice driver:
>  - HW timestamp
>  - RX hash with type
> 
> Series also introduces VLAN tag with protocol XDP hint, it now be accessed by
> XDP and userspace (AF_XDP) programs. They can also be checked with xdp_metadata
> test and xdp_hw_metadata program.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v8,01/18] ice: make RX hash reading code more reusable
    https://git.kernel.org/bpf/bpf-next/c/9244384e811e
  - [bpf-next,v8,02/18] ice: make RX HW timestamp reading code more reusable
    https://git.kernel.org/bpf/bpf-next/c/3310aad20def
  - [bpf-next,v8,03/18] ice: Make ptype internal to descriptor info processing
    https://git.kernel.org/bpf/bpf-next/c/6b62a4214903
  - [bpf-next,v8,04/18] ice: Introduce ice_xdp_buff
    https://git.kernel.org/bpf/bpf-next/c/d951c14ad237
  - [bpf-next,v8,05/18] ice: Support HW timestamp hint
    https://git.kernel.org/bpf/bpf-next/c/9031d5f491b9
  - [bpf-next,v8,06/18] ice: Support RX hash XDP hint
    https://git.kernel.org/bpf/bpf-next/c/0e6a7b095970
  - [bpf-next,v8,07/18] xsk: add functions to fill control buffer
    https://git.kernel.org/bpf/bpf-next/c/b4e352ff1169
  - [bpf-next,v8,08/18] ice: Support XDP hints in AF_XDP ZC mode
    https://git.kernel.org/bpf/bpf-next/c/d68d707dcbbf
  - [bpf-next,v8,09/18] xdp: Add VLAN tag hint
    https://git.kernel.org/bpf/bpf-next/c/e6795330f88b
  - [bpf-next,v8,10/18] ice: Implement VLAN tag hint
    https://git.kernel.org/bpf/bpf-next/c/714ed949c6f3
  - [bpf-next,v8,11/18] ice: use VLAN proto from ring packet context in skb path
    https://git.kernel.org/bpf/bpf-next/c/b591137c4ec3
  - [bpf-next,v8,12/18] veth: Implement VLAN tag XDP hint
    https://git.kernel.org/bpf/bpf-next/c/fca783799f64
  - [bpf-next,v8,13/18] net: make vlan_get_tag() return -ENODATA instead of -EINVAL
    https://git.kernel.org/bpf/bpf-next/c/537fec0733c4
  - [bpf-next,v8,14/18] mlx5: implement VLAN tag XDP hint
    https://git.kernel.org/bpf/bpf-next/c/7978bad4b6b9
  - [bpf-next,v8,15/18] selftests/bpf: Allow VLAN packets in xdp_hw_metadata
    https://git.kernel.org/bpf/bpf-next/c/e71a9fa7fdb2
  - [bpf-next,v8,16/18] selftests/bpf: Add flags and VLAN hint to xdp_hw_metadata
    https://git.kernel.org/bpf/bpf-next/c/8e68a4beba94
  - [bpf-next,v8,17/18] selftests/bpf: Add AF_INET packet generation to xdp_metadata
    https://git.kernel.org/bpf/bpf-next/c/a3850af4ea25
  - [bpf-next,v8,18/18] selftests/bpf: Check VLAN tag and proto in xdp_metadata
    https://git.kernel.org/bpf/bpf-next/c/4c6612f6100c

You are awesome, thank you!