mbox series

[V3,0/3] qca_spi: collection of major fixes

Message ID 20231206141222.52029-1-wahrenst@gmx.net (mailing list archive)
Headers show
Series qca_spi: collection of major fixes | expand

Message

Stefan Wahren Dec. 6, 2023, 2:12 p.m. UTC 
This series contains a collection of major fixes for the qca_spi driver,
which has been recently discovered.

Changes in V3:
- Avoid race condition in qcaspi_set_ringparam() as reported by Jakub and
  move all traffic handling within qcaspi_spi_thread
- use netif_tx_disable instead of netif_stop_queue

Changes in V2:
- Address the crashes caused by TX ring changes in a single patch
  instead of two separate ones ( resource allocation rework will
  be send in a separate series ). As suggested by Paolo the kthread
  is parked during ring parameter changes instead changing the device
  state
- As suggested by Paolo keep the ethtool get_ringparam behavior
  and just fix set_ringparam
- improve commit message in patch #2

Stefan Wahren (3):
  qca_debug: Prevent crash on TX ring changes
  qca_debug: Fix ethtool -G iface tx behavior
  qca_spi: Fix reset behavior

 drivers/net/ethernet/qualcomm/qca_debug.c | 17 +++++++++--------
 drivers/net/ethernet/qualcomm/qca_spi.c   | 20 +++++++++++++++++++-
 2 files changed, 28 insertions(+), 9 deletions(-)

--
2.34.1

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 9, 2023, 12:20 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  6 Dec 2023 15:12:19 +0100 you wrote:
> This series contains a collection of major fixes for the qca_spi driver,
> which has been recently discovered.
> 
> Changes in V3:
> - Avoid race condition in qcaspi_set_ringparam() as reported by Jakub and
>   move all traffic handling within qcaspi_spi_thread
> - use netif_tx_disable instead of netif_stop_queue
> 
> [...]

Here is the summary with links:
  - [V3,1/3] qca_debug: Prevent crash on TX ring changes
    https://git.kernel.org/netdev/net/c/f4e6064c97c0
  - [V3,2/3] qca_debug: Fix ethtool -G iface tx behavior
    https://git.kernel.org/netdev/net/c/96a7e861d9e0
  - [V3,3/3] qca_spi: Fix reset behavior
    https://git.kernel.org/netdev/net/c/1057812d146d

You are awesome, thank you!