mbox series

[net-next,v2,0/2] net/sched: optimizations around action binding and init

Message ID 20231211181807.96028-1-pctammela@mojatatu.com (mailing list archive)
Headers show
Series net/sched: optimizations around action binding and init | expand

Message

Pedro Tammela Dec. 11, 2023, 6:18 p.m. UTC 
Scaling optimizations for action binding in rtnl-less filters.
We saw a noticeable lock contention around idrinfo->lock when
testing in a 56 core system, which disappeared after the patches.

v1->v2:
- Address comments from Vlad

Pedro Tammela (2):
  net/sched: act_api: rely on rcu in tcf_idr_check_alloc
  net/sched: act_api: skip idr replace on bound actions

 include/net/act_api.h |  2 +-
 net/sched/act_api.c   | 76 ++++++++++++++++++++++++++++---------------
 net/sched/cls_api.c   |  2 +-
 3 files changed, 51 insertions(+), 29 deletions(-)

Comments

Jamal Hadi Salim Dec. 12, 2023, 3:59 p.m. UTC | #1 
On Mon, Dec 11, 2023 at 1:18 PM Pedro Tammela <pctammela@mojatatu.com> wrote:
>
> Scaling optimizations for action binding in rtnl-less filters.
> We saw a noticeable lock contention around idrinfo->lock when
> testing in a 56 core system, which disappeared after the patches.
>
> v1->v2:
> - Address comments from Vlad
>

For the series:
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> Pedro Tammela (2):
>   net/sched: act_api: rely on rcu in tcf_idr_check_alloc
>   net/sched: act_api: skip idr replace on bound actions
>
>  include/net/act_api.h |  2 +-
>  net/sched/act_api.c   | 76 ++++++++++++++++++++++++++++---------------
>  net/sched/cls_api.c   |  2 +-
>  3 files changed, 51 insertions(+), 29 deletions(-)
Vlad Buslov Dec. 12, 2023, 5:34 p.m. UTC | #2 
On Mon 11 Dec 2023 at 15:18, Pedro Tammela <pctammela@mojatatu.com> wrote:
> Scaling optimizations for action binding in rtnl-less filters.
> We saw a noticeable lock contention around idrinfo->lock when
> testing in a 56 core system, which disappeared after the patches.
>
> v1->v2:
> - Address comments from Vlad
>
> Pedro Tammela (2):
>   net/sched: act_api: rely on rcu in tcf_idr_check_alloc
>   net/sched: act_api: skip idr replace on bound actions

Reviewed-by: Vlad Buslov <vladbu@nvidia.com>

[...]
patchwork-bot+netdevbpf@kernel.org Dec. 14, 2023, 2 a.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 11 Dec 2023 15:18:05 -0300 you wrote:
> Scaling optimizations for action binding in rtnl-less filters.
> We saw a noticeable lock contention around idrinfo->lock when
> testing in a 56 core system, which disappeared after the patches.
> 
> v1->v2:
> - Address comments from Vlad
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] net/sched: act_api: rely on rcu in tcf_idr_check_alloc
    https://git.kernel.org/netdev/net-next/c/4b55e86736d5
  - [net-next,v2,2/2] net/sched: act_api: skip idr replace on bound actions
    https://git.kernel.org/netdev/net-next/c/1dd7f18fc0ed

You are awesome, thank you!