mbox series

[v2,bpf-next,0/5] bpf: volatile compare

Message ID 20231221033854.38397-1-alexei.starovoitov@gmail.com (mailing list archive)
Headers show
Series bpf: volatile compare | expand

Message

Alexei Starovoitov Dec. 21, 2023, 3:38 a.m. UTC 
From: Alexei Starovoitov <ast@kernel.org>

v1->v2:
Fixed issues pointed out by Daniel, added more tests, attempted to convert profiler.c,
but barrier_var() wins vs bpf_cmp(). To be investigated.
Patches 1-4 are good to go, but 5 needs more work.

Alexei Starovoitov (5):
  selftests/bpf: Attempt to build BPF programs with -Wsign-compare
  bpf: Introduce "volatile compare" macro
  selftests/bpf: Convert exceptions_assert.c to bpf_cmp
  selftests/bpf: Remove bpf_assert_eq-like macros.
  selftests/bpf: Attempt to convert profiler.c to bpf_cmp.

 tools/testing/selftests/bpf/Makefile          |   1 +
 .../testing/selftests/bpf/bpf_experimental.h  | 194 ++++--------------
 .../bpf/progs/bpf_iter_bpf_percpu_hash_map.c  |   2 +-
 .../selftests/bpf/progs/bpf_iter_task_vmas.c  |   2 +-
 .../selftests/bpf/progs/bpf_iter_tasks.c      |   2 +-
 .../selftests/bpf/progs/bpf_iter_test_kern4.c |   2 +-
 .../progs/cgroup_getset_retval_setsockopt.c   |   2 +-
 .../selftests/bpf/progs/cgrp_ls_sleepable.c   |   2 +-
 .../selftests/bpf/progs/cpumask_success.c     |   2 +-
 .../testing/selftests/bpf/progs/exceptions.c  |  20 +-
 .../selftests/bpf/progs/exceptions_assert.c   |  80 ++++----
 tools/testing/selftests/bpf/progs/iters.c     |   4 +-
 .../selftests/bpf/progs/iters_task_vma.c      |   3 +-
 .../selftests/bpf/progs/linked_funcs1.c       |   2 +-
 .../selftests/bpf/progs/linked_funcs2.c       |   2 +-
 .../testing/selftests/bpf/progs/linked_list.c |   2 +-
 .../selftests/bpf/progs/local_storage.c       |   2 +-
 tools/testing/selftests/bpf/progs/lsm.c       |   2 +-
 .../selftests/bpf/progs/normal_map_btf.c      |   2 +-
 .../selftests/bpf/progs/profiler.inc.h        |  71 ++-----
 tools/testing/selftests/bpf/progs/profiler2.c |   1 +
 tools/testing/selftests/bpf/progs/profiler3.c |   1 +
 .../selftests/bpf/progs/sockopt_inherit.c     |   2 +-
 .../selftests/bpf/progs/sockopt_multi.c       |   2 +-
 .../selftests/bpf/progs/sockopt_qos_to_cc.c   |   2 +-
 .../testing/selftests/bpf/progs/test_bpf_ma.c |   2 +-
 .../bpf/progs/test_core_reloc_kernel.c        |   2 +-
 .../bpf/progs/test_core_reloc_module.c        |   8 +-
 .../selftests/bpf/progs/test_fsverity.c       |   2 +-
 .../bpf/progs/test_skc_to_unix_sock.c         |   2 +-
 .../bpf/progs/test_xdp_do_redirect.c          |   2 +-
 31 files changed, 146 insertions(+), 279 deletions(-)

Comments

Jiri Olsa Dec. 21, 2023, 6:01 p.m. UTC | #1 
On Wed, Dec 20, 2023 at 07:38:49PM -0800, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> v1->v2:
> Fixed issues pointed out by Daniel, added more tests, attempted to convert profiler.c,
> but barrier_var() wins vs bpf_cmp(). To be investigated.
> Patches 1-4 are good to go, but 5 needs more work.
> 
> Alexei Starovoitov (5):
>   selftests/bpf: Attempt to build BPF programs with -Wsign-compare
>   bpf: Introduce "volatile compare" macro
>   selftests/bpf: Convert exceptions_assert.c to bpf_cmp
>   selftests/bpf: Remove bpf_assert_eq-like macros.
>   selftests/bpf: Attempt to convert profiler.c to bpf_cmp.

lgtm, for patches 1-4:

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> 
>  tools/testing/selftests/bpf/Makefile          |   1 +
>  .../testing/selftests/bpf/bpf_experimental.h  | 194 ++++--------------
>  .../bpf/progs/bpf_iter_bpf_percpu_hash_map.c  |   2 +-
>  .../selftests/bpf/progs/bpf_iter_task_vmas.c  |   2 +-
>  .../selftests/bpf/progs/bpf_iter_tasks.c      |   2 +-
>  .../selftests/bpf/progs/bpf_iter_test_kern4.c |   2 +-
>  .../progs/cgroup_getset_retval_setsockopt.c   |   2 +-
>  .../selftests/bpf/progs/cgrp_ls_sleepable.c   |   2 +-
>  .../selftests/bpf/progs/cpumask_success.c     |   2 +-
>  .../testing/selftests/bpf/progs/exceptions.c  |  20 +-
>  .../selftests/bpf/progs/exceptions_assert.c   |  80 ++++----
>  tools/testing/selftests/bpf/progs/iters.c     |   4 +-
>  .../selftests/bpf/progs/iters_task_vma.c      |   3 +-
>  .../selftests/bpf/progs/linked_funcs1.c       |   2 +-
>  .../selftests/bpf/progs/linked_funcs2.c       |   2 +-
>  .../testing/selftests/bpf/progs/linked_list.c |   2 +-
>  .../selftests/bpf/progs/local_storage.c       |   2 +-
>  tools/testing/selftests/bpf/progs/lsm.c       |   2 +-
>  .../selftests/bpf/progs/normal_map_btf.c      |   2 +-
>  .../selftests/bpf/progs/profiler.inc.h        |  71 ++-----
>  tools/testing/selftests/bpf/progs/profiler2.c |   1 +
>  tools/testing/selftests/bpf/progs/profiler3.c |   1 +
>  .../selftests/bpf/progs/sockopt_inherit.c     |   2 +-
>  .../selftests/bpf/progs/sockopt_multi.c       |   2 +-
>  .../selftests/bpf/progs/sockopt_qos_to_cc.c   |   2 +-
>  .../testing/selftests/bpf/progs/test_bpf_ma.c |   2 +-
>  .../bpf/progs/test_core_reloc_kernel.c        |   2 +-
>  .../bpf/progs/test_core_reloc_module.c        |   8 +-
>  .../selftests/bpf/progs/test_fsverity.c       |   2 +-
>  .../bpf/progs/test_skc_to_unix_sock.c         |   2 +-
>  .../bpf/progs/test_xdp_do_redirect.c          |   2 +-
>  31 files changed, 146 insertions(+), 279 deletions(-)
> 
> -- 
> 2.34.1
> 
>