mbox series

[net-next,0/2] net/sched: retire tc ipt action

Message ID 20231221213105.476630-1-jhs@mojatatu.com (mailing list archive)
Headers show
Series net/sched: retire tc ipt action | expand

Message

Jamal Hadi Salim Dec. 21, 2023, 9:31 p.m. UTC 
In keeping up with my status as a hero who removes code: another one bites the
dust.
The tc ipt action was intended to run all netfilter/iptables target.
Unfortunately it has not benefitted over the years from proper updates when
netfilter changes, and for that reason it has remained rudimentary.
Pinging a bunch of people that i was aware were using this indicates that
removing it wont affect them.
Retire it to reduce maintenance efforts.
So Long, ipt, and Thanks for all the Fish.

Jamal Hadi Salim (2):
  net/sched: Retire ipt action
  net/sched: Remove CONFIG_NET_ACT_IPT from default configs

 arch/loongarch/configs/loongson3_defconfig |   1 -
 arch/mips/configs/ip22_defconfig           |   1 -
 arch/mips/configs/malta_defconfig          |   1 -
 arch/mips/configs/malta_kvm_defconfig      |   1 -
 arch/mips/configs/maltaup_xpa_defconfig    |   1 -
 arch/mips/configs/rb532_defconfig          |   1 -
 arch/powerpc/configs/ppc6xx_defconfig      |   1 -
 arch/s390/configs/debug_defconfig          |   1 -
 arch/s390/configs/defconfig                |   1 -
 arch/sh/configs/titan_defconfig            |   1 -
 include/net/tc_act/tc_ipt.h                |  17 -
 include/net/tc_wrapper.h                   |   4 -
 include/uapi/linux/pkt_cls.h               |   4 +-
 include/uapi/linux/tc_act/tc_ipt.h         |  20 -
 net/sched/Makefile                         |   1 -
 net/sched/act_ipt.c                        | 464 ---------------------
 tools/testing/selftests/tc-testing/config  |   1 -
 tools/testing/selftests/tc-testing/tdc.sh  |   1 -
 18 files changed, 2 insertions(+), 520 deletions(-)
 delete mode 100644 include/net/tc_act/tc_ipt.h
 delete mode 100644 include/uapi/linux/tc_act/tc_ipt.h
 delete mode 100644 net/sched/act_ipt.c

Comments

Florian Westphal Dec. 21, 2023, 9:33 p.m. UTC | #1 
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> In keeping up with my status as a hero who removes code: another one bites the
> dust.
> The tc ipt action was intended to run all netfilter/iptables target.
> Unfortunately it has not benefitted over the years from proper updates when
> netfilter changes, and for that reason it has remained rudimentary.
> Pinging a bunch of people that i was aware were using this indicates that
> removing it wont affect them.
> Retire it to reduce maintenance efforts.
> So Long, ipt, and Thanks for all the Fish.

Thanks Jamal for following up on this!

Acked-by: Florian Westphal <fw@strlen.de>
David Ahern Dec. 22, 2023, 3:51 a.m. UTC | #2 
On 12/21/23 2:31 PM, Jamal Hadi Salim wrote:
> In keeping up with my status as a hero who removes code: another one bites the
> dust.
> The tc ipt action was intended to run all netfilter/iptables target.
> Unfortunately it has not benefitted over the years from proper updates when
> netfilter changes, and for that reason it has remained rudimentary.
> Pinging a bunch of people that i was aware were using this indicates that
> removing it wont affect them.
> Retire it to reduce maintenance efforts.
> So Long, ipt, and Thanks for all the Fish.
> 
> Jamal Hadi Salim (2):
>   net/sched: Retire ipt action
>   net/sched: Remove CONFIG_NET_ACT_IPT from default configs
> 

Acked-by: David Ahern <dsahern@kernel.org>
patchwork-bot+netdevbpf@kernel.org Jan. 2, 2024, 12:50 p.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 21 Dec 2023 16:31:02 -0500 you wrote:
> In keeping up with my status as a hero who removes code: another one bites the
> dust.
> The tc ipt action was intended to run all netfilter/iptables target.
> Unfortunately it has not benefitted over the years from proper updates when
> netfilter changes, and for that reason it has remained rudimentary.
> Pinging a bunch of people that i was aware were using this indicates that
> removing it wont affect them.
> Retire it to reduce maintenance efforts.
> So Long, ipt, and Thanks for all the Fish.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net/sched: Retire ipt action
    https://git.kernel.org/netdev/net-next/c/ba24ea129126
  - [net-next,2/2] net/sched: Remove CONFIG_NET_ACT_IPT from default configs
    https://git.kernel.org/netdev/net-next/c/6d6d80e4f6bc

You are awesome, thank you!