mbox series

[net-next,v1,0/6] virtio-net: support device stats

Message ID 20231226073103.116153-1-xuanzhuo@linux.alibaba.com (mailing list archive)
Headers show
Series virtio-net: support device stats | expand

Message

Xuan Zhuo Dec. 26, 2023, 7:30 a.m. UTC 
As the spec:

https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82

The virtio net supports to get device stats.

Please review.

Thanks.

v1:
    1. fix some definitions of the marco and the struct


Xuan Zhuo (6):
  virtio_net: introduce device stats feature and structures
  virtio_net: virtnet_send_command supports command-specific-result
  virtio_net: support device stats
  virtio_net: stats map include driver stats
  virtio_net: add the total stats field
  virtio_net: rename stat tx_timeout to timeout

 drivers/net/virtio_net.c        | 533 ++++++++++++++++++++++++++++----
 include/uapi/linux/virtio_net.h | 137 ++++++++
 2 files changed, 610 insertions(+), 60 deletions(-)

--
2.32.0.3.g01195cf9f

Comments

Xuan Zhuo Jan. 16, 2024, 5:55 a.m. UTC | #1 
On Tue, 26 Dec 2023 15:30:57 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> As the spec:
>
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> The virtio net supports to get device stats.

Hi Jason,

Any comments for this?

Thanks



>
> Please review.
>
> Thanks.
>
> v1:
>     1. fix some definitions of the marco and the struct
>
>
> Xuan Zhuo (6):
>   virtio_net: introduce device stats feature and structures
>   virtio_net: virtnet_send_command supports command-specific-result
>   virtio_net: support device stats
>   virtio_net: stats map include driver stats
>   virtio_net: add the total stats field
>   virtio_net: rename stat tx_timeout to timeout
>
>  drivers/net/virtio_net.c        | 533 ++++++++++++++++++++++++++++----
>  include/uapi/linux/virtio_net.h | 137 ++++++++
>  2 files changed, 610 insertions(+), 60 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
>
Jason Wang Jan. 30, 2024, 3:20 a.m. UTC | #2 
On Tue, Jan 16, 2024 at 1:56 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
>
> On Tue, 26 Dec 2023 15:30:57 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > As the spec:
> >
> > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
> >
> > The virtio net supports to get device stats.
>
> Hi Jason,
>
> Any comments for this?
>
> Thanks
>

I see comments from both Simon and Michael, let's try to address them
and I will review v2.

Does this sound good to you?

Thanks
Xuan Zhuo Jan. 30, 2024, 3:25 a.m. UTC | #3 
On Tue, 30 Jan 2024 11:20:10 +0800, Jason Wang <jasowang@redhat.com> wrote:
> On Tue, Jan 16, 2024 at 1:56 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> >
> > On Tue, 26 Dec 2023 15:30:57 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > As the spec:
> > >
> > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
> > >
> > > The virtio net supports to get device stats.
> >
> > Hi Jason,
> >
> > Any comments for this?
> >
> > Thanks
> >
>
> I see comments from both Simon and Michael, let's try to address them
> and I will review v2.
>
> Does this sound good to you?

OK.

Thanks.


>
> Thanks
>