| Message ID | 20240104140037.374166-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ds->user_mii_bus cleanup (part 1) | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 4 Jan 2024 16:00:27 +0200 you wrote: > There are some drivers which assign ds->user_mii_bus when they > don't really need its specific functionality, aka non-OF based > dsa_user_phy_connect(). There was some confusion regarding the > fact that yes, this is why ds->user_mii_bus really exists, so > I've started a cleanup series which aims to eliminate the usage > of ds->user_mii_bus from drivers when there is nothing to gain > from it. > > [...] Here is the summary with links: - [net-next,01/10] net: dsa: lantiq_gswip: delete irrelevant use of ds->phys_mii_mask https://git.kernel.org/netdev/net-next/c/fc74b32b4032 - [net-next,02/10] net: dsa: lantiq_gswip: use devres for internal MDIO bus, not ds->user_mii_bus https://git.kernel.org/netdev/net-next/c/cd4ba3ecced9 - [net-next,03/10] net: dsa: lantiq_gswip: ignore MDIO buses disabled in OF https://git.kernel.org/netdev/net-next/c/7a898539391d - [net-next,04/10] net: dsa: qca8k: put MDIO bus OF node on qca8k_mdio_register() failure https://git.kernel.org/netdev/net-next/c/68e1010cda79 - [net-next,05/10] net: dsa: qca8k: skip MDIO bus creation if its OF node has status = "disabled" https://git.kernel.org/netdev/net-next/c/e66bf63a7f67 - [net-next,06/10] net: dsa: qca8k: assign ds->user_mii_bus only for the non-OF case https://git.kernel.org/netdev/net-next/c/525366b81f33 - [net-next,07/10] net: dsa: qca8k: consolidate calls to a single devm_of_mdiobus_register() https://git.kernel.org/netdev/net-next/c/5c5d6b34b683 - [net-next,08/10] net: dsa: qca8k: use "dev" consistently within qca8k_mdio_register() https://git.kernel.org/netdev/net-next/c/c4a1cefdf3bc - [net-next,09/10] net: dsa: bcm_sf2: stop assigning an OF node to the ds->user_mii_bus https://git.kernel.org/netdev/net-next/c/04a4bc9dddc7 - [net-next,10/10] net: dsa: bcm_sf2: drop priv->master_mii_dn https://git.kernel.org/netdev/net-next/c/45f62ca5cc48 You are awesome, thank you!
There are some drivers which assign ds->user_mii_bus when they don't really need its specific functionality, aka non-OF based dsa_user_phy_connect(). There was some confusion regarding the fact that yes, this is why ds->user_mii_bus really exists, so I've started a cleanup series which aims to eliminate the usage of ds->user_mii_bus from drivers when there is nothing to gain from it. Today's drivers are lantiq_gswip, qca8k and bcm_sf2. The work is not done here, but a "part 2" may or may not come, depending on other priorities. All patches were only compile-tested. Vladimir Oltean (10): net: dsa: lantiq_gswip: delete irrelevant use of ds->phys_mii_mask net: dsa: lantiq_gswip: use devres for internal MDIO bus, not ds->user_mii_bus net: dsa: lantiq_gswip: ignore MDIO buses disabled in OF net: dsa: qca8k: put MDIO bus OF node on qca8k_mdio_register() failure net: dsa: qca8k: skip MDIO bus creation if its OF node has status = "disabled" net: dsa: qca8k: assign ds->user_mii_bus only for the non-OF case net: dsa: qca8k: consolidate calls to a single devm_of_mdiobus_register() net: dsa: qca8k: use "dev" consistently within qca8k_mdio_register() net: dsa: bcm_sf2: stop assigning an OF node to the ds->user_mii_bus net: dsa: bcm_sf2: drop priv->master_mii_dn drivers/net/dsa/bcm_sf2.c | 7 ++-- drivers/net/dsa/bcm_sf2.h | 1 - drivers/net/dsa/lantiq_gswip.c | 72 ++++++++++++++------------------ drivers/net/dsa/qca/qca8k-8xxx.c | 47 +++++++++++++-------- drivers/net/dsa/qca/qca8k-leds.c | 4 +- drivers/net/dsa/qca/qca8k.h | 1 + 6 files changed, 68 insertions(+), 64 deletions(-)