mbox series

[v4,net-next,0/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY

Message ID 20240108093702.13476-1-dima.fedrau@gmail.com (mailing list archive)
Headers show
Series net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY | expand

Message

Dimitri Fedrau Jan. 8, 2024, 9:36 a.m. UTC
Changes in v2:
	- used defines MDIO_CTRL1_LPOWER and MDIO_PMA_CTRL1_SPEED1000
	  in mv88q222x_config_aneg_preinit
	- use genphy_c45_loopback
	- mv88q2xxx_read_status reads speed, master or slave state when
	  autonegotiation is enabled
	- added defines for magic values in mv88q222x_get_sqi

Changes in v3:
	- mv88q2xxx_read_status includes autonegotiation case
	- add support for 100BT1 and 1000BT1 linkmode advertisement
	- use mv88q2xxx_get_sqi and mv88q2xxx_get_sqi_max, remove
	  mv88q222x_get_sqi and mv88q222x_get_sqi_max
	- fix typo: rename mv88q2xxxx_get_sqi and mv88q2xxxx_get_sqi_max to
	  mv88q2xxx_get_sqi and mv88q2xxx_get_sqi
	- add define MDIO_MMD_PCS_MV_RX_STAT for magic value 0x8230, documented
	  in latest datasheets for both PHYs

Changes in V4:
	- clean up init sequence
	- separate patch for fixing typos in upstreamed code

Dimitri Fedrau (5):
  net: phy: Add BaseT1 auto-negotiation constants
  net: phy: Support 100/1000BT1 linkmode advertisements
  net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements
  net: phy: marvell-88q2xxx: fix typos
  net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY

 drivers/net/phy/marvell-88q2xxx.c | 234 +++++++++++++++++++++++++++---
 drivers/net/phy/phy-c45.c         |   3 +-
 include/linux/marvell_phy.h       |   1 +
 include/linux/mdio.h              |   8 +
 include/uapi/linux/mdio.h         |   2 +
 5 files changed, 230 insertions(+), 18 deletions(-)

Comments

Heiner Kallweit Jan. 8, 2024, 11:18 a.m. UTC | #1
On 08.01.2024 10:36, Dimitri Fedrau wrote:
> Changes in v2:
> 	- used defines MDIO_CTRL1_LPOWER and MDIO_PMA_CTRL1_SPEED1000
> 	  in mv88q222x_config_aneg_preinit
> 	- use genphy_c45_loopback
> 	- mv88q2xxx_read_status reads speed, master or slave state when
> 	  autonegotiation is enabled
> 	- added defines for magic values in mv88q222x_get_sqi
> 
> Changes in v3:
> 	- mv88q2xxx_read_status includes autonegotiation case
> 	- add support for 100BT1 and 1000BT1 linkmode advertisement
> 	- use mv88q2xxx_get_sqi and mv88q2xxx_get_sqi_max, remove
> 	  mv88q222x_get_sqi and mv88q222x_get_sqi_max
> 	- fix typo: rename mv88q2xxxx_get_sqi and mv88q2xxxx_get_sqi_max to
> 	  mv88q2xxx_get_sqi and mv88q2xxx_get_sqi
> 	- add define MDIO_MMD_PCS_MV_RX_STAT for magic value 0x8230, documented
> 	  in latest datasheets for both PHYs
> 
> Changes in V4:
> 	- clean up init sequence
> 	- separate patch for fixing typos in upstreamed code
> 
> Dimitri Fedrau (5):
>   net: phy: Add BaseT1 auto-negotiation constants
>   net: phy: Support 100/1000BT1 linkmode advertisements
>   net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements
>   net: phy: marvell-88q2xxx: fix typos
>   net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY
> 
>  drivers/net/phy/marvell-88q2xxx.c | 234 +++++++++++++++++++++++++++---
>  drivers/net/phy/phy-c45.c         |   3 +-
>  include/linux/marvell_phy.h       |   1 +
>  include/linux/mdio.h              |   8 +
>  include/uapi/linux/mdio.h         |   2 +
>  5 files changed, 230 insertions(+), 18 deletions(-)
> 
net-next is closed. Let's see whether the maintainers still accept your series.
Otherwise you may have to resubmit once net-next opens again.
Dimitri Fedrau Jan. 8, 2024, 11:24 a.m. UTC | #2
Am Mon, Jan 08, 2024 at 12:18:30PM +0100 schrieb Heiner Kallweit:
> On 08.01.2024 10:36, Dimitri Fedrau wrote:
> > Changes in v2:
> > 	- used defines MDIO_CTRL1_LPOWER and MDIO_PMA_CTRL1_SPEED1000
> > 	  in mv88q222x_config_aneg_preinit
> > 	- use genphy_c45_loopback
> > 	- mv88q2xxx_read_status reads speed, master or slave state when
> > 	  autonegotiation is enabled
> > 	- added defines for magic values in mv88q222x_get_sqi
> > 
> > Changes in v3:
> > 	- mv88q2xxx_read_status includes autonegotiation case
> > 	- add support for 100BT1 and 1000BT1 linkmode advertisement
> > 	- use mv88q2xxx_get_sqi and mv88q2xxx_get_sqi_max, remove
> > 	  mv88q222x_get_sqi and mv88q222x_get_sqi_max
> > 	- fix typo: rename mv88q2xxxx_get_sqi and mv88q2xxxx_get_sqi_max to
> > 	  mv88q2xxx_get_sqi and mv88q2xxx_get_sqi
> > 	- add define MDIO_MMD_PCS_MV_RX_STAT for magic value 0x8230, documented
> > 	  in latest datasheets for both PHYs
> > 
> > Changes in V4:
> > 	- clean up init sequence
> > 	- separate patch for fixing typos in upstreamed code
> > 
> > Dimitri Fedrau (5):
> >   net: phy: Add BaseT1 auto-negotiation constants
> >   net: phy: Support 100/1000BT1 linkmode advertisements
> >   net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements
> >   net: phy: marvell-88q2xxx: fix typos
> >   net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY
> > 
> >  drivers/net/phy/marvell-88q2xxx.c | 234 +++++++++++++++++++++++++++---
> >  drivers/net/phy/phy-c45.c         |   3 +-
> >  include/linux/marvell_phy.h       |   1 +
> >  include/linux/mdio.h              |   8 +
> >  include/uapi/linux/mdio.h         |   2 +
> >  5 files changed, 230 insertions(+), 18 deletions(-)
> > 
> net-next is closed. Let's see whether the maintainers still accept your series.
> Otherwise you may have to resubmit once net-next opens again.
>
Hi Heiner,

thanks for the information, next time I will check if net-next is
closed.

Best regards,
Dimitri Fedrau
Heiner Kallweit Jan. 8, 2024, 11:28 a.m. UTC | #3
On 08.01.2024 12:24, Dimitri Fedrau wrote:
> Am Mon, Jan 08, 2024 at 12:18:30PM +0100 schrieb Heiner Kallweit:
>> On 08.01.2024 10:36, Dimitri Fedrau wrote:
>>> Changes in v2:
>>> 	- used defines MDIO_CTRL1_LPOWER and MDIO_PMA_CTRL1_SPEED1000
>>> 	  in mv88q222x_config_aneg_preinit
>>> 	- use genphy_c45_loopback
>>> 	- mv88q2xxx_read_status reads speed, master or slave state when
>>> 	  autonegotiation is enabled
>>> 	- added defines for magic values in mv88q222x_get_sqi
>>>
>>> Changes in v3:
>>> 	- mv88q2xxx_read_status includes autonegotiation case
>>> 	- add support for 100BT1 and 1000BT1 linkmode advertisement
>>> 	- use mv88q2xxx_get_sqi and mv88q2xxx_get_sqi_max, remove
>>> 	  mv88q222x_get_sqi and mv88q222x_get_sqi_max
>>> 	- fix typo: rename mv88q2xxxx_get_sqi and mv88q2xxxx_get_sqi_max to
>>> 	  mv88q2xxx_get_sqi and mv88q2xxx_get_sqi
>>> 	- add define MDIO_MMD_PCS_MV_RX_STAT for magic value 0x8230, documented
>>> 	  in latest datasheets for both PHYs
>>>
>>> Changes in V4:
>>> 	- clean up init sequence
>>> 	- separate patch for fixing typos in upstreamed code
>>>
>>> Dimitri Fedrau (5):
>>>   net: phy: Add BaseT1 auto-negotiation constants
>>>   net: phy: Support 100/1000BT1 linkmode advertisements
>>>   net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements
>>>   net: phy: marvell-88q2xxx: fix typos
>>>   net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY
>>>
>>>  drivers/net/phy/marvell-88q2xxx.c | 234 +++++++++++++++++++++++++++---
>>>  drivers/net/phy/phy-c45.c         |   3 +-
>>>  include/linux/marvell_phy.h       |   1 +
>>>  include/linux/mdio.h              |   8 +
>>>  include/uapi/linux/mdio.h         |   2 +
>>>  5 files changed, 230 insertions(+), 18 deletions(-)
>>>
>> net-next is closed. Let's see whether the maintainers still accept your series.
>> Otherwise you may have to resubmit once net-next opens again.
>>
> Hi Heiner,
> 
> thanks for the information, next time I will check if net-next is
> closed.
> 
https://lwn.net/Articles/727558/

> Best regards,
> Dimitri Fedrau