mbox series

[net-next,00/10] Fix MODULE_DESCRIPTION() for net (p1)

Message ID 20240108181610.2697017-1-leitao@debian.org (mailing list archive)
Headers show
Series Fix MODULE_DESCRIPTION() for net (p1) | expand

Message

Breno Leitao Jan. 8, 2024, 6:16 p.m. UTC 
There are hundreds of network modules that misses MODULE_DESCRIPTION(),
causing a warnning when compiling with W=1. Example:

	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o


I am working with Jakub to address them, and eventually get a clean W=1
build.

Breno Leitao (10):
  net: fill in MODULE_DESCRIPTION()s for 8390
  net: fill in MODULE_DESCRIPTION()s for SLIP
  net: fill in MODULE_DESCRIPTION()s for HSR
  net: fill in MODULE_DESCRIPTION()s for NFC
  net: fill in MODULE_DESCRIPTION()s for Sun RPC
  net: fill in MODULE_DESCRIPTION()s for ieee802154
  net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
  net: fill in MODULE_DESCRIPTION()s for ds26522 module
  net: fill in MODULE_DESCRIPTION()s for s2io
  net: fill in MODULE_DESCRIPTION()s for PCS Layer

 drivers/net/ethernet/8390/8390.c      | 1 +
 drivers/net/ethernet/8390/8390p.c     | 1 +
 drivers/net/ethernet/8390/apne.c      | 1 +
 drivers/net/ethernet/8390/hydra.c     | 1 +
 drivers/net/ethernet/8390/stnic.c     | 1 +
 drivers/net/ethernet/8390/zorro8390.c | 1 +
 drivers/net/ethernet/neterion/s2io.c  | 1 +
 drivers/net/pcs/pcs-mtk-lynxi.c       | 1 +
 drivers/net/slip/slhc.c               | 1 +
 drivers/net/slip/slip.c               | 1 +
 drivers/net/wan/slic_ds26522.c        | 1 +
 net/6lowpan/core.c                    | 2 +-
 net/hsr/hsr_main.c                    | 1 +
 net/ieee802154/6lowpan/core.c         | 1 +
 net/ieee802154/socket.c               | 1 +
 net/nfc/digital_core.c                | 1 +
 net/nfc/nci/core.c                    | 1 +
 net/nfc/nci/spi.c                     | 1 +
 net/sunrpc/auth_gss/auth_gss.c        | 1 +
 net/sunrpc/auth_gss/gss_krb5_mech.c   | 1 +
 net/sunrpc/sunrpc_syms.c              | 1 +
 21 files changed, 21 insertions(+), 1 deletion(-)

Comments

Paolo Abeni Jan. 9, 2024, 8:01 a.m. UTC | #1 
On Mon, 2024-01-08 at 10:16 -0800, Breno Leitao wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warnning when compiling with W=1. Example:
> 
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
> 
> 
> I am working with Jakub to address them, and eventually get a clean W=1
> build.

I'm sorry, but net-next is closed for the merge window:

https://lore.kernel.org/netdev/20240107172221.733a7a44@kernel.org/

please repost when net-next reopen in ~2 weeks.

Cheers,

Paolo
Jakub Kicinski Jan. 12, 2024, 12:14 a.m. UTC | #2 
On Mon,  8 Jan 2024 10:16:00 -0800 Breno Leitao wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warnning when compiling with W=1. Example:
> 
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
> 
> I am working with Jakub to address them, and eventually get a clean W=1
> build.

As discussed with Paolo offline I'll cherry-pick the patches which
were good from here for net. Because these warnings are generated
at linking time they _all_ pop up on _every_ build our bots do, even
if it's an incremental build touching a tiny corner of the kernel.
patchwork-bot+netdevbpf@kernel.org Jan. 12, 2024, 12:30 a.m. UTC | #3 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  8 Jan 2024 10:16:00 -0800 you wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warnning when compiling with W=1. Example:
> 
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> 	WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
> 
> [...]

Here is the summary with links:
  - [net-next,01/10] net: fill in MODULE_DESCRIPTION()s for 8390
    (no matching commit)
  - [net-next,02/10] net: fill in MODULE_DESCRIPTION()s for SLIP
    https://git.kernel.org/netdev/net/c/e1b1d282d5cc
  - [net-next,03/10] net: fill in MODULE_DESCRIPTION()s for HSR
    https://git.kernel.org/netdev/net/c/417d8c571cb4
  - [net-next,04/10] net: fill in MODULE_DESCRIPTION()s for NFC
    https://git.kernel.org/netdev/net/c/95c236cc5fc9
  - [net-next,05/10] net: fill in MODULE_DESCRIPTION()s for Sun RPC
    https://git.kernel.org/netdev/net/c/d8610e431fe5
  - [net-next,06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
    (no matching commit)
  - [net-next,07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
    (no matching commit)
  - [net-next,08/10] net: fill in MODULE_DESCRIPTION()s for ds26522 module
    https://git.kernel.org/netdev/net/c/ade98756128a
  - [net-next,09/10] net: fill in MODULE_DESCRIPTION()s for s2io
    https://git.kernel.org/netdev/net/c/c155eca07647
  - [net-next,10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer
    (no matching commit)

You are awesome, thank you!