mbox series

[00/11] net: dsa: realtek: variants to drivers, interfaces to a common module

Message ID 20240123214420.25716-1-luizluca@gmail.com (mailing list archive)
Headers show
Series net: dsa: realtek: variants to drivers, interfaces to a common module | expand

Message

Luiz Angelo Daros de Luca Jan. 23, 2024, 9:44 p.m. UTC 
The current driver consists of two interface modules (SMI and MDIO) and
two family/variant modules (RTL8365MB and RTL8366RB). The SMI and MDIO
modules serve as the platform and MDIO drivers, respectively, calling
functions from the variant modules. In this setup, one interface module
can be loaded independently of the other, but both variants must be
loaded (if not disabled at build time) for any type of interface. This
approach doesn't scale well, especially with the addition of more switch
variants (e.g., RTL8366B), leading to loaded but unused modules.
Additionally, this also seems upside down, as the specific driver code
normally depends on the more generic functions and not the other way
around.

Each variant module was converted into real drivers, serving as both a
platform driver (for switches connected using the SMI interface) and an
MDIO driver (for MDIO-connected switches). The relationship between the
variant and interface modules is reversed, with the variant module now
calling both interface functions (if not disabled at build time). While
in most devices only one interface is likely used, the interface code is
significantly smaller than a variant module, consuming fewer resources
than the previous code. With variant modules now functioning as real
drivers, compatible strings are published only in a single variant
module, preventing conflicts.

The patch series introduces a new common module for functions shared by
both variants. This module also absorbs the two previous interface
modules, as they would always be loaded anyway.

The series relocates the user MII driver from realtek-smi to rtl83xx. It
is now used by MDIO-connected switches instead of the generic DSA
driver. There's a change in how this driver locates the MDIO node. It
now only searches for a child node named "mdio".

The dsa_switch in realtek_priv->ds is now embedded in the struct. It is
always in use and avoids dynamic memory allocation.

Testing has been performed with an RTL8367S (rtl8365mb) using MDIO
interface and an RTL8366RB (rtl8366) with SMI interface.

Luiz

---

Changes:

v3-v4:
1) Changed Makefile to use ifdef instead of dynamic variable names.
2) Added comments for all exported symbols.
3) Migrated exported symbols to REALTEK_DSA namespace.
4) renamed realtek_common to rtl83xx.
5) put the mdio node just after registration and not in driver remove.
6) rtl83xx_probe now receives a struct with regmap read/write functions
   and build regmap_config dynamically.
7) pulled into a new patch the realtek_priv change from "common
   realtek-dsa module".
8) pulled into a new patch the user_mii_bus setup changes from "migrate
   user_mii_bus setup to realtek-dsa".
9) removed the revert "net: dsa: OF-ware slave_mii_bus" patch from the
   series.

v2-v3:
1) Look for the MDIO bus searching for a child node named "mdio" instead
   of the compatible string.
2) Removed the check for a phy-handle in ports. ds->user_mii_bus will
   not be used anymore.
3) Dropped comments for realtek_common_{probe,register_switch}.
4) Fixed a compile error in "net: dsa: OF-ware slave_mii_bus".
5) Used the wrapper realtek_smi_driver_register instead of
   platform_driver_register.

v1-v2:
1)  Renamed realtek_common module to realtek-dsa.
2)  Removed the warning when the MDIO node is not named "mdio."
3)  ds->user_mii_bus is only assigned if all user ports do not have a
    phy-handle.
4)  of_node_put is now back to the driver remove method.
5)  Renamed realtek_common_probe_{pre,post} to
    realtek_common_{probe,register_switch}.
6)  Added some comments for realtek_common_{probe,register_switch}.
7)  Using dev_err_probe whenever possible.
8)  Embedded priv->ds into realtek_priv, removing its dynamic
    allocation.
9)  Fixed realtek-common.h macros.
10) Save and check the return value in functions, even when it is the
    last one.
11) Added the #if expression as a comment to #else and #endif in header
    files.
12) Unregister the platform and the MDIO driver in the reverse order
    they are registered.
13) Unregister the first driver if the second one failed to register.
14) Added the revert patch for "net: dsa: OF-ware slave_mii_bus."

Luiz Angelo Daros de Luca (11):
  net: dsa: realtek: drop cleanup from realtek_ops
  net: dsa: realtek: introduce REALTEK_DSA namespace
  net: dsa: realtek: convert variants into real drivers
  net: dsa: realtek: keep variant reference in realtek_priv
  net: dsa: realtek: common rtl83xx module
  net: dsa: realtek: merge rtl83xx and interface modules into
    realtek-dsa
  net: dsa: realtek: get internal MDIO node by name
  net: dsa: realtek: clean user_mii_bus setup
  net: dsa: realtek: migrate user_mii_bus setup to realtek-dsa
  net: dsa: realtek: use the same mii bus driver for both interfaces
  net: dsa: realtek: embed dsa_switch into realtek_priv

 drivers/net/dsa/realtek/Kconfig        |  20 +-
 drivers/net/dsa/realtek/Makefile       |  13 +-
 drivers/net/dsa/realtek/realtek-mdio.c | 211 +++++--------------
 drivers/net/dsa/realtek/realtek-mdio.h |  48 +++++
 drivers/net/dsa/realtek/realtek-smi.c  | 277 +++++--------------------
 drivers/net/dsa/realtek/realtek-smi.h  |  48 +++++
 drivers/net/dsa/realtek/realtek.h      |  12 +-
 drivers/net/dsa/realtek/rtl8365mb.c    | 126 ++++++-----
 drivers/net/dsa/realtek/rtl8366-core.c |  22 +-
 drivers/net/dsa/realtek/rtl8366rb.c    | 119 ++++++-----
 drivers/net/dsa/realtek/rtl83xx.c      | 267 ++++++++++++++++++++++++
 drivers/net/dsa/realtek/rtl83xx.h      |  22 ++
 12 files changed, 667 insertions(+), 518 deletions(-)
 create mode 100644 drivers/net/dsa/realtek/realtek-mdio.h
 create mode 100644 drivers/net/dsa/realtek/realtek-smi.h
 create mode 100644 drivers/net/dsa/realtek/rtl83xx.c
 create mode 100644 drivers/net/dsa/realtek/rtl83xx.h

Comments

Luiz Angelo Daros de Luca Jan. 23, 2024, 9:55 p.m. UTC | #1 
Sorry for the mess. The cover-letter broke the subject-prefix I was
using. I'll resent using the correct prefix/version.

Regards,

Luiz
Linus Walleij Jan. 23, 2024, 10:02 p.m. UTC | #2 
On Tue, Jan 23, 2024 at 10:55 PM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> Sorry for the mess. The cover-letter broke the subject-prefix I was
> using. I'll resent using the correct prefix/version.

Why not check out the "b4" tool? It helps with this kind of
stuff.
https://lore.kernel.org/netdev/CACRpkdaXV=P7NZZpS8YC67eQ2BDvR+oMzgJcjJ+GW9vFhy+3iQ@mail.gmail.com/

It's not very magical, from v4 I would create a new branch:
b4 prep -n rtl83xx -f v6.8-rc1
b4 prep --force-version 5
b4 prep --set-prefixes net-next
b4 prep --edit cover
<insert contents of patch 0/11 cover letter>
then cherry pick the 11 patches on top of that branch
and next time you b4 send it, it will pop out as v5.

OK I know it's a bit of threshold but the b4 threshold is
really low.

Yours,
Linus Walleij
Luiz Angelo Daros de Luca Jan. 23, 2024, 10:30 p.m. UTC | #3 
> Why not check out the "b4" tool? It helps with this kind of
> stuff.
> https://lore.kernel.org/netdev/CACRpkdaXV=P7NZZpS8YC67eQ2BDvR+oMzgJcjJ+GW9vFhy+3iQ@mail.gmail.com/
>
> It's not very magical, from v4 I would create a new branch:
> b4 prep -n rtl83xx -f v6.8-rc1
> b4 prep --force-version 5
> b4 prep --set-prefixes net-next
> b4 prep --edit cover
> <insert contents of patch 0/11 cover letter>
> then cherry pick the 11 patches on top of that branch
> and next time you b4 send it, it will pop out as v5.
>
> OK I know it's a bit of threshold but the b4 threshold is
> really low.
>
> Yours,
> Linus Walleij

Thanks Linus,

It definitely looks nice and it was already on my TODO list. I'll try
that in the next round. I just need to test it a little bit more.
That's why I used my old workflow this time.

Regards,

Luiz