[net-next,0/4] selftests: bonding: use busy/slowwait when waiting

Message

Hangbin Liu Jan. 24, 2024, 9:58 a.m. UTC

There are a lot waitings in bonding tests use sleep. Let's replace them with
busywait or slowwait(added in the first patch). This could save much test
time. e.g.

bond-break-lacpdu-tx.sh
  before: 0m16.346s
  after: 0m2.424s

bond_options.sh
  before: 9m25.299s
  after: 5m27.439s

bond-lladdr-target.sh
  before: 0m7.090s
  after: 0m6.148s

bond_macvlan.sh
  before: 0m44.999s
  after: 0m23.468s

In total, we could save about 270 seconds.

Hangbin Liu (4):
  selftests/net/forwarding: add slowwait functions
  selftests: bonding: use tc filter to check if LACP was sent
  selftests: bonding: reduce garp_test/arp_validate test time
  selftests: bonding: use busy/slowwait instead of hard code sleep

 .../net/bonding/bond-break-lacpdu-tx.sh       | 18 +++++-----
 .../drivers/net/bonding/bond-lladdr-target.sh | 21 +++++++++--
 .../drivers/net/bonding/bond_macvlan.sh       |  5 ++-
 .../drivers/net/bonding/bond_options.sh       | 22 +++++++++---
 .../drivers/net/bonding/bond_topo_2d1c.sh     |  6 ++--
 tools/testing/selftests/net/forwarding/lib.sh | 36 +++++++++++++++++++
 6 files changed, 85 insertions(+), 23 deletions(-)

Comments

Przemek Kitszel Jan. 24, 2024, 1:26 p.m. UTC | #1

On 1/24/24 10:58, Hangbin Liu wrote:
> There are a lot waitings in bonding tests use sleep. Let's replace them with
> busywait or slowwait(added in the first patch). This could save much test
> time. e.g.
> 
> bond-break-lacpdu-tx.sh
>    before: 0m16.346s
>    after: 0m2.424s
> 
> bond_options.sh
>    before: 9m25.299s
>    after: 5m27.439s
> 
> bond-lladdr-target.sh
>    before: 0m7.090s
>    after: 0m6.148s
> 
> bond_macvlan.sh
>    before: 0m44.999s
>    after: 0m23.468s
> 
> In total, we could save about 270 seconds.
> 
> Hangbin Liu (4):
>    selftests/net/forwarding: add slowwait functions
>    selftests: bonding: use tc filter to check if LACP was sent
>    selftests: bonding: reduce garp_test/arp_validate test time
>    selftests: bonding: use busy/slowwait instead of hard code sleep
> 
>   .../net/bonding/bond-break-lacpdu-tx.sh       | 18 +++++-----
>   .../drivers/net/bonding/bond-lladdr-target.sh | 21 +++++++++--
>   .../drivers/net/bonding/bond_macvlan.sh       |  5 ++-
>   .../drivers/net/bonding/bond_options.sh       | 22 +++++++++---
>   .../drivers/net/bonding/bond_topo_2d1c.sh     |  6 ++--
>   tools/testing/selftests/net/forwarding/lib.sh | 36 +++++++++++++++++++
>   6 files changed, 85 insertions(+), 23 deletions(-)
> 

for the series:
Reviewed-by: Przemek Kitszel <[e-mail]>