[net-next,0/6] Use KMEM_CACHE instead of kmem_cache_create

Message

Kunwu Chan Feb. 5, 2024, 7:20 a.m. UTC

As Jiri Pirko suggests, 
I'm using a patchset to cleanup the same issues in the 'net' module.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Some cache names are changed to be the same as struct names. 
This change is recorded in the changelog for easy reference.
It's harmless cause it's used in /proc/slabinfo to identify this cache.

Kunwu Chan (6):
  net: kcm: Simplify the allocation of slab caches
  ip6mr: Simplify the allocation of slab caches in ip6_mr_init
  ipmr: Simplify the allocation of slab caches
  ipv4: Simplify the allocation of slab caches in ip_rt_init
  tcp: Simplify the allocation of slab caches
  ipv6: Simplify the allocation of slab caches

 net/ipv4/ipmr.c    |  5 +----
 net/ipv4/route.c   |  5 ++---
 net/ipv4/tcp.c     | 14 ++++----------
 net/ipv6/ip6_fib.c |  6 ++----
 net/ipv6/ip6mr.c   |  5 +----
 net/kcm/kcmsock.c  |  8 ++------
 6 files changed, 12 insertions(+), 31 deletions(-)

Comments

Michal Swiatkowski Feb. 5, 2024, 7:37 a.m. UTC | #1

On Mon, Feb 05, 2024 at 03:20:07PM +0800, Kunwu Chan wrote:
> As Jiri Pirko suggests, 
You can add a suggested-by tag.

> I'm using a patchset to cleanup the same issues in the 'net' module.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
What about rest of the kmem_cache_create in net folder? (ex. fib_trie)

> Some cache names are changed to be the same as struct names. 
> This change is recorded in the changelog for easy reference.
> It's harmless cause it's used in /proc/slabinfo to identify this cache.
> 
> Kunwu Chan (6):
>   net: kcm: Simplify the allocation of slab caches
>   ip6mr: Simplify the allocation of slab caches in ip6_mr_init
>   ipmr: Simplify the allocation of slab caches
>   ipv4: Simplify the allocation of slab caches in ip_rt_init
>   tcp: Simplify the allocation of slab caches
>   ipv6: Simplify the allocation of slab caches
> 
>  net/ipv4/ipmr.c    |  5 +----
>  net/ipv4/route.c   |  5 ++---
>  net/ipv4/tcp.c     | 14 ++++----------
>  net/ipv6/ip6_fib.c |  6 ++----
>  net/ipv6/ip6mr.c   |  5 +----
>  net/kcm/kcmsock.c  |  8 ++------
>  6 files changed, 12 insertions(+), 31 deletions(-)
> 
> -- 
> 2.39.2

Changes looks fines, thanks
Reviewed-by: Michal Swiatkowski <[e-mail]>
for whole series.

Thanks,
Michal