mbox series

[net-next,0/2] net/sched: act_api: speed up netns dismantles

Message ID 20240208102508.262907-1-edumazet@google.com (mailing list archive)
Headers show
Series net/sched: act_api: speed up netns dismantles | expand

Message

Eric Dumazet Feb. 8, 2024, 10:25 a.m. UTC
Adopt the new exit_batch_rtnl() method to avoid extra
rtnl_lock()//rtnl_unlock() pairs.

Eric Dumazet (2):
  net/sched: act_api: uninline tc_action_net_init() and
    tc_action_net_exit()
  net/sched: act_api: use exit_batch_rtnl() method

 include/net/act_api.h      | 34 +++-------------------------------
 net/sched/act_api.c        | 35 ++++++++++++++++++++++++++++++++---
 net/sched/act_bpf.c        |  7 ++++---
 net/sched/act_connmark.c   |  7 ++++---
 net/sched/act_csum.c       |  7 ++++---
 net/sched/act_ct.c         |  7 ++++---
 net/sched/act_ctinfo.c     |  7 ++++---
 net/sched/act_gact.c       |  7 ++++---
 net/sched/act_gate.c       |  7 ++++---
 net/sched/act_ife.c        |  7 ++++---
 net/sched/act_mirred.c     |  7 ++++---
 net/sched/act_mpls.c       |  7 ++++---
 net/sched/act_nat.c        |  7 ++++---
 net/sched/act_pedit.c      |  7 ++++---
 net/sched/act_police.c     |  7 ++++---
 net/sched/act_sample.c     |  7 ++++---
 net/sched/act_simple.c     |  7 ++++---
 net/sched/act_skbedit.c    |  7 ++++---
 net/sched/act_skbmod.c     |  7 ++++---
 net/sched/act_tunnel_key.c |  7 ++++---
 net/sched/act_vlan.c       |  7 ++++---
 21 files changed, 111 insertions(+), 91 deletions(-)

Comments

Jamal Hadi Salim Feb. 8, 2024, 10:10 p.m. UTC | #1
On Thu, Feb 8, 2024 at 5:25 AM Eric Dumazet <edumazet@google.com> wrote:
>
> Adopt the new exit_batch_rtnl() method to avoid extra
> rtnl_lock()//rtnl_unlock() pairs.
>

For the patchset:
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> Eric Dumazet (2):
>   net/sched: act_api: uninline tc_action_net_init() and
>     tc_action_net_exit()
>   net/sched: act_api: use exit_batch_rtnl() method
>
>  include/net/act_api.h      | 34 +++-------------------------------
>  net/sched/act_api.c        | 35 ++++++++++++++++++++++++++++++++---
>  net/sched/act_bpf.c        |  7 ++++---
>  net/sched/act_connmark.c   |  7 ++++---
>  net/sched/act_csum.c       |  7 ++++---
>  net/sched/act_ct.c         |  7 ++++---
>  net/sched/act_ctinfo.c     |  7 ++++---
>  net/sched/act_gact.c       |  7 ++++---
>  net/sched/act_gate.c       |  7 ++++---
>  net/sched/act_ife.c        |  7 ++++---
>  net/sched/act_mirred.c     |  7 ++++---
>  net/sched/act_mpls.c       |  7 ++++---
>  net/sched/act_nat.c        |  7 ++++---
>  net/sched/act_pedit.c      |  7 ++++---
>  net/sched/act_police.c     |  7 ++++---
>  net/sched/act_sample.c     |  7 ++++---
>  net/sched/act_simple.c     |  7 ++++---
>  net/sched/act_skbedit.c    |  7 ++++---
>  net/sched/act_skbmod.c     |  7 ++++---
>  net/sched/act_tunnel_key.c |  7 ++++---
>  net/sched/act_vlan.c       |  7 ++++---
>  21 files changed, 111 insertions(+), 91 deletions(-)
>
> --
> 2.43.0.594.gd9cf4e227d-goog
>
Jakub Kicinski Feb. 9, 2024, 2:37 a.m. UTC | #2
On Thu,  8 Feb 2024 10:25:06 +0000 Eric Dumazet wrote:
> Adopt the new exit_batch_rtnl() method to avoid extra
> rtnl_lock()//rtnl_unlock() pairs.

Hi Eric! I think these were exploding selftests:

https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-02-08--18-00&executor=vmksft-net&pw-n=0&pass=0

not 100% sure, but they fit the bill, and once I dropped them the next
branch went thru cleanly.