[net,v2,0/2] ioam6: fix write to cloned skb's

Message

Justin Iurman Feb. 19, 2024, 1:48 p.m. UTC

v2:
 - use skb_ensure_writable() instead of skb_cloned()+pskb_expand_head()
 - refresh network header pointer in ip6_parse_tlv() when returning from
   ipv6_hop_ioam()

Make sure the IOAM data insertion is not applied on cloned skb's. As a
consequence, ioam selftests needed a refactoring.

Justin Iurman (2):
  Fix write to cloned skb in ipv6_hop_ioam()
  selftests: ioam: refactoring to align with the fix

 net/ipv6/exthdrs.c                         | 10 +++
 tools/testing/selftests/net/ioam6.sh       | 38 ++++-----
 tools/testing/selftests/net/ioam6_parser.c | 95 +++++++++++-----------
 3 files changed, 76 insertions(+), 67 deletions(-)


base-commit: 166c2c8a6a4dc2e4ceba9e10cfe81c3e469e3210

Comments

Justin Iurman Feb. 19, 2024, 1:56 p.m. UTC | #1

On 2/19/24 14:48, Justin Iurman wrote:
> v2:
>   - use skb_ensure_writable() instead of skb_cloned()+pskb_expand_head()
>   - refresh network header pointer in ip6_parse_tlv() when returning from
>     ipv6_hop_ioam()
> 
> Make sure the IOAM data insertion is not applied on cloned skb's. As a
> consequence, ioam selftests needed a refactoring.
> 
> Justin Iurman (2):
>    Fix write to cloned skb in ipv6_hop_ioam()
>    selftests: ioam: refactoring to align with the fix
> 
>   net/ipv6/exthdrs.c                         | 10 +++
>   tools/testing/selftests/net/ioam6.sh       | 38 ++++-----
>   tools/testing/selftests/net/ioam6_parser.c | 95 +++++++++++-----------
>   3 files changed, 76 insertions(+), 67 deletions(-)
> 
> 
> base-commit: 166c2c8a6a4dc2e4ceba9e10cfe81c3e469e3210

Sorry, please ignore v2 due to net and version not present in patches 
tag. Instead, please consider v3. Thanks.