| Message ID | 20240220214553.714243-1-maciej.fijalkowski@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | intel: fix routines that disable queue pairs | expand |
On Tue, 20 Feb 2024 at 22:46, Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote: > > Hi, > > It started out as an issue on ixgbe reported by Pavel [0] which first > patch is supposed to fix, but apparently i40e and ice have queue pair > disabling flow a bit out of order, so I addressed them as well. More > info is included in commit messages. > > FWIW we are talking here about AF_XDP ZC when xsk_pool is sent down to > driver. Typically these routines are executed when there is already XDP > program running on interface. > > Thanks! > > [0]: https://lore.kernel.org/netdev/CAJEV1ijxNyPTwASJER1bcZzS9nMoZJqfR86nu_3jFFVXzZQ4NA@mail.gmail.com/ Thank you for this fix Maciej. Acked-by: Magnus Karlsson <magnus.karlsson@intel.com> > Maciej Fijalkowski (3): > ixgbe: {dis,en}able irqs in ixgbe_txrx_ring_{dis,en}able > i40e: disable NAPI right after disabling irqs when handling xsk_pool > ice: reorder disabling IRQ and NAPI in ice_qp_dis > > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- > drivers/net/ethernet/intel/ice/ice_xsk.c | 9 +-- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 56 ++++++++++++++++--- > 3 files changed, 55 insertions(+), 12 deletions(-) > > -- > 2.34.1 >
Hi, It started out as an issue on ixgbe reported by Pavel [0] which first patch is supposed to fix, but apparently i40e and ice have queue pair disabling flow a bit out of order, so I addressed them as well. More info is included in commit messages. FWIW we are talking here about AF_XDP ZC when xsk_pool is sent down to driver. Typically these routines are executed when there is already XDP program running on interface. Thanks! [0]: https://lore.kernel.org/netdev/CAJEV1ijxNyPTwASJER1bcZzS9nMoZJqfR86nu_3jFFVXzZQ4NA@mail.gmail.com/ Maciej Fijalkowski (3): ixgbe: {dis,en}able irqs in ixgbe_txrx_ring_{dis,en}able i40e: disable NAPI right after disabling irqs when handling xsk_pool ice: reorder disabling IRQ and NAPI in ice_qp_dis drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/ice/ice_xsk.c | 9 +-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 56 ++++++++++++++++--- 3 files changed, 55 insertions(+), 12 deletions(-)