| Message ID | 20240312160551.73184-1-ignat@cloudflare.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: veth: ability to toggle GRO and XDP independently | expand |
On Tue, 12 Mar 2024 16:05:49 +0000 Ignat Korchagin wrote: > It is rather confusing that GRO is automatically enabled, when an XDP program > is attached to a veth interface. Moreover, it is not possible to disable GRO > on a veth, if an XDP program is attached (which might be desirable in some use > cases). > > Make GRO and XDP independent for a veth interface. Looks like the udpgro_fwd.sh test also needs tweakin' https://netdev-3.bots.linux.dev/vmksft-net/results/504620/17-udpgro-fwd-sh/stdout
On Wed, Mar 13, 2024 at 12:42 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 12 Mar 2024 16:05:49 +0000 Ignat Korchagin wrote: > > It is rather confusing that GRO is automatically enabled, when an XDP program > > is attached to a veth interface. Moreover, it is not possible to disable GRO > > on a veth, if an XDP program is attached (which might be desirable in some use > > cases). > > > > Make GRO and XDP independent for a veth interface. > > Looks like the udpgro_fwd.sh test also needs tweakin' Sent a v3 with adjusted test > https://netdev-3.bots.linux.dev/vmksft-net/results/504620/17-udpgro-fwd-sh/stdout > -- > pw-bot: cr
It is rather confusing that GRO is automatically enabled, when an XDP program is attached to a veth interface. Moreover, it is not possible to disable GRO on a veth, if an XDP program is attached (which might be desirable in some use cases). Make GRO and XDP independent for a veth interface. Ignat Korchagin (2): net: veth: do not manipulate GRO when using XDP selftests: net: veth: test the ability to independently manipulate GRO and XDP drivers/net/veth.c | 18 ------------------ tools/testing/selftests/net/veth.sh | 24 +++++++++++++++++++++--- 2 files changed, 21 insertions(+), 21 deletions(-)