[v2,bpf-next,0/3] BPF: support mark in bpf_fib_lookup

Message

Anton Protopopov March 26, 2024, 10:17 a.m. UTC

This patch series adds policy routing support in bpf_fib_lookup.
This is a useful functionality which was missing for a long time,
as without it some networking setups can't be implemented in BPF.
One example can be found here [1].

A while ago there was an attempt to add this functionality [2] by
Rumen Telbizov and David Ahern. I've completely refactored the code,
except that the changes to the struct bpf_fib_lookup were copy-pasted
from the original patch.

The first patch implements the functionality, the second patch adds
a few selftests, the third patch adds a build time check of the size
of the struct bpf_fib_lookup.

  [1] https://github.com/cilium/cilium/pull/12770
  [2] https://lore.kernel.org/all/[e-mail]/

v1 -> v2:
  - simplify the selftests (Martin)
  - add a static check for sizeof(struct bpf_fib_lookup) (David)

Anton Protopopov (3):
  bpf: add support for passing mark with bpf_fib_lookup
  selftests/bpf: Add BPF_FIB_LOOKUP_MARK tests
  bpf: add a check for struct bpf_fib_lookup size

 include/uapi/linux/bpf.h                      |  20 ++-
 net/core/filter.c                             |  15 +-
 tools/include/uapi/linux/bpf.h                |  20 ++-
 .../selftests/bpf/prog_tests/fib_lookup.c     | 134 ++++++++++++++----
 4 files changed, 153 insertions(+), 36 deletions(-)

Comments

[e-mail] March 26, 2024, 9:50 p.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <[e-mail]>:

On Tue, 26 Mar 2024 10:17:39 +0000 you wrote:
> This patch series adds policy routing support in bpf_fib_lookup.
> This is a useful functionality which was missing for a long time,
> as without it some networking setups can't be implemented in BPF.
> One example can be found here [1].
> 
> A while ago there was an attempt to add this functionality [2] by
> Rumen Telbizov and David Ahern. I've completely refactored the code,
> except that the changes to the struct bpf_fib_lookup were copy-pasted
> from the original patch.
> 
> [...]

Here is the summary with links:
  - [v2,bpf-next,1/3] bpf: add support for passing mark with bpf_fib_lookup
    https://git.kernel.org/bpf/bpf-next/c/30ed73eb7d63
  - [v2,bpf-next,2/3] selftests/bpf: Add BPF_FIB_LOOKUP_MARK tests
    https://git.kernel.org/bpf/bpf-next/c/656a5bb56ea6
  - [v2,bpf-next,3/3] bpf: add a check for struct bpf_fib_lookup size
    https://git.kernel.org/bpf/bpf-next/c/98103fa6cc3f

You are awesome, thank you!