mbox series

[v2,net,0/8] tcp: Fix bind() regression and more tests.

Message ID 20240326204251.51301-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series tcp: Fix bind() regression and more tests. | expand

Message

Kuniyuki Iwashima March 26, 2024, 8:42 p.m. UTC
bhash2 has not been well tested for IPV6_V6ONLY option.

This series fixes two regression around IPV6_V6ONLY, one of which
has been there since bhash2 introduction, and another is introduced
by a recent change.

Also, this series adds as many tests as possible to catch regression
easily.  The baseline is 28044fc1d495~ which is pre-bhash2 commit.

 Tested on 28044fc1d495~:
  # PASSED: 132 / 132 tests passed.
  # Totals: pass:132 fail:0 xfail:0 xpass:0 skip:0 error:0

 net.git:
  # FAILED: 125 / 132 tests passed.
  # Totals: pass:125 fail:7 xfail:0 xpass:0 skip:0 error:0

 With this series:
  # PASSED: 132 / 132 tests passed.
  # Totals: pass:132 fail:0 xfail:0 xpass:0 skip:0 error:0


Changes:
  v2:
    * Patch 1: Fix build error when IPV6=n

  v1: https://lore.kernel.org/netdev/20240325181923.48769-1-kuniyu@amazon.com/


Kuniyuki Iwashima (8):
  tcp: Fix bind() regression for v6-only wildcard and v4-mapped-v6
    non-wildcard addresses.
  tcp: Fix bind() regression for v6-only wildcard and v4(-mapped-v6)
    non-wildcard addresses.
  selftest: tcp: Make bind() selftest flexible.
  selftest: tcp: Define the reverse order bind() tests explicitly.
  selftest: tcp: Add v4-v4 and v6-v6 bind() conflict tests.
  selftest: tcp: Add more bind() calls.
  selftest: tcp: Add bind() tests for IPV6_V6ONLY.
  selftest: tcp: Add bind() tests for SO_REUSEADDR/SO_REUSEPORT.

 net/ipv4/inet_connection_sock.c             |  30 +-
 tools/testing/selftests/net/bind_wildcard.c | 783 ++++++++++++++++++--
 2 files changed, 736 insertions(+), 77 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 29, 2024, 10:50 p.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 26 Mar 2024 13:42:43 -0700 you wrote:
> bhash2 has not been well tested for IPV6_V6ONLY option.
> 
> This series fixes two regression around IPV6_V6ONLY, one of which
> has been there since bhash2 introduction, and another is introduced
> by a recent change.
> 
> Also, this series adds as many tests as possible to catch regression
> easily.  The baseline is 28044fc1d495~ which is pre-bhash2 commit.
> 
> [...]

Here is the summary with links:
  - [v2,net,1/8] tcp: Fix bind() regression for v6-only wildcard and v4-mapped-v6 non-wildcard addresses.
    https://git.kernel.org/netdev/net/c/ea111449501e
  - [v2,net,2/8] tcp: Fix bind() regression for v6-only wildcard and v4(-mapped-v6) non-wildcard addresses.
    https://git.kernel.org/netdev/net/c/d91ef1e1b55f
  - [v2,net,3/8] selftest: tcp: Make bind() selftest flexible.
    https://git.kernel.org/netdev/net/c/c48baf567ded
  - [v2,net,4/8] selftest: tcp: Define the reverse order bind() tests explicitly.
    https://git.kernel.org/netdev/net/c/6f9bc755c021
  - [v2,net,5/8] selftest: tcp: Add v4-v4 and v6-v6 bind() conflict tests.
    https://git.kernel.org/netdev/net/c/5e9e9afdb504
  - [v2,net,6/8] selftest: tcp: Add more bind() calls.
    https://git.kernel.org/netdev/net/c/f40742c22a6e
  - [v2,net,7/8] selftest: tcp: Add bind() tests for IPV6_V6ONLY.
    https://git.kernel.org/netdev/net/c/d37f2f72c91f
  - [v2,net,8/8] selftest: tcp: Add bind() tests for SO_REUSEADDR/SO_REUSEPORT.
    https://git.kernel.org/netdev/net/c/7679f0968d01

You are awesome, thank you!