| Message ID | 20240327075733.8967-1-ivecera@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i40e: cleanups & refactors | expand |
On 3/27/2024 12:57 AM, Ivan Vecera wrote: > This series do following: > Patch 1 - Removes write-only flags field from i40e_veb structure and > from i40e_veb_setup() parameters > Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() > and i40e_notify_client_of_netdev_close() > Patch 3 - Refactors parameter of i40e_detect_recover_hung() > Patch 4 - Adds helper i40e_pf_get_main_vsi() to get main VSI and uses it > in existing code > Patch 5 - Consolidates checks whether given VSI is the main one > Patch 6 - Adds helper i40e_pf_get_main_veb() to get main VEB and uses it > in existing code > Patch 7 - Adds helper i40e_vsi_reconfig_tc() to reconfigure TC for > particular and uses it to replace existing open-coded pieces Hi Ivan, With the new checks on kdoc [1], this now reports issues. Can you fix those? Feel free to send the new version to 'net-next' as our validation has finished their testing on this series. You can add my Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com> Thanks, Tony > Changes since v1: > - adjusted titles for patches 2 & 3 > > Ivan Vecera (8): > i40e: Remove flags field from i40e_veb > i40e: Refactor argument of several client notification functions > i40e: Refactor argument of i40e_detect_recover_hung() > i40e: Add helper to access main VSI > i40e: Consolidate checks whether given VSI is main > i40e: Add helper to access main VEB > i40e: Add and use helper to reconfigure TC for given VSI > > drivers/net/ethernet/intel/i40e/i40e.h | 30 ++- > drivers/net/ethernet/intel/i40e/i40e_client.c | 28 +-- > drivers/net/ethernet/intel/i40e/i40e_ddp.c | 3 +- > .../net/ethernet/intel/i40e/i40e_debugfs.c | 36 +-- > .../net/ethernet/intel/i40e/i40e_ethtool.c | 29 ++- > drivers/net/ethernet/intel/i40e/i40e_main.c | 205 ++++++++++-------- > drivers/net/ethernet/intel/i40e/i40e_ptp.c | 6 +- > .../net/ethernet/intel/i40e/i40e_register.h | 3 + > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 98 ++++++--- > drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +- > .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 +- > 11 files changed, 282 insertions(+), 173 deletions(-) [1] https://lore.kernel.org/netdev/20240411200608.2fcf7e36@kernel.org/
On 12. 04. 24 23:19, Tony Nguyen wrote: > > > On 3/27/2024 12:57 AM, Ivan Vecera wrote: >> This series do following: >> Patch 1 - Removes write-only flags field from i40e_veb structure and >> from i40e_veb_setup() parameters >> Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() >> and i40e_notify_client_of_netdev_close() >> Patch 3 - Refactors parameter of i40e_detect_recover_hung() >> Patch 4 - Adds helper i40e_pf_get_main_vsi() to get main VSI and uses it >> in existing code >> Patch 5 - Consolidates checks whether given VSI is the main one >> Patch 6 - Adds helper i40e_pf_get_main_veb() to get main VEB and uses it >> in existing code >> Patch 7 - Adds helper i40e_vsi_reconfig_tc() to reconfigure TC for >> particular and uses it to replace existing open-coded pieces > > Hi Ivan, > > With the new checks on kdoc [1], this now reports issues. Can you fix > those? Feel free to send the new version to 'net-next' as our validation > has finished their testing on this series. > > You can add my > > Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com> > > Thanks, > Tony Huh, I missed your email. Will send v3. Thanks, Ivan >> Changes since v1: >> - adjusted titles for patches 2 & 3 >> >> Ivan Vecera (8): >> i40e: Remove flags field from i40e_veb >> i40e: Refactor argument of several client notification functions >> i40e: Refactor argument of i40e_detect_recover_hung() >> i40e: Add helper to access main VSI >> i40e: Consolidate checks whether given VSI is main >> i40e: Add helper to access main VEB >> i40e: Add and use helper to reconfigure TC for given VSI >> >> drivers/net/ethernet/intel/i40e/i40e.h | 30 ++- >> drivers/net/ethernet/intel/i40e/i40e_client.c | 28 +-- >> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 3 +- >> .../net/ethernet/intel/i40e/i40e_debugfs.c | 36 +-- >> .../net/ethernet/intel/i40e/i40e_ethtool.c | 29 ++- >> drivers/net/ethernet/intel/i40e/i40e_main.c | 205 ++++++++++-------- >> drivers/net/ethernet/intel/i40e/i40e_ptp.c | 6 +- >> .../net/ethernet/intel/i40e/i40e_register.h | 3 + >> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 98 ++++++--- >> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +- >> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 +- >> 11 files changed, 282 insertions(+), 173 deletions(-) > > [1] https://lore.kernel.org/netdev/20240411200608.2fcf7e36@kernel.org/ >
This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and from i40e_veb_setup() parameters Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() and i40e_notify_client_of_netdev_close() Patch 3 - Refactors parameter of i40e_detect_recover_hung() Patch 4 - Adds helper i40e_pf_get_main_vsi() to get main VSI and uses it in existing code Patch 5 - Consolidates checks whether given VSI is the main one Patch 6 - Adds helper i40e_pf_get_main_veb() to get main VEB and uses it in existing code Patch 7 - Adds helper i40e_vsi_reconfig_tc() to reconfigure TC for particular and uses it to replace existing open-coded pieces Changes since v1: - adjusted titles for patches 2 & 3 Ivan Vecera (8): i40e: Remove flags field from i40e_veb i40e: Refactor argument of several client notification functions i40e: Refactor argument of i40e_detect_recover_hung() i40e: Add helper to access main VSI i40e: Consolidate checks whether given VSI is main i40e: Add helper to access main VEB i40e: Add and use helper to reconfigure TC for given VSI drivers/net/ethernet/intel/i40e/i40e.h | 30 ++- drivers/net/ethernet/intel/i40e/i40e_client.c | 28 +-- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 3 +- .../net/ethernet/intel/i40e/i40e_debugfs.c | 36 +-- .../net/ethernet/intel/i40e/i40e_ethtool.c | 29 ++- drivers/net/ethernet/intel/i40e/i40e_main.c | 205 ++++++++++-------- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 6 +- .../net/ethernet/intel/i40e/i40e_register.h | 3 + drivers/net/ethernet/intel/i40e/i40e_txrx.c | 98 ++++++--- drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +- .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 +- 11 files changed, 282 insertions(+), 173 deletions(-)