mbox series

[net-next,v3,0/3] genetlink: remove linux/genetlink.h

Message ID 20240329175710.291749-1-kuba@kernel.org (mailing list archive)
Headers show
Series genetlink: remove linux/genetlink.h | expand

Message

Jakub Kicinski March 29, 2024, 5:57 p.m. UTC 
There are two genetlink headers net/genetlink.h and linux/genetlink.h
This is similar to netlink.h, but for netlink.h both contain good
amount of code. For genetlink.h the linux/ version is leftover
from before uAPI headers were split out, it has 10 lines of code.
Move those 10 lines into other appropriate headers and delete
linux/genetlink.h.

I occasionally open the wrong header in the editor when coding,
I guess I'm not the only one.

v3:
 - fix Andy's nits on patch 3
v2: https://lore.kernel.org/all/20240325173716.2390605-1-kuba@kernel.org/
 - fix Andy's nits on patch 3
v1: https://lore.kernel.org/all/20240309183458.3014713-1-kuba@kernel.org

Jakub Kicinski (3):
  netlink: create a new header for internal genetlink symbols
  net: openvswitch: remove unnecessary linux/genetlink.h include
  genetlink: remove linux/genetlink.h

 drivers/net/wireguard/main.c      |  2 +-
 include/linux/genetlink.h         | 19 -------------------
 include/linux/genl_magic_struct.h |  2 +-
 include/net/genetlink.h           | 10 +++++++++-
 net/batman-adv/main.c             |  2 +-
 net/batman-adv/netlink.c          |  1 -
 net/netlink/af_netlink.c          |  2 +-
 net/netlink/genetlink.c           |  2 ++
 net/netlink/genetlink.h           | 11 +++++++++++
 net/openvswitch/datapath.c        |  1 -
 net/openvswitch/meter.h           |  1 -
 11 files changed, 26 insertions(+), 27 deletions(-)
 delete mode 100644 include/linux/genetlink.h
 create mode 100644 net/netlink/genetlink.h

Comments

patchwork-bot+netdevbpf@kernel.org April 2, 2024, 5 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 29 Mar 2024 10:57:07 -0700 you wrote:
> There are two genetlink headers net/genetlink.h and linux/genetlink.h
> This is similar to netlink.h, but for netlink.h both contain good
> amount of code. For genetlink.h the linux/ version is leftover
> from before uAPI headers were split out, it has 10 lines of code.
> Move those 10 lines into other appropriate headers and delete
> linux/genetlink.h.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] netlink: create a new header for internal genetlink symbols
    https://git.kernel.org/netdev/net-next/c/5bc63d3a6f46
  - [net-next,v3,2/3] net: openvswitch: remove unnecessary linux/genetlink.h include
    https://git.kernel.org/netdev/net-next/c/f97c9b533a1d
  - [net-next,v3,3/3] genetlink: remove linux/genetlink.h
    https://git.kernel.org/netdev/net-next/c/cd7209628cdb

You are awesome, thank you!