From patchwork Thu Apr 11 12:05:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13625839 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB6414B08E for ; Thu, 11 Apr 2024 12:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712837156; cv=none; b=mGM2bk0JmMH5Am7tMZpCeM70D6N4uoSMB2S2afjoCIWb7ledrK+r5vNoYT4exoE3lzRZHEJWnmGmvD8Id4Oe2htkdQFjyZHEvds7j72TB88WtRMxw3brImz2/RnNTa6pwnszOzbJNNJUGNye3R93C/Mqc0DvetqbXkkwHiKQBlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712837156; c=relaxed/simple; bh=CRfT2nz9BUNbS5W61TqhZC4a5CFzF8Z52TOUInd0dKg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UNyf50eRMg2Iu6UtpQl6eXpzWSXh88oVvI0m9XINrSb5tgu7p8qTKD3npmfkjzJTcHYcbLlJMKIzlIgEWy8MpTg2jK+rFCZhRwV4leuMxIchEucDfLIh0er6qsjxAzflxq2uZvcJoHd+P8H0eZYGa3ksOVyrz/kmg5j12xs/1U8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NoAToNp/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NoAToNp/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712837154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ytNFNKtdcF5mu7UnZA6pPMlfQCsVJ9uzk0MPXgKTnEo=; b=NoAToNp/ce6yjYJDMQq0oQbza0NYY8blmFOXNoTaXpwv27Yf/jAImBH4aOs+cT3UWCnQru mQ5KUIlYwidr99c0BTElAejWmWkoY7Ztu/pM2qsHQ7jOE1fuESnFua1Yxt4JrtxebEHZFa WsjN1kQasdqJQeHOfGtBGddz69T63bI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-JudkfC5UNjaE784uI2zziA-1; Thu, 11 Apr 2024 08:05:51 -0400 X-MC-Unique: JudkfC5UNjaE784uI2zziA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF2F8801797; Thu, 11 Apr 2024 12:05:50 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.39.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 072EB1C060D1; Thu, 11 Apr 2024 12:05:47 +0000 (UTC) From: Valentin Schneider To: dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , mleitner@redhat.com, David Ahern , Juri Lelli , Tomas Glozar , Sebastian Andrzej Siewior , Thomas Gleixner Subject: [PATCH v4 0/1] tcp/dcpp: Un-pin tw_timer Date: Thu, 11 Apr 2024 14:05:34 +0200 Message-ID: <20240411120535.2494067-1-vschneid@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Hi, This is v4 of the series where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups. Eric mentionned rsk_timer needs looking into, but I haven't had the time to do that. It doesn't show up in our testing, which might be due to its relatively low timeout (IIUC 3s). Revisions ========= v3 -> v2 ++++++++ o Rebased against latest Linus' tree o Added ehash lock usage to serialize scheduling vs descheduling of the tw_timer (Paolo) v2 -> v3 ++++++++ o Dropped bh_disable patch o Rebased against latest Linus' tree RFCv1 -> v2 ++++++++ o Added comment in inet_twsk_deschedule_put() to highlight the race o Added bh_disable patch Valentin Schneider (1): tcp/dcpp: Un-pin tw_timer include/net/inet_timewait_sock.h | 6 ++-- net/dccp/minisocks.c | 9 +++-- net/ipv4/inet_timewait_sock.c | 59 +++++++++++++++++++++++--------- net/ipv4/tcp_minisocks.c | 9 +++-- 4 files changed, 55 insertions(+), 28 deletions(-) --- 2.43.0