mbox series

[iwl-next,v1,0/4] ice: prepare representor for SF support

Message ID 20240419171336.11617-1-michal.swiatkowski@linux.intel.com (mailing list archive)
Headers show
Series ice: prepare representor for SF support | expand

Message

Michal Swiatkowski April 19, 2024, 5:13 p.m. UTC 
Hi,

This is a series to prepare port representor for supporting also
subfunctions. We need correct devlink locking and the possibility to
update parent VSI after port representor is created.

Refactor how devlink lock is taken to suite the subfunction use case.

VSI configuration needs to be done after port representor is created.
Port representor needs only allocated VSI. It doesn't need to be
configured before.

VSI needs to be reconfigured when update function is called.

The code for this patchset was split from (too big) patchset [1].

[1] https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkowski@linux.intel.com/

Michal Swiatkowski (4):
  ice: store representor ID in bridge port
  ice: move devlink locking outside the port creation
  ice: move VSI configuration outside repr setup
  ice: update representor when VSI is ready

 .../net/ethernet/intel/ice/devlink/devlink.c  |  2 -
 .../ethernet/intel/ice/devlink/devlink_port.c |  4 +-
 drivers/net/ethernet/intel/ice/ice_eswitch.c  | 83 +++++++++++++------
 drivers/net/ethernet/intel/ice/ice_eswitch.h  | 14 +++-
 .../net/ethernet/intel/ice/ice_eswitch_br.c   |  4 +-
 .../net/ethernet/intel/ice/ice_eswitch_br.h   |  1 +
 drivers/net/ethernet/intel/ice/ice_repr.c     | 16 ++--
 drivers/net/ethernet/intel/ice/ice_repr.h     |  1 +
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  2 +-
 9 files changed, 88 insertions(+), 39 deletions(-)

Comments

Jiri Pirko April 22, 2024, 1:02 p.m. UTC | #1 
Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkowski@linux.intel.com wrote:
>Hi,
>
>This is a series to prepare port representor for supporting also
>subfunctions. We need correct devlink locking and the possibility to
>update parent VSI after port representor is created.
>
>Refactor how devlink lock is taken to suite the subfunction use case.
>
>VSI configuration needs to be done after port representor is created.
>Port representor needs only allocated VSI. It doesn't need to be
>configured before.
>
>VSI needs to be reconfigured when update function is called.
>
>The code for this patchset was split from (too big) patchset [1].
>
>[1] https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkowski@linux.intel.com/
>
>Michal Swiatkowski (4):
>  ice: store representor ID in bridge port
>  ice: move devlink locking outside the port creation
>  ice: move VSI configuration outside repr setup
>  ice: update representor when VSI is ready

FWIW, looks fine to me.


>
> .../net/ethernet/intel/ice/devlink/devlink.c  |  2 -
> .../ethernet/intel/ice/devlink/devlink_port.c |  4 +-
> drivers/net/ethernet/intel/ice/ice_eswitch.c  | 83 +++++++++++++------
> drivers/net/ethernet/intel/ice/ice_eswitch.h  | 14 +++-
> .../net/ethernet/intel/ice/ice_eswitch_br.c   |  4 +-
> .../net/ethernet/intel/ice/ice_eswitch_br.h   |  1 +
> drivers/net/ethernet/intel/ice/ice_repr.c     | 16 ++--
> drivers/net/ethernet/intel/ice/ice_repr.h     |  1 +
> drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  2 +-
> 9 files changed, 88 insertions(+), 39 deletions(-)
>
>-- 
>2.42.0
>
>