mbox series

[net-next,v2,00/15] MT7530 DSA Subdriver Improvements Act IV

Message ID 20240422-for-netnext-mt7530-improvements-4-v2-0-a75157ba76ad@arinc9.com (mailing list archive)
Headers show
Series MT7530 DSA Subdriver Improvements Act IV | expand

Message

Arınç ÜNAL via B4 Relay April 22, 2024, 7:15 a.m. UTC 
Hello!

This is the forth patch series with the goal of simplifying the MT7530 DSA
subdriver and improving support for MT7530, MT7531, and the switch on the
MT7988 SoC.

I have done a simple ping test to confirm basic communication on all switch
ports on MCM and standalone MT7530, and MT7531 switch with this patch
series applied.

MT7621 Unielec, MCM MT7530:

rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb
gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb

tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000

MT7622 Bananapi, MT7531:

gmac0-and-gmac1-mt7622-bananapi-bpi-r64.dtb

tftpboot 0x40000000 arm64-Image; tftpboot 0x45000000 arm64-rootfs.cpio.uboot; tftpboot 0x4a000000 $dtb; booti 0x40000000 0x45000000 0x4a000000

MT7623 Bananapi, standalone MT7530:

rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb
gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb

tftpboot 0x80008000 arm-zImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootz 0x80008000 0x83000000 0x83f00000

This patch series finalises the patch series linked below.

https://lore.kernel.org/r/20230522121532.86610-1-arinc.unal@arinc9.com

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
Changes in v2:
- Add two new patches to the end.
- Patch 13
  - Add the missing patch log.
- Link to v1: https://lore.kernel.org/r/20240419-for-netnext-mt7530-improvements-4-v1-0-6d852ca79b1d@arinc9.com

---
Arınç ÜNAL (15):
      net: dsa: mt7530: disable EEE abilities on failure on MT7531 and MT7988
      net: dsa: mt7530: refactor MT7530_PMCR_P()
      net: dsa: mt7530: rename p5_intf_sel and use only for MT7530 switch
      net: dsa: mt7530: rename mt753x_bpdu_port_fw enum to mt753x_to_cpu_fw
      net: dsa: mt7530: refactor MT7530_MFC and MT7531_CFC, add MT7531_QRY_FFP
      net: dsa: mt7530: refactor MT7530_HWTRAP and MT7530_MHWTRAP
      net: dsa: mt7530: move MT753X_MTRAP operations for MT7530
      net: dsa: mt7530: return mt7530_setup_mdio & mt7531_setup_common on error
      net: dsa: mt7530: define MAC speed capabilities per switch model
      net: dsa: mt7530: get rid of function sanity check
      net: dsa: mt7530: refactor MT7530_PMEEECR_P()
      net: dsa: mt7530: get rid of mac_port_validate member of mt753x_info
      net: dsa: mt7530: use priv->ds->num_ports instead of MT7530_NUM_PORTS
      net: dsa: mt7530: do not pass port variable to mt7531_rgmii_setup()
      net: dsa: mt7530: explain exposing MDIO bus of MT7531AE better

 drivers/net/dsa/mt7530.c | 294 +++++++++++++++++++++++------------------------
 drivers/net/dsa/mt7530.h | 289 ++++++++++++++++++++++++----------------------
 2 files changed, 297 insertions(+), 286 deletions(-)
---
base-commit: e1bc03d8372ac081810c2956cd244ed9899f9a02
change-id: 20240320-for-netnext-mt7530-improvements-4-95430d150c05

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org April 24, 2024, 11:10 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 22 Apr 2024 10:15:07 +0300 you wrote:
> Hello!
> 
> This is the forth patch series with the goal of simplifying the MT7530 DSA
> subdriver and improving support for MT7530, MT7531, and the switch on the
> MT7988 SoC.
> 
> I have done a simple ping test to confirm basic communication on all switch
> ports on MCM and standalone MT7530, and MT7531 switch with this patch
> series applied.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,01/15] net: dsa: mt7530: disable EEE abilities on failure on MT7531 and MT7988
    https://git.kernel.org/netdev/net-next/c/385c22ee4ba4
  - [net-next,v2,02/15] net: dsa: mt7530: refactor MT7530_PMCR_P()
    https://git.kernel.org/netdev/net-next/c/883ea1c0ed48
  - [net-next,v2,03/15] net: dsa: mt7530: rename p5_intf_sel and use only for MT7530 switch
    https://git.kernel.org/netdev/net-next/c/eeaf9acbfc50
  - [net-next,v2,04/15] net: dsa: mt7530: rename mt753x_bpdu_port_fw enum to mt753x_to_cpu_fw
    https://git.kernel.org/netdev/net-next/c/7603a0c7d221
  - [net-next,v2,05/15] net: dsa: mt7530: refactor MT7530_MFC and MT7531_CFC, add MT7531_QRY_FFP
    https://git.kernel.org/netdev/net-next/c/9c7401dc1b13
  - [net-next,v2,06/15] net: dsa: mt7530: refactor MT7530_HWTRAP and MT7530_MHWTRAP
    https://git.kernel.org/netdev/net-next/c/7c8d14029dff
  - [net-next,v2,07/15] net: dsa: mt7530: move MT753X_MTRAP operations for MT7530
    https://git.kernel.org/netdev/net-next/c/377174c5760c
  - [net-next,v2,08/15] net: dsa: mt7530: return mt7530_setup_mdio & mt7531_setup_common on error
    https://git.kernel.org/netdev/net-next/c/7bf06bcd946e
  - [net-next,v2,09/15] net: dsa: mt7530: define MAC speed capabilities per switch model
    https://git.kernel.org/netdev/net-next/c/6512204b4d5b
  - [net-next,v2,10/15] net: dsa: mt7530: get rid of function sanity check
    https://git.kernel.org/netdev/net-next/c/379f7bf864f6
  - [net-next,v2,11/15] net: dsa: mt7530: refactor MT7530_PMEEECR_P()
    https://git.kernel.org/netdev/net-next/c/99acfa82ddb1
  - [net-next,v2,12/15] net: dsa: mt7530: get rid of mac_port_validate member of mt753x_info
    https://git.kernel.org/netdev/net-next/c/aa16e1fc9ea8
  - [net-next,v2,13/15] net: dsa: mt7530: use priv->ds->num_ports instead of MT7530_NUM_PORTS
    https://git.kernel.org/netdev/net-next/c/318c1944710a
  - [net-next,v2,14/15] net: dsa: mt7530: do not pass port variable to mt7531_rgmii_setup()
    https://git.kernel.org/netdev/net-next/c/9df9aec174f5
  - [net-next,v2,15/15] net: dsa: mt7530: explain exposing MDIO bus of MT7531AE better
    https://git.kernel.org/netdev/net-next/c/bf1774491eea

You are awesome, thank you!
Daniel Golle April 25, 2024, 12:49 p.m. UTC | #2 
On Mon, Apr 22, 2024 at 10:15:07AM +0300, Arınç ÜNAL via B4 Relay wrote:
> Hello!
> 
> This is the forth patch series with the goal of simplifying the MT7530 DSA
> subdriver and improving support for MT7530, MT7531, and the switch on the
> MT7988 SoC.
> 
> I have done a simple ping test to confirm basic communication on all switch
> ports on MCM and standalone MT7530, and MT7531 switch with this patch
> series applied.
> 
> MT7621 Unielec, MCM MT7530:
> 
> rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb
> gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb
> 
> tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000
> 
> MT7622 Bananapi, MT7531:
> 
> gmac0-and-gmac1-mt7622-bananapi-bpi-r64.dtb
> 
> tftpboot 0x40000000 arm64-Image; tftpboot 0x45000000 arm64-rootfs.cpio.uboot; tftpboot 0x4a000000 $dtb; booti 0x40000000 0x45000000 0x4a000000
> 
> MT7623 Bananapi, standalone MT7530:
> 
> rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb
> gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb
> 
> tftpboot 0x80008000 arm-zImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootz 0x80008000 0x83000000 0x83f00000
> 
> This patch series finalises the patch series linked below.
> 
> https://lore.kernel.org/r/20230522121532.86610-1-arinc.unal@arinc9.com
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

I've imported the series to OpenWrt as pending patch and (briefly)
tested it myself on MT7988 and MT7986+MT7531 hardware, with very little
changes so it would apply on Linux 6.1 and Linux 6.6.

https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=d40691a5fb9415976bc917d1d96a0a6da99f2dc1

So for the whole series:

Tested-by: Daniel Golle <daniel@makrotopia.org>

I will review the patches individually in the next days.


> ---
> Changes in v2:
> - Add two new patches to the end.
> - Patch 13
>   - Add the missing patch log.
> - Link to v1: https://lore.kernel.org/r/20240419-for-netnext-mt7530-improvements-4-v1-0-6d852ca79b1d@arinc9.com
> 
> ---
> Arınç ÜNAL (15):
>       net: dsa: mt7530: disable EEE abilities on failure on MT7531 and MT7988
>       net: dsa: mt7530: refactor MT7530_PMCR_P()
>       net: dsa: mt7530: rename p5_intf_sel and use only for MT7530 switch
>       net: dsa: mt7530: rename mt753x_bpdu_port_fw enum to mt753x_to_cpu_fw
>       net: dsa: mt7530: refactor MT7530_MFC and MT7531_CFC, add MT7531_QRY_FFP
>       net: dsa: mt7530: refactor MT7530_HWTRAP and MT7530_MHWTRAP
>       net: dsa: mt7530: move MT753X_MTRAP operations for MT7530
>       net: dsa: mt7530: return mt7530_setup_mdio & mt7531_setup_common on error
>       net: dsa: mt7530: define MAC speed capabilities per switch model
>       net: dsa: mt7530: get rid of function sanity check
>       net: dsa: mt7530: refactor MT7530_PMEEECR_P()
>       net: dsa: mt7530: get rid of mac_port_validate member of mt753x_info
>       net: dsa: mt7530: use priv->ds->num_ports instead of MT7530_NUM_PORTS
>       net: dsa: mt7530: do not pass port variable to mt7531_rgmii_setup()
>       net: dsa: mt7530: explain exposing MDIO bus of MT7531AE better
> 
>  drivers/net/dsa/mt7530.c | 294 +++++++++++++++++++++++------------------------
>  drivers/net/dsa/mt7530.h | 289 ++++++++++++++++++++++++----------------------
>  2 files changed, 297 insertions(+), 286 deletions(-)
> ---
> base-commit: e1bc03d8372ac081810c2956cd244ed9899f9a02
> change-id: 20240320-for-netnext-mt7530-improvements-4-95430d150c05
> 
> Best regards,
> -- 
> Arınç ÜNAL <arinc.unal@arinc9.com>
> 
>