| Message ID | 20240427-realtek-led-v2-0-5abaddc32cf6@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: dsa: realtek: fix LED support for rtl8366 | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 27 Apr 2024 02:11:27 -0300 you wrote: > This series fixes the LED support for rtl8366. The existing code was not > tested in a device with switch LEDs and it was using a flawed logic. > > The driver now keeps the default LED configuration if nothing requests a > different behavior. This may be enough for most devices. This can be > achieved either by omitting the LED from the device-tree or configuring > all LEDs in a group with the default state set to "keep". > > [...] Here is the summary with links: - [net-next,v2,1/3] net: dsa: realtek: keep default LED state in rtl8366rb https://git.kernel.org/netdev/net-next/c/5edc6585aafe - [net-next,v2,2/3] net: dsa: realtek: do not assert reset on remove https://git.kernel.org/netdev/net-next/c/4f580e9aced1 - [net-next,v2,3/3] net: dsa: realtek: add LED drivers for rtl8366rb https://git.kernel.org/netdev/net-next/c/32d617005475 You are awesome, thank you!
This series fixes the LED support for rtl8366. The existing code was not tested in a device with switch LEDs and it was using a flawed logic. The driver now keeps the default LED configuration if nothing requests a different behavior. This may be enough for most devices. This can be achieved either by omitting the LED from the device-tree or configuring all LEDs in a group with the default state set to "keep". The hardware trigger for LEDs in Realtek switches is shared among all LEDs in a group. This behavior doesn't align well with the Linux LED API, which controls LEDs individually. Once the OS changes the brightness of a LED in a group still triggered by the hardware, the entire group switches to software-controlled LEDs, even for those not metioned in the device-tree. This shared behavior also prevents offloading the trigger to the hardware as it would require an orchestration between LEDs in a group, not currently present in the LED API. The assertion of device hardware reset during driver removal was removed because it was causing an issue with the LED release code. Devres devices are released after the driver's removal is executed. Asserting the reset at that point was causing timeout errors during LED release when it attempted to turn off the LED. To: Linus Walleij <linus.walleij@linaro.org> To: Alvin Šipraga <alsi@bang-olufsen.dk> To: Andrew Lunn <andrew@lunn.ch> To: Florian Fainelli <f.fainelli@gmail.com> To: Vladimir Oltean <olteanv@gmail.com> To: David S. Miller <davem@davemloft.net> To: Eric Dumazet <edumazet@google.com> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Conor Dooley <conor+dt@kernel.org> Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Changes in v2: - Fixed commit message formatting - Added GROUP to LED group enum values. With that, moved the code that disables LED into a new function to keep 80-collumn limit. - Dropped unused enable argument in rb8366rb_get_port_led() - Fixed variable order in rtl8366rb_setup_led() - Removed redundant led group test in rb8366rb_{g,s}et_port_led() - Initialize ret as 0 in rtl8366rb_setup_leds() - Updated comments related to LED blinking and setup - Link to v1: https://lore.kernel.org/r/20240310-realtek-led-v1-0-4d9813ce938e@gmail.com Changes in v1: - Rebased on new relatek DSA drivers - Improved commit messages - Added commit to remove the reset assert during .remove - Link to RFC: https://lore.kernel.org/r/20240106184651.3665-1-luizluca@gmail.com --- Luiz Angelo Daros de Luca (3): net: dsa: realtek: keep default LED state in rtl8366rb net: dsa: realtek: do not assert reset on remove net: dsa: realtek: add LED drivers for rtl8366rb drivers/net/dsa/realtek/rtl8366rb.c | 363 +++++++++++++++++++++++++++--------- drivers/net/dsa/realtek/rtl83xx.c | 7 +- 2 files changed, 273 insertions(+), 97 deletions(-) --- base-commit: 5c4c0edca68a5841a8d53ccd49596fe199c8334c change-id: 20240212-realtek-led-a665ae39a9c5 Best regards,