mbox series

[0/6] s390: Unify IUCV device allocation

Message ID 20240506194454.1160315-1-hca@linux.ibm.com (mailing list archive)
Headers show
Series s390: Unify IUCV device allocation | expand

Message

Heiko Carstens May 6, 2024, 7:44 p.m. UTC 
Unify IUCV device allocation as suggested by Arnd Bergmann in order
to get rid of code duplication in various device drivers.

This also removes various warnings caused by
-Wcast-function-type-strict as reported by Nathan Lynch.

Unless there are objections I think this whole series should go via
the s390 tree.

Heiko Carstens (6):
  s390/iucv: Provide iucv_alloc_device() / iucv_release_device()
  s390/vmlogrdr: Make use of iucv_alloc_device()
  s390/netiucv: Make use of iucv_alloc_device()
  s390/smsgiucv_app: Make use of iucv_alloc_device()
  tty: hvc-iucv: Make use of iucv_alloc_device()
  s390/iucv: Unexport iucv_root

 drivers/s390/char/vmlogrdr.c    | 20 +++--------------
 drivers/s390/net/netiucv.c      | 20 ++++-------------
 drivers/s390/net/smsgiucv_app.c | 21 +++++-------------
 drivers/tty/hvc/hvc_iucv.c      | 15 ++-----------
 include/net/iucv/iucv.h         |  7 +++++-
 net/iucv/iucv.c                 | 38 +++++++++++++++++++++++++++++++--
 6 files changed, 56 insertions(+), 65 deletions(-)

Comments

Alexandra Winter May 7, 2024, 9:39 a.m. UTC | #1 
On 06.05.24 21:44, Heiko Carstens wrote:
> Unify IUCV device allocation as suggested by Arnd Bergmann in order
> to get rid of code duplication in various device drivers.
> 
> This also removes various warnings caused by
> -Wcast-function-type-strict as reported by Nathan Lynch.
> 
> Unless there are objections I think this whole series should go via
> the s390 tree.
> 
> Heiko Carstens (6):
>   s390/iucv: Provide iucv_alloc_device() / iucv_release_device()
>   s390/vmlogrdr: Make use of iucv_alloc_device()
>   s390/netiucv: Make use of iucv_alloc_device()
>   s390/smsgiucv_app: Make use of iucv_alloc_device()
>   tty: hvc-iucv: Make use of iucv_alloc_device()
>   s390/iucv: Unexport iucv_root
> 
>  drivers/s390/char/vmlogrdr.c    | 20 +++--------------
>  drivers/s390/net/netiucv.c      | 20 ++++-------------
>  drivers/s390/net/smsgiucv_app.c | 21 +++++-------------
>  drivers/tty/hvc/hvc_iucv.c      | 15 ++-----------
>  include/net/iucv/iucv.h         |  7 +++++-
>  net/iucv/iucv.c                 | 38 +++++++++++++++++++++++++++++++--
>  6 files changed, 56 insertions(+), 65 deletions(-)
> 

Thank you, Heiko.
For the series:
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Heiko Carstens May 7, 2024, 12:32 p.m. UTC | #2 
On Mon, May 06, 2024 at 09:44:48PM +0200, Heiko Carstens wrote:
> Unify IUCV device allocation as suggested by Arnd Bergmann in order
> to get rid of code duplication in various device drivers.
> 
> This also removes various warnings caused by
> -Wcast-function-type-strict as reported by Nathan Lynch.
                                             ^^^^^^^^^^^^

Ahem :)

This should have been Nathan Chancellor, of course. Sorry for this!
Nathan Chancellor May 7, 2024, 2:33 p.m. UTC | #3 
On Tue, May 07, 2024 at 02:32:20PM +0200, Heiko Carstens wrote:
> On Mon, May 06, 2024 at 09:44:48PM +0200, Heiko Carstens wrote:
> > Unify IUCV device allocation as suggested by Arnd Bergmann in order
> > to get rid of code duplication in various device drivers.
> > 
> > This also removes various warnings caused by
> > -Wcast-function-type-strict as reported by Nathan Lynch.
>                                              ^^^^^^^^^^^^
> 
> Ahem :)
> 
> This should have been Nathan Chancellor, of course. Sorry for this!

Heh, at least you got it right on the patches :)

Cheers,
Nathan