| Message ID | 20240508072944.54880-1-steffen@innosonix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing | expand |
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Wed, 8 May 2024 09:29:42 +0200 you wrote: > As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to > be filled") > Marvell 88e6320/21 switches fail to be probed: > > ... > mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfaces > error creating PHYLINK: -22 > ... > > [...] Here is the summary with links: - [v2,net,1/2] net: dsa: mv88e6xxx: add phylink_get_caps for the mv88e6320/21 family https://git.kernel.org/netdev/net/c/f39bf3cf08a4 - [v2,net,2/2] net: dsa: mv88e6xxx: read cmode on mv88e6320/21 serdes only ports https://git.kernel.org/netdev/net/c/6e7ffa180a53 You are awesome, thank you!
As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled") Marvell 88e6320/21 switches fail to be probed: ... mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfaces error creating PHYLINK: -22 ... The problem stems from the use of mv88e6185_phylink_get_caps() to get the device capabilities. Since there are serdes only ports 0/1 included, create a new dedicated phylink_get_caps for the 6320 and 6321 to properly support their set of capabilities. Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled") Steffen Bätz (2): net: dsa: mv88e6xxx: add phylink_get_caps for the mv88e6320/21 family net: dsa: mv88e6xxx: read cmode on mv88e6320/21 serdes only ports drivers/net/dsa/mv88e6xxx/chip.c | 39 +++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 8 deletions(-) Changes since v1: - Removed unused variables. - Collected Reviewed-by tags from Andrew and Fabio