| Message ID | 20240524205227.244375-1-irogers@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use BPF filters for a "perf top -u" workaround | expand |
On Fri, May 24, 2024 at 1:52 PM Ian Rogers <irogers@google.com> wrote: > > Allow uid and gid to be terms in BPF filters by first breaking the > connection between filter terms and PERF_SAMPLE_xx values. Calculate > the uid and gid using the bpf_get_current_uid_gid helper, rather than > from a value in the sample. Allow filters to be passed to perf top, this allows: > > $ perf top -e cycles:P --filter "uid == $(id -u)" > > to work as a "perf top -u" workaround, as "perf top -u" usually fails > due to processes/threads terminating between the /proc scan and the > perf_event_open. > > v3. Move PERF_SAMPLE_xx asserts to sample_filter.bpf.c to avoid > conflicting definitions between vmlinux.h and perf_event.h as > reported by Namhyung. > v2. Allow PERF_SAMPLE_xx to be computed from the PBF_TERM_xx value > using a shift as requested by Namhyung. > > Ian Rogers (3): > perf bpf filter: Give terms their own enum > perf bpf filter: Add uid and gid terms > perf top: Allow filters on events Acked-by: Namhyung Kim <namhyung@kernel.org> Thanks, Namhyung > > tools/perf/Documentation/perf-record.txt | 2 +- > tools/perf/Documentation/perf-top.txt | 4 ++ > tools/perf/builtin-top.c | 9 +++ > tools/perf/util/bpf-filter.c | 33 +++++---- > tools/perf/util/bpf-filter.h | 5 +- > tools/perf/util/bpf-filter.l | 66 +++++++++--------- > tools/perf/util/bpf-filter.y | 7 +- > tools/perf/util/bpf_skel/sample-filter.h | 40 ++++++++++- > tools/perf/util/bpf_skel/sample_filter.bpf.c | 73 +++++++++++++++----- > 9 files changed, 169 insertions(+), 70 deletions(-) > > -- > 2.45.1.288.g0e0cd299f1-goog >
On Fri, 24 May 2024 13:52:24 -0700, Ian Rogers wrote: > Allow uid and gid to be terms in BPF filters by first breaking the > connection between filter terms and PERF_SAMPLE_xx values. Calculate > the uid and gid using the bpf_get_current_uid_gid helper, rather than > from a value in the sample. Allow filters to be passed to perf top, this allows: > > $ perf top -e cycles:P --filter "uid == $(id -u)" > > [...] Applied to perf-tools-next, thanks! [1/3] perf bpf filter: Give terms their own enum commit: 63b9cbd7941aa9ec5cb61567042176c4ce04b020 [2/3] perf bpf filter: Add uid and gid terms commit: d92aa899fe0a66350303a1986d6dc7ec4b3a1ea7 [3/3] perf top: Allow filters on events commit: af752016340021d433a962063067e819dba889b1 Best regards,
Allow uid and gid to be terms in BPF filters by first breaking the connection between filter terms and PERF_SAMPLE_xx values. Calculate the uid and gid using the bpf_get_current_uid_gid helper, rather than from a value in the sample. Allow filters to be passed to perf top, this allows: $ perf top -e cycles:P --filter "uid == $(id -u)" to work as a "perf top -u" workaround, as "perf top -u" usually fails due to processes/threads terminating between the /proc scan and the perf_event_open. v3. Move PERF_SAMPLE_xx asserts to sample_filter.bpf.c to avoid conflicting definitions between vmlinux.h and perf_event.h as reported by Namhyung. v2. Allow PERF_SAMPLE_xx to be computed from the PBF_TERM_xx value using a shift as requested by Namhyung. Ian Rogers (3): perf bpf filter: Give terms their own enum perf bpf filter: Add uid and gid terms perf top: Allow filters on events tools/perf/Documentation/perf-record.txt | 2 +- tools/perf/Documentation/perf-top.txt | 4 ++ tools/perf/builtin-top.c | 9 +++ tools/perf/util/bpf-filter.c | 33 +++++---- tools/perf/util/bpf-filter.h | 5 +- tools/perf/util/bpf-filter.l | 66 +++++++++--------- tools/perf/util/bpf-filter.y | 7 +- tools/perf/util/bpf_skel/sample-filter.h | 40 ++++++++++- tools/perf/util/bpf_skel/sample_filter.bpf.c | 73 +++++++++++++++----- 9 files changed, 169 insertions(+), 70 deletions(-)