mbox series

[net-next,v4,0/3] net: ethernet: cortina: Use phylib for RX and TX pause

Message ID 20240529-gemini-phylib-fixes-v4-0-16487ca4c2fe@linaro.org (mailing list archive)
Headers show
Series net: ethernet: cortina: Use phylib for RX and TX pause | expand

Message

Linus Walleij May 29, 2024, 1:59 p.m. UTC
This patch series switches the Cortina Gemini ethernet
driver to use phylib to set up RX and TX pause for the
PHY.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v4:
- Drop the register setting in .set_pauseparam(), just call
  phylib and let .adjust_link() handle this.
- Link to v3: https://lore.kernel.org/r/20240513-gemini-ethernet-fix-tso-v3-0-b442540cc140@linaro.org

Changes in v3:
- Do the pause setting unconditionally in the full duplex
  case in adjust_link just like the code used to be,
  phydev->autoneg should not influence this.
- Bail out of .set_pauseparam() if pparam->autoneg is not
  true.
- Link to v2: https://lore.kernel.org/r/20240511-gemini-ethernet-fix-tso-v2-0-2ed841574624@linaro.org

Changes in v2:
- Add a new patch to rename the gmac_adjust_link callback to
  a recognized name.
- Add a new patch to make the driver use the autonegitiated
  RX and TX pause settings from phylib.
- Rewrite the set_pauseparam() patch to use the existing
  gmac_set_flow_control() function.
- Add a call to phy_set_asym_pause() in the set_pauseparam
  callback, so the phylib is informed of the new TX/RX setting.
- Link to v1: https://lore.kernel.org/r/20240509-gemini-ethernet-fix-tso-v1-0-10cd07b54d1c@linaro.org

---
Linus Walleij (3):
      net: ethernet: cortina: Rename adjust link callback
      net: ethernet: cortina: Use negotiated TX/RX pause
      net: ethernet: cortina: Implement .set_pauseparam()

 drivers/net/ethernet/cortina/gemini.c | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240527-gemini-phylib-fixes-c2c0460be20b

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org June 1, 2024, 11:20 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 29 May 2024 15:59:59 +0200 you wrote:
> This patch series switches the Cortina Gemini ethernet
> driver to use phylib to set up RX and TX pause for the
> PHY.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes in v4:
> - Drop the register setting in .set_pauseparam(), just call
>   phylib and let .adjust_link() handle this.
> - Link to v3: https://lore.kernel.org/r/20240513-gemini-ethernet-fix-tso-v3-0-b442540cc140@linaro.org
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/3] net: ethernet: cortina: Rename adjust link callback
    https://git.kernel.org/netdev/net-next/c/a967d3cee86e
  - [net-next,v4,2/3] net: ethernet: cortina: Use negotiated TX/RX pause
    https://git.kernel.org/netdev/net-next/c/15c22101db71
  - [net-next,v4,3/3] net: ethernet: cortina: Implement .set_pauseparam()
    https://git.kernel.org/netdev/net-next/c/dbdb0918da67

You are awesome, thank you!