mbox series

[net-next,0/8] Probing cleanup for the Felix DSA driver

Message ID 20240530163333.2458884-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Probing cleanup for the Felix DSA driver | expand

Message

Vladimir Oltean May 30, 2024, 4:33 p.m. UTC
This is a follow-up to Russell King's request for code consolidation
among felix_vsc9959, seville_vsc9953 and ocelot_ext, stated here:
https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/

Details are in individual patches. Testing was done on NXP LS1028A
(felix_vsc9959).

Vladimir Oltean (8):
  net: dsa: ocelot: use devres in ocelot_ext_probe()
  net: dsa: ocelot: use devres in seville_probe()
  net: dsa: ocelot: delete open coded status = "disabled" parsing
  net: dsa: ocelot: consistently use devres in felix_pci_probe()
  net: dsa: ocelot: move devm_request_threaded_irq() to felix_setup()
  net: dsa: ocelot: use ds->num_tx_queues = OCELOT_NUM_TC for all models
  net: dsa: ocelot: common probing code
  net: dsa: ocelot: unexport felix_phylink_mac_ops and felix_switch_ops

 drivers/net/dsa/ocelot/felix.c           |  62 ++++++++++++-
 drivers/net/dsa/ocelot/felix.h           |  10 +-
 drivers/net/dsa/ocelot/felix_vsc9959.c   | 113 +++++++----------------
 drivers/net/dsa/ocelot/ocelot_ext.c      |  55 +----------
 drivers/net/dsa/ocelot/seville_vsc9953.c |  61 ++----------
 5 files changed, 106 insertions(+), 195 deletions(-)

Comments

Colin Foster May 31, 2024, 3:08 a.m. UTC | #1
Hi Vladimir,

On Thu, May 30, 2024 at 07:33:25PM +0300, Vladimir Oltean wrote:
> This is a follow-up to Russell King's request for code consolidation
> among felix_vsc9959, seville_vsc9953 and ocelot_ext, stated here:
> https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/
> 
> Details are in individual patches. Testing was done on NXP LS1028A
> (felix_vsc9959).
> 
> Vladimir Oltean (8):
>   net: dsa: ocelot: use devres in ocelot_ext_probe()
>   net: dsa: ocelot: use devres in seville_probe()
>   net: dsa: ocelot: delete open coded status = "disabled" parsing
>   net: dsa: ocelot: consistently use devres in felix_pci_probe()
>   net: dsa: ocelot: move devm_request_threaded_irq() to felix_setup()
>   net: dsa: ocelot: use ds->num_tx_queues = OCELOT_NUM_TC for all models
>   net: dsa: ocelot: common probing code
>   net: dsa: ocelot: unexport felix_phylink_mac_ops and felix_switch_ops
> 
>  drivers/net/dsa/ocelot/felix.c           |  62 ++++++++++++-
>  drivers/net/dsa/ocelot/felix.h           |  10 +-
>  drivers/net/dsa/ocelot/felix_vsc9959.c   | 113 +++++++----------------
>  drivers/net/dsa/ocelot/ocelot_ext.c      |  55 +----------

Just FYI I tried testing this but hit an unrelated regression in 6.10,
and a `git b4` on 6.9.3 has conflicts. So I'm still alive, but probably
won't get to testing this tonight. Looks good though.

Colin Foster
Russell King (Oracle) May 31, 2024, 7:47 a.m. UTC | #2
On Thu, May 30, 2024 at 10:08:10PM -0500, Colin Foster wrote:
> Hi Vladimir,
> 
> On Thu, May 30, 2024 at 07:33:25PM +0300, Vladimir Oltean wrote:
> > This is a follow-up to Russell King's request for code consolidation
> > among felix_vsc9959, seville_vsc9953 and ocelot_ext, stated here:
> > https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/
> > 
> > Details are in individual patches. Testing was done on NXP LS1028A
> > (felix_vsc9959).
> > 
> > Vladimir Oltean (8):
> >   net: dsa: ocelot: use devres in ocelot_ext_probe()
> >   net: dsa: ocelot: use devres in seville_probe()
> >   net: dsa: ocelot: delete open coded status = "disabled" parsing
> >   net: dsa: ocelot: consistently use devres in felix_pci_probe()
> >   net: dsa: ocelot: move devm_request_threaded_irq() to felix_setup()
> >   net: dsa: ocelot: use ds->num_tx_queues = OCELOT_NUM_TC for all models
> >   net: dsa: ocelot: common probing code
> >   net: dsa: ocelot: unexport felix_phylink_mac_ops and felix_switch_ops
> > 
> >  drivers/net/dsa/ocelot/felix.c           |  62 ++++++++++++-
> >  drivers/net/dsa/ocelot/felix.h           |  10 +-
> >  drivers/net/dsa/ocelot/felix_vsc9959.c   | 113 +++++++----------------
> >  drivers/net/dsa/ocelot/ocelot_ext.c      |  55 +----------
> 
> Just FYI I tried testing this but hit an unrelated regression in 6.10,
> and a `git b4` on 6.9.3 has conflicts. So I'm still alive, but probably
> won't get to testing this tonight. Looks good though.

You will need... the net-next tree because it's dependent on a patch I
submitted earlier this week.
patchwork-bot+netdevbpf@kernel.org June 3, 2024, 12:10 p.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 30 May 2024 19:33:25 +0300 you wrote:
> This is a follow-up to Russell King's request for code consolidation
> among felix_vsc9959, seville_vsc9953 and ocelot_ext, stated here:
> https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/
> 
> Details are in individual patches. Testing was done on NXP LS1028A
> (felix_vsc9959).
> 
> [...]

Here is the summary with links:
  - [net-next,1/8] net: dsa: ocelot: use devres in ocelot_ext_probe()
    https://git.kernel.org/netdev/net-next/c/454cfffe8dc1
  - [net-next,2/8] net: dsa: ocelot: use devres in seville_probe()
    https://git.kernel.org/netdev/net-next/c/90ee9a5b49ce
  - [net-next,3/8] net: dsa: ocelot: delete open coded status = "disabled" parsing
    https://git.kernel.org/netdev/net-next/c/cc711c523da7
  - [net-next,4/8] net: dsa: ocelot: consistently use devres in felix_pci_probe()
    https://git.kernel.org/netdev/net-next/c/4510bbd38cbe
  - [net-next,5/8] net: dsa: ocelot: move devm_request_threaded_irq() to felix_setup()
    https://git.kernel.org/netdev/net-next/c/0367a1775933
  - [net-next,6/8] net: dsa: ocelot: use ds->num_tx_queues = OCELOT_NUM_TC for all models
    https://git.kernel.org/netdev/net-next/c/4ca54dd96eca
  - [net-next,7/8] net: dsa: ocelot: common probing code
    https://git.kernel.org/netdev/net-next/c/efdbee7d0791
  - [net-next,8/8] net: dsa: ocelot: unexport felix_phylink_mac_ops and felix_switch_ops
    https://git.kernel.org/netdev/net-next/c/a4303941c6f3

You are awesome, thank you!