| Message ID | 20240615022641.210320-1-rafael@rcpassos.me (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix compiler warnings, looking for suggestions | expand |
On Fri, Jun 14, 2024 at 11:24:07PM -0300, Rafael Passos wrote: > Hi, > This patchset has a few fixes to compiler warnings. curious, which compiler/setup displayed the warnings? > I am studying the BPF subsystem and wish to bring more tangible contributions. > I would appreciate receiving suggestions on things to investigate. > I also documented a bit in my blog. I could help with docs here, too. > https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics > Thanks! > > Changelog V1 -> V2: > - rebased all commits to updated for-next base > - removes new cases of the extra parameter for bpf_jit_binary_pack_finalize > - built and tested for ARM64 > - sent the series for the test workflow: > https://github.com/kernel-patches/bpf/pull/7198 > > > Rafael Passos (3): > bpf: remove unused parameter in bpf_jit_binary_pack_finalize > bpf: remove unused parameter in __bpf_free_used_btfs > bpf: remove redeclaration of new_n in bpf_verifier_vlog lgtm, nice cleanup Acked-by: Jiri Olsa <jolsa@kernel.org> jirka > > arch/arm64/net/bpf_jit_comp.c | 3 +-- > arch/powerpc/net/bpf_jit_comp.c | 4 ++-- > arch/riscv/net/bpf_jit_core.c | 5 ++--- > arch/x86/net/bpf_jit_comp.c | 4 ++-- > include/linux/bpf.h | 3 +-- > include/linux/filter.h | 3 +-- > kernel/bpf/core.c | 8 +++----- > kernel/bpf/log.c | 2 +- > kernel/bpf/verifier.c | 3 +-- > 9 files changed, 14 insertions(+), 21 deletions(-) > > -- > 2.45.2 > >
On 17/06/2024 05:45, Jiri Olsa wrote: > On Fri, Jun 14, 2024 at 11:24:07PM -0300, Rafael Passos wrote: >> Hi, >> This patchset has a few fixes to compiler warnings. > curious, which compiler/setup displayed the warnings? > It took me a few tries with different configs. My most successful one was using gcc (14.1.1) make -j24 ARCH=x86_64 W=12 2>&1 | tee warnings.log I dug through the Logs (with grep)looking for BPF and non macro expansion warnings. Thanks! >> I am studying the BPF subsystem and wish to bring more tangible contributions. >> I would appreciate receiving suggestions on things to investigate. >> I also documented a bit in my blog. I could help with docs here, too. >> https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics >> Thanks! >> >> Changelog V1 -> V2: >> - rebased all commits to updated for-next base >> - removes new cases of the extra parameter for bpf_jit_binary_pack_finalize >> - built and tested for ARM64 >> - sent the series for the test workflow: >> https://github.com/kernel-patches/bpf/pull/7198 >> >> >> Rafael Passos (3): >> bpf: remove unused parameter in bpf_jit_binary_pack_finalize >> bpf: remove unused parameter in __bpf_free_used_btfs >> bpf: remove redeclaration of new_n in bpf_verifier_vlog > lgtm, nice cleanup > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > jirka > > >> arch/arm64/net/bpf_jit_comp.c | 3 +-- >> arch/powerpc/net/bpf_jit_comp.c | 4 ++-- >> arch/riscv/net/bpf_jit_core.c | 5 ++--- >> arch/x86/net/bpf_jit_comp.c | 4 ++-- >> include/linux/bpf.h | 3 +-- >> include/linux/filter.h | 3 +-- >> kernel/bpf/core.c | 8 +++----- >> kernel/bpf/log.c | 2 +- >> kernel/bpf/verifier.c | 3 +-- >> 9 files changed, 14 insertions(+), 21 deletions(-) >> >> -- >> 2.45.2 >> >>
Rafael Passos <rafael@rcpassos.me> writes: > Hi, > This patchset has a few fixes to compiler warnings. > I am studying the BPF subsystem and wish to bring more tangible contributions. > I would appreciate receiving suggestions on things to investigate. > I also documented a bit in my blog. I could help with docs here, too. > https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics > Thanks! > > Changelog V1 -> V2: > - rebased all commits to updated for-next base > - removes new cases of the extra parameter for bpf_jit_binary_pack_finalize > - built and tested for ARM64 > - sent the series for the test workflow: > https://github.com/kernel-patches/bpf/pull/7198 > > > Rafael Passos (3): > bpf: remove unused parameter in bpf_jit_binary_pack_finalize > bpf: remove unused parameter in __bpf_free_used_btfs > bpf: remove redeclaration of new_n in bpf_verifier_vlog > > arch/arm64/net/bpf_jit_comp.c | 3 +-- > arch/powerpc/net/bpf_jit_comp.c | 4 ++-- > arch/riscv/net/bpf_jit_core.c | 5 ++--- > arch/x86/net/bpf_jit_comp.c | 4 ++-- > include/linux/bpf.h | 3 +-- > include/linux/filter.h | 3 +-- > kernel/bpf/core.c | 8 +++----- > kernel/bpf/log.c | 2 +- > kernel/bpf/verifier.c | 3 +-- > 9 files changed, 14 insertions(+), 21 deletions(-) > > -- > 2.45.2 Acked-by: Puranjay Mohan <puranjay@kernel.org> Thanks, Puranjay
Hello: This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <ast@kernel.org>: On Fri, 14 Jun 2024 23:24:07 -0300 you wrote: > Hi, > This patchset has a few fixes to compiler warnings. > I am studying the BPF subsystem and wish to bring more tangible contributions. > I would appreciate receiving suggestions on things to investigate. > I also documented a bit in my blog. I could help with docs here, too. > https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics > Thanks! > > [...] Here is the summary with links: - [bpf-next,V2,1/3] bpf: remove unused parameter in bpf_jit_binary_pack_finalize https://git.kernel.org/bpf/bpf-next/c/9919c5c98cb2 - [bpf-next,V2,2/3] bpf: remove unused parameter in __bpf_free_used_btfs https://git.kernel.org/bpf/bpf-next/c/ab224b9ef7c4 - [bpf-next,V2,3/3] bpf: remove redeclaration of new_n in bpf_verifier_vlog https://git.kernel.org/bpf/bpf-next/c/21ab4980e02d You are awesome, thank you!