mbox series

[net-next,0/6] net: ethtool: reduce RTNL pressure in dev_ethtool()

Message ID 20240620114711.777046-1-edumazet@google.com (mailing list archive)
Headers show
Series net: ethtool: reduce RTNL pressure in dev_ethtool() | expand

Message

Eric Dumazet June 20, 2024, 11:47 a.m. UTC
This series is inspired by Jakub feedback for one gve patch :

https://lore.kernel.org/lkml/20240614192721.02700256@kernel.org/

Refactor dev_ethtool() and start to implement parallel operations.

Eric Dumazet (6):
  net: ethtool: grab a netdev reference in dev_ethtool()
  net: ethtool: add dev_ethtool_cap_check()
  net: ethtool: perform pm duties outside of rtnl lock
  net: ethtool: call ethtool_get_one_feature() without RTNL
  net: ethtool: implement lockless ETHTOOL_GFLAGS
  net: ethtool: add the ability to run ethtool_[gs]et_rxnfc() without
    RTNL

 include/linux/ethtool.h |   2 +
 net/core/dev.c          |  10 +--
 net/ethtool/ioctl.c     | 159 ++++++++++++++++++++++++----------------
 3 files changed, 101 insertions(+), 70 deletions(-)

Comments

Willem de Bruijn June 20, 2024, 5:58 p.m. UTC | #1
Eric Dumazet wrote:
> This series is inspired by Jakub feedback for one gve patch :
> 
> https://lore.kernel.org/lkml/20240614192721.02700256@kernel.org/
> 
> Refactor dev_ethtool() and start to implement parallel operations.
> 
> Eric Dumazet (6):
>   net: ethtool: grab a netdev reference in dev_ethtool()
>   net: ethtool: add dev_ethtool_cap_check()
>   net: ethtool: perform pm duties outside of rtnl lock
>   net: ethtool: call ethtool_get_one_feature() without RTNL
>   net: ethtool: implement lockless ETHTOOL_GFLAGS
>   net: ethtool: add the ability to run ethtool_[gs]et_rxnfc() without
>     RTNL
> 
>  include/linux/ethtool.h |   2 +
>  net/core/dev.c          |  10 +--
>  net/ethtool/ioctl.c     | 159 ++++++++++++++++++++++++----------------
>  3 files changed, 101 insertions(+), 70 deletions(-)

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks Eric!

One small comment in the ethtool_ops field, but not important.