[net-next,v4,0/7] net: pse-pd: Add new PSE c33 features

Message

Kory Maincent June 25, 2024, 12:33 p.m. UTC

From: Kory Maincent (Dent Project) <[e-mail]>

This patch series adds new c33 features to the PSE API.
- Expand the PSE PI informations status with power, class and failure
  reason
- Add the possibility to get and set the PSE PIs power limit

Changes in v4:
- Made few update in PSE extended state an substate.
- Add support for c33 pse power limit ranges.
- Few changes in the specs and the documentation.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Use u32 instead of u8 size for c33 pse extended state and substate.
- Reformat the state and substate enumeration to follow Oleksij proposal which
  is more IEEE 802.3 standard compliant
- Sent the first patch standalone in net.
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Use uA and uV instead of mA and mV to have more precision in the power
  calculation. Need to use 64bit variables for the calculation.
- Modify the pd-92x0behavior in case of setting the current out of the
  available ranges. Report an error now.
- Link to v1: https://lore.kernel.org/r/[e-mail]

Signed-off-by: Kory Maincent <[e-mail]>
---
Kory Maincent (7):
      net: ethtool: pse-pd: Expand C33 PSE status with class, power and extended state
      netlink: specs: Expand the PSE netlink command with C33 new features
      net: pse-pd: pd692x0: Expand ethtool status message
      net: pse-pd: Add new power limit get and set c33 features
      net: ethtool: Add new power limit get and set features
      netlink: specs: Expand the PSE netlink command with C33 pw-limit attributes
      net: pse-pd: pd692x0: Enhance with new current limit and voltage read callbacks

 Documentation/netlink/specs/ethtool.yaml     |  58 +++++
 Documentation/networking/ethtool-netlink.rst |  87 +++++++-
 drivers/net/pse-pd/pd692x0.c                 | 317 ++++++++++++++++++++++++++-
 drivers/net/pse-pd/pse_core.c                | 172 ++++++++++++++-
 include/linux/ethtool.h                      |  20 ++
 include/linux/pse-pd/pse.h                   |  51 +++++
 include/uapi/linux/ethtool.h                 | 191 ++++++++++++++++
 include/uapi/linux/ethtool_netlink.h         |  12 +
 net/ethtool/pse-pd.c                         | 119 +++++++++-
 9 files changed, 997 insertions(+), 30 deletions(-)
---
base-commit: b98d89947d124c8ca9150b32fdc0c5fb099243cf
change-id: 20240425-feature_poe_power_cap-18e90ba7294b

Best regards,

Comments

Jakub Kicinski June 26, 2024, 1:41 a.m. UTC | #1

On Tue, 25 Jun 2024 14:33:45 +0200 Kory Maincent wrote:
> This patch series adds new c33 features to the PSE API.
> - Expand the PSE PI informations status with power, class and failure
>   reason
> - Add the possibility to get and set the PSE PIs power limit

Looks like we have a conflict on patch 6 now, please rebase

Kory Maincent June 26, 2024, 7:52 a.m. UTC | #2

On Tue, 25 Jun 2024 18:41:44 -0700
Jakub Kicinski <[e-mail]> wrote:

> On Tue, 25 Jun 2024 14:33:45 +0200 Kory Maincent wrote:
>  [...]  
> 
> Looks like we have a conflict on patch 6 now, please rebase

Ah indeed! In fact it conflicts because it is based on this patch which is
merge mainline in net:
https://lore.kernel.org/netdev/[e-mail]/

Do you know when and how often net-next is rebased on top of net?
Sorry, I should have checked it before sending this version.

Regards,

Jakub Kicinski June 26, 2024, 1:27 p.m. UTC | #3

On Wed, 26 Jun 2024 09:52:11 +0200 Kory Maincent wrote:
> Do you know when and how often net-next is rebased on top of net?

Every Thursday, usually around noon PST but exact timing depends on when
Linus pulls and how quickly I notice that he did :)

Kory Maincent June 26, 2024, 3:25 p.m. UTC | #4

On Wed, 26 Jun 2024 06:27:11 -0700
Jakub Kicinski <[e-mail]> wrote:

> On Wed, 26 Jun 2024 09:52:11 +0200 Kory Maincent wrote:
>  [...]  
> 
> Every Thursday, usually around noon PST but exact timing depends on when
> Linus pulls and how quickly I notice that he did :)

Ok, thanks for the information!

Regards,