mbox series

[net-next,v2,0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload

Message ID 20240626-linux-udpgso-v2-0-422dfcbd6b48@cloudflare.com (mailing list archive)
Headers show
Series Lift UDP_SEGMENT restriction for egress via device w/o csum offload | expand

Message

Jakub Sitnicki June 26, 2024, 5:51 p.m. UTC
This is a follow-up to an earlier question [1] if we can make UDP GSO work with
any egress device, even those with no checksum offload capability. That's the
default setup for TUN/TAP.

Because there is a change in behavior - sendmsg() does no longer return EIO
error - I'm submitting through net-next tree, rather than net, as per Willem's
advice.

[1] https://lore.kernel.org/netdev/87jzqsld6q.fsf@cloudflare.com/

To: netdev@vger.kernel.org
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: kernel-team@cloudflare.com
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>

Changes in v2:
- Fixup ip link arguments order (Jakub)
- Describe performance impact compared to regular sendmsg (Willem)
- Link to v1: https://lore.kernel.org/r/20240622-linux-udpgso-v1-0-d2344157ab2a@cloudflare.com

---
Jakub Sitnicki (2):
      udp: Allow GSO transmit from devices with no checksum offload
      selftests/net: Add test coverage for UDP GSO software fallback

 net/ipv4/udp.c                        |  3 +--
 net/ipv4/udp_offload.c                |  8 +++++++
 net/ipv6/udp.c                        |  3 +--
 tools/testing/selftests/net/udpgso.c  | 15 +++++++++---
 tools/testing/selftests/net/udpgso.sh | 43 +++++++++++++++++++++++++++++++++++
 5 files changed, 65 insertions(+), 7 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 29, 2024, 1:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 26 Jun 2024 19:51:25 +0200 you wrote:
> This is a follow-up to an earlier question [1] if we can make UDP GSO work with
> any egress device, even those with no checksum offload capability. That's the
> default setup for TUN/TAP.
> 
> Because there is a change in behavior - sendmsg() does no longer return EIO
> error - I'm submitting through net-next tree, rather than net, as per Willem's
> advice.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] udp: Allow GSO transmit from devices with no checksum offload
    https://git.kernel.org/netdev/net-next/c/10154dbded6d
  - [net-next,v2,2/2] selftests/net: Add test coverage for UDP GSO software fallback
    https://git.kernel.org/netdev/net-next/c/3e400219c04d

You are awesome, thank you!