From patchwork Thu Jun 27 08:49:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Roullier X-Patchwork-Id: 13713990 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6429819; Thu, 27 Jun 2024 08:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719478347; cv=none; b=LSzHxA601w1AWO4OWAcU+FU3Y2ZN7rrcLtHpjqw+ZOi+rLhr3XKbCdW3F8kJO+4Hy7ZepLriJyiGNTCb/AgMiMISxIIfD3pR0XKBMtbyXY0HS3121tO3Ka4VEhUk+DEiU1AIHL0HPhaotYmDmqPC3d0lLJ6oJskFylnBfmFyHdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719478347; c=relaxed/simple; bh=rDV19PZw70n7byzylmXZn+TImYd3qQsvAQ6zaSifIWY=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=HTV+KOz6EeIF5vwfTqEDU9rDolDkI47IgNgWESEbLVsbEkhTe86N6pkkGAl24j2jMb0eiiOR+oOozef1jrT/CSukdLNhmItNZ2YuFpWt4+DBLDnAWz/PWk5LnVSNj2q0mZFJGax+ssaRGjl4un1bua5W2bFEiVz5rNEwKuOHpRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=BUUDFCyW; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="BUUDFCyW" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45R6suEc025136; Thu, 27 Jun 2024 10:50:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=UEPDtkwS6mWQxqmVu+aQzn Nw+twWmzwbU06XGY49NsQ=; b=BUUDFCyWmif/XpmyOVTOfW0kNwDNQ/AfzhHnwS GwvCmHFguF5wM0+QycdeniiC8hwLqKzLuXiqEMh9P/gBnSV/Mj97TXgaGj7aXO+Y Z7gUoa8lX9zsPgoIvjATGV9F/2JIo9caF6oVWKsD3JVJ07AfiwJhGSpONwoU/cBr 09qqkoi9iTruFfzL8WK7rygh+Dk+aYR9KDY7r7YwYuGqt0apM2hQyWz9mpKm3RBf JC+dJOm7HE+eiH5iyZEB5RVhpj0JPB3duA80y4drfG1595Zb+bYn9yRxJ2r9O830 4TbbDGSMmCzbkYo1XHGilnP1n/EZkb5gJTveG3QQq3qLY+yQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3yx860tbfv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jun 2024 10:50:53 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id B238E40054; Thu, 27 Jun 2024 10:50:40 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 686BA2138E3; Thu, 27 Jun 2024 10:49:26 +0200 (CEST) Received: from localhost (10.48.86.164) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 27 Jun 2024 10:49:25 +0200 From: Christophe Roullier To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Christophe Roullier , Marek Vasut CC: , , , , Subject: [net-next,PATCH 0/2] Fixes for stm32-dwmac driver fails to probe Date: Thu, 27 Jun 2024 10:49:15 +0200 Message-ID: <20240627084917.327592-1-christophe.roullier@foss.st.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-27_05,2024-06-25_01,2024-05-17_01 X-Patchwork-Delegate: kuba@kernel.org Mark Brown found issue during stm32-dwmac probe: For the past few days networking has been broken on the Avenger 96, a stm32mp157a based platform. The stm32-dwmac driver fails to probe: <6>[ 1.894271] stm32-dwmac 5800a000.ethernet: IRQ eth_wake_irq not found <6>[ 1.899694] stm32-dwmac 5800a000.ethernet: IRQ eth_lpi not found <6>[ 1.905849] stm32-dwmac 5800a000.ethernet: IRQ sfty not found <3>[ 1.912304] stm32-dwmac 5800a000.ethernet: Unable to parse OF data <3>[ 1.918393] stm32-dwmac 5800a000.ethernet: probe with driver stm32-dwmac failed with error -75 which looks a bit odd given the commit contents but I didn't look at the driver code at all. Full boot log here: https://lava.sirena.org.uk/scheduler/job/467150 A working equivalent is here: https://lava.sirena.org.uk/scheduler/job/466518 I delivered 2 fixes to solve issue. Christophe Roullier (2): net: stmmac: dwmac-stm32: Add test to verify if ETHCK is used before checking clk rate net: stmmac: dwmac-stm32: update err status in case different of stm32mp13 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) base-commit: f261aa15b2ca73d4f9dbb8b116b16743237edad9 Tested-by: Mark Brown