mbox series

[v3,net-next,0/2] tcp: Make simultaneous connect() RFC-compliant.

Message ID 20240710171246.87533-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series tcp: Make simultaneous connect() RFC-compliant. | expand

Message

Kuniyuki Iwashima July 10, 2024, 5:12 p.m. UTC
Patch 1 fixes an issue that BPF TCP option parser is triggered for ACK
instead of SYN+ACK in the case of simultaneous connect().

Patch 2 removes an wrong assumption in tcp_ao/self-connnect tests.

v3:
  * Use (sk->sk_state == TCP_SYN_RECV && sk->sk_socket) to detect cross SYN case

v2: https://lore.kernel.org/netdev/20240708180852.92919-1-kuniyu@amazon.com/
  * Target net-next and remove Fixes: tag
  * Don't skip bpf_skops_parse_hdr() to centralise sk_state check
  * Remove unnecessary ACK after SYN+ACK
  * Add patch 2

v1: https://lore.kernel.org/netdev/20240704035703.95065-1-kuniyu@amazon.com/


Kuniyuki Iwashima (2):
  tcp: Don't drop SYN+ACK for simultaneous connect().
  selftests: tcp: Remove broken SNMP assumptions for TCP AO self-connect
    tests.

 net/ipv4/tcp_input.c                           |  9 +++++++++
 .../selftests/net/tcp_ao/self-connect.c        | 18 ------------------
 2 files changed, 9 insertions(+), 18 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 13, 2024, 10:30 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 10 Jul 2024 10:12:44 -0700 you wrote:
> Patch 1 fixes an issue that BPF TCP option parser is triggered for ACK
> instead of SYN+ACK in the case of simultaneous connect().
> 
> Patch 2 removes an wrong assumption in tcp_ao/self-connnect tests.
> 
> v3:
>   * Use (sk->sk_state == TCP_SYN_RECV && sk->sk_socket) to detect cross SYN case
> 
> [...]

Here is the summary with links:
  - [v3,net-next,1/2] tcp: Don't drop SYN+ACK for simultaneous connect().
    https://git.kernel.org/netdev/net-next/c/23e89e8ee7be
  - [v3,net-next,2/2] selftests: tcp: Remove broken SNMP assumptions for TCP AO self-connect tests.
    https://git.kernel.org/netdev/net-next/c/b3bb4d23a41b

You are awesome, thank you!