| Message ID | 20240711-fix_pse_pd_deref-v3-0-edd78fc4fe42@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: pse-pd: Fix possible issues with a PSE supporting both c33 and PoDL | expand |
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 11 Jul 2024 15:55:17 +0200 you wrote: > Although PSE controllers supporting both c33 and PoDL are not on the > market yet, we want to prevent potential issues from arising in the > future. Two possible issues could occur with a PSE supporting both c33 > and PoDL: > > - Setting the config for one type of PSE leaves the other type's config > null. In this case, the PSE core would return EOPNOTSUPP, which is not > the correct behavior. > - Null dereference of Netlink attributes as only one of the Netlink > attributes would be specified at a time. > > [...] Here is the summary with links: - [net,v3,1/2] net: pse-pd: Do not return EOPNOSUPP if config is null https://git.kernel.org/netdev/net/c/93c3a96c301f - [net,v3,2/2] net: ethtool: pse-pd: Fix possible null-deref https://git.kernel.org/netdev/net/c/4cddb0f15ea9 You are awesome, thank you!
Although PSE controllers supporting both c33 and PoDL are not on the market yet, we want to prevent potential issues from arising in the future. Two possible issues could occur with a PSE supporting both c33 and PoDL: - Setting the config for one type of PSE leaves the other type's config null. In this case, the PSE core would return EOPNOTSUPP, which is not the correct behavior. - Null dereference of Netlink attributes as only one of the Netlink attributes would be specified at a time. This patch series contains two patches to fix these issues. Changes in v3: - Add a cover letter and the net prefix Changes in v2: - Add a patch to deal with null config Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Kory Maincent (2): net: pse-pd: Do not return EOPNOSUPP if config is null net: ethtool: pse-pd: Fix possible null-deref drivers/net/pse-pd/pse_core.c | 4 ++-- net/ethtool/pse-pd.c | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) --- base-commit: d7c199e77ef2fe259ad5b1beca5ddd6c951fcba2 change-id: 20240711-fix_pse_pd_deref-6a7d0de068a4 Best regards,