mbox series

[net,0/3,pull,request] idpf: fix 3 bugs revealed by the Chapter I

Message ID 20240806220923.3359860-1-anthony.l.nguyen@intel.com (mailing list archive)
Headers show
Series idpf: fix 3 bugs revealed by the Chapter I | expand

Message

Tony Nguyen Aug. 6, 2024, 10:09 p.m. UTC 
Alexander Lobakin says:

The libeth conversion revealed 2 serious issues which lead to sporadic
crashes or WARNs under certain configurations. Additional one was found
while debugging these two with kmemleak.
This one is targeted stable, the rest can be backported manually later
if needed. They can be reproduced only after the conversion is applied
anyway.
---
iwl-net: https://lore.kernel.org/intel-wired-lan/20240724134024.2182959-1-aleksander.lobakin@intel.com/

The following are changes since commit 3e7917c0cdad835a5121520fc5686d954b7a61ab:
  net: linkwatch: use system_unbound_wq
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 200GbE

Alexander Lobakin (2):
  idpf: fix memory leaks and crashes while performing a soft reset
  idpf: fix UAFs when destroying the queues

Michal Kubiak (1):
  idpf: fix memleak in vport interrupt configuration

 drivers/net/ethernet/intel/idpf/idpf_lib.c  | 48 ++++++++++-----------
 drivers/net/ethernet/intel/idpf/idpf_txrx.c | 43 ++++--------------
 2 files changed, 33 insertions(+), 58 deletions(-)

Comments

Jakub Kicinski Aug. 8, 2024, 3:28 a.m. UTC | #1 
On Tue,  6 Aug 2024 15:09:19 -0700 Tony Nguyen wrote:
> The libeth conversion revealed 2 serious issues which lead to sporadic
> crashes or WARNs under certain configurations. Additional one was found
> while debugging these two with kmemleak.
> This one is targeted stable, the rest can be backported manually later
> if needed. They can be reproduced only after the conversion is applied
> anyway.
> ---
> iwl-net: https://lore.kernel.org/intel-wired-lan/20240724134024.2182959-1-aleksander.lobakin@intel.com/
> 
> The following are changes since commit 3e7917c0cdad835a5121520fc5686d954b7a61ab:
>   net: linkwatch: use system_unbound_wq
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 200GbE

Hm, my script doesn't like this branch, not sure why, I think it's
a bug in the script itself. But not enough time to investigate now,
I'll apply from the list.
patchwork-bot+netdevbpf@kernel.org Aug. 8, 2024, 3:30 a.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  6 Aug 2024 15:09:19 -0700 you wrote:
> Alexander Lobakin says:
> 
> The libeth conversion revealed 2 serious issues which lead to sporadic
> crashes or WARNs under certain configurations. Additional one was found
> while debugging these two with kmemleak.
> This one is targeted stable, the rest can be backported manually later
> if needed. They can be reproduced only after the conversion is applied
> anyway.
> 
> [...]

Here is the summary with links:
  - [net,1/3] idpf: fix memory leaks and crashes while performing a soft reset
    https://git.kernel.org/netdev/net/c/f01032a2ca09
  - [net,2/3] idpf: fix memleak in vport interrupt configuration
    https://git.kernel.org/netdev/net/c/3cc88e8405b8
  - [net,3/3] idpf: fix UAFs when destroying the queues
    https://git.kernel.org/netdev/net/c/290f1c033281

You are awesome, thank you!